-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[X86] Remove outdated comment #133743
base: main
Are you sure you want to change the base?
[X86] Remove outdated comment #133743
Conversation
Pinging @phoebewang @e-kud for review |
@llvm/pr-subscribers-backend-x86 Author: Mikołaj Piróg (mikolaj-pirog) ChangesA part of the comment is out of date -- the Intel SDM doesn't have a chapter (nor any string) named that way. We could update it, but I believe it's better to simply remove it -- it's hard to maintain, and I feel it's unnecessary. Full diff: https://github.com/llvm/llvm-project/pull/133743.diff 1 Files Affected:
diff --git a/llvm/lib/Target/X86/X86.td b/llvm/lib/Target/X86/X86.td
index 38761e1fd7eec..7421abf1968b9 100644
--- a/llvm/lib/Target/X86/X86.td
+++ b/llvm/lib/Target/X86/X86.td
@@ -371,8 +371,7 @@ def FeatureMOVRS : SubtargetFeature<"movrs", "HasMOVRS", "true",
"Enable MOVRS", []>;
// Ivy Bridge and newer processors have enhanced REP MOVSB and STOSB (aka
-// "string operations"). See "REP String Enhancement" in the Intel Software
-// Development Manual. This feature essentially means that REP MOVSB will copy
+// "string operations"). This feature essentially means that REP MOVSB will copy
// using the largest available size instead of copying bytes one by one, making
// it at least as fast as REPMOVS{W,D,Q}.
def FeatureERMSB
|
@@ -371,8 +371,7 @@ def FeatureMOVRS : SubtargetFeature<"movrs", "HasMOVRS", "true", | |||
"Enable MOVRS", []>; | |||
|
|||
// Ivy Bridge and newer processors have enhanced REP MOVSB and STOSB (aka | |||
// "string operations"). See "REP String Enhancement" in the Intel Software |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sections now appear to be called "Enhanced REP MOVSB and STOSB Operation" and "REP STRING OPERATIONS"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thanks for the find! I still feel it's better to remove it, but if others feel it's better to update it, I will update it
A part of the comment is out of date -- the Intel SDM doesn't have a chapter (nor any string) named that way. We could update it, but I believe it's better to simply remove it -- it's hard to maintain, and I feel it's unnecessary.