Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86] Remove outdated comment #133743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikolaj-pirog
Copy link
Contributor

A part of the comment is out of date -- the Intel SDM doesn't have a chapter (nor any string) named that way. We could update it, but I believe it's better to simply remove it -- it's hard to maintain, and I feel it's unnecessary.

@mikolaj-pirog
Copy link
Contributor Author

Pinging @phoebewang @e-kud for review

@llvmbot
Copy link
Member

llvmbot commented Mar 31, 2025

@llvm/pr-subscribers-backend-x86

Author: Mikołaj Piróg (mikolaj-pirog)

Changes

A part of the comment is out of date -- the Intel SDM doesn't have a chapter (nor any string) named that way. We could update it, but I believe it's better to simply remove it -- it's hard to maintain, and I feel it's unnecessary.


Full diff: https://github.com/llvm/llvm-project/pull/133743.diff

1 Files Affected:

  • (modified) llvm/lib/Target/X86/X86.td (+1-2)
diff --git a/llvm/lib/Target/X86/X86.td b/llvm/lib/Target/X86/X86.td
index 38761e1fd7eec..7421abf1968b9 100644
--- a/llvm/lib/Target/X86/X86.td
+++ b/llvm/lib/Target/X86/X86.td
@@ -371,8 +371,7 @@ def FeatureMOVRS   : SubtargetFeature<"movrs", "HasMOVRS", "true",
                            "Enable MOVRS", []>;
 
 // Ivy Bridge and newer processors have enhanced REP MOVSB and STOSB (aka
-// "string operations"). See "REP String Enhancement" in the Intel Software
-// Development Manual. This feature essentially means that REP MOVSB will copy
+// "string operations"). This feature essentially means that REP MOVSB will copy
 // using the largest available size instead of copying bytes one by one, making
 // it at least as fast as REPMOVS{W,D,Q}.
 def FeatureERMSB

@RKSimon RKSimon requested a review from phoebewang March 31, 2025 16:19
@@ -371,8 +371,7 @@ def FeatureMOVRS : SubtargetFeature<"movrs", "HasMOVRS", "true",
"Enable MOVRS", []>;

// Ivy Bridge and newer processors have enhanced REP MOVSB and STOSB (aka
// "string operations"). See "REP String Enhancement" in the Intel Software
Copy link
Collaborator

@RKSimon RKSimon Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sections now appear to be called "Enhanced REP MOVSB and STOSB Operation" and "REP STRING OPERATIONS"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for the find! I still feel it's better to remove it, but if others feel it's better to update it, I will update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants