[TableGen] Use size returned by encodeULEB128 to simplify some code. NFC #133750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use the length to insert all the bytes at once instead of partially decoding them to insert one byte at a time.
|
@llvm/pr-subscribers-tablegen Author: Craig Topper (topperc) ChangesWe can use the length to insert all the bytes at once instead of partially decoding them to insert one byte at a time. Full diff: https://github.com/llvm/llvm-project/pull/133750.diff 1 Files Affected:
diff --git a/llvm/utils/TableGen/DecoderEmitter.cpp b/llvm/utils/TableGen/DecoderEmitter.cpp
index cf7c02db8842e..ecf9c84f86a6d 100644
--- a/llvm/utils/TableGen/DecoderEmitter.cpp
+++ b/llvm/utils/TableGen/DecoderEmitter.cpp
@@ -1430,16 +1430,12 @@ void FilterChooser::emitSingletonTableEntry(DecoderTableInfo &TableInfo,
unsigned NumBits = Islands[I - 1].NumBits;
assert(isUInt<8>(NumBits) && "NumBits overflowed uint8 table entry!");
TableInfo.Table.push_back(MCD::OPC_CheckField);
- uint8_t Buffer[16], *P;
- encodeULEB128(Islands[I - 1].StartBit, Buffer);
- for (P = Buffer; *P >= 128; ++P)
- TableInfo.Table.push_back(*P);
- TableInfo.Table.push_back(*P);
+ uint8_t Buffer[16];
+ unsigned Len = encodeULEB128(Islands[I - 1].StartBit, Buffer);
+ TableInfo.Table.insert(TableInfo.Table.end(), Buffer, Buffer + Len);
TableInfo.Table.push_back(NumBits);
- encodeULEB128(Islands[I - 1].FieldVal, Buffer);
- for (P = Buffer; *P >= 128; ++P)
- TableInfo.Table.push_back(*P);
- TableInfo.Table.push_back(*P);
+ Len = encodeULEB128(Islands[I - 1].FieldVal, Buffer);
+ TableInfo.Table.insert(TableInfo.Table.end(), Buffer, Buffer + Len);
// Push location for NumToSkip backpatching.
TableInfo.FixupStack.back().push_back(TableInfo.Table.size());
// The fixup is always 24-bits, so go ahead and allocate the space
@@ -1469,11 +1465,9 @@ void FilterChooser::emitSingletonTableEntry(DecoderTableInfo &TableInfo,
TableInfo.Table.push_back(HasCompleteDecoder ? MCD::OPC_Decode
: MCD::OPC_TryDecode);
NumEncodingsSupported++;
- uint8_t Buffer[16], *p;
- encodeULEB128(Opc.Opcode, Buffer);
- for (p = Buffer; *p >= 128; ++p)
- TableInfo.Table.push_back(*p);
- TableInfo.Table.push_back(*p);
+ uint8_t Buffer[16];
+ unsigned Len = encodeULEB128(Opc.Opcode, Buffer);
+ TableInfo.Table.insert(TableInfo.Table.end(), Buffer, Buffer + Len);
SmallString<16> Bytes;
raw_svector_ostream S(Bytes);
|
|
Thanks @topperc, LGTM. |
nvjle
approved these changes
Mar 31, 2025
jurahul
approved these changes
Mar 31, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/13580 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use the length to insert all the bytes at once instead of partially decoding them to insert one byte at a time.