Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DirectX] Fix build break caused by bitcode writer changes #133770

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

farzonl
Copy link
Member

@farzonl farzonl commented Mar 31, 2025

commit: 6894734 added a new writeDIFixedPointType function.
However, DIFixedPointType is not supported in DXIL so we need to add a fail fast case for this to fix the build.

this change fixes a build break introduced by #129596

commit: llvm@6894734
added a new `writeDIFixedPointType` function. However DIFixedPointType
is not supported in DXIL so we need to add a fail fast case for this to
fix the build.

this change fixes a build break introduced by llvm#129596
@llvmbot
Copy link
Member

llvmbot commented Mar 31, 2025

@llvm/pr-subscribers-backend-directx

Author: Farzon Lotfi (farzonl)

Changes

commit: 6894734 added a new writeDIFixedPointType function.
However, DIFixedPointType is not supported in DXIL so we need to add a fail fast case for this to fix the build.

this change fixes a build break introduced by #129596


Full diff: https://github.com/llvm/llvm-project/pull/133770.diff

1 Files Affected:

  • (modified) llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp (+5)
diff --git a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
index ea33ee5759cb7..2a736c91c05c7 100644
--- a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
+++ b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
@@ -237,6 +237,11 @@ class DXILBitcodeWriter {
                          SmallVectorImpl<uint64_t> &Record, unsigned Abbrev);
   void writeDIBasicType(const DIBasicType *N, SmallVectorImpl<uint64_t> &Record,
                         unsigned Abbrev);
+  void writeDIFixedPointType(const DIFixedPointType *N,
+                             SmallVectorImpl<uint64_t> &Record,
+                             unsigned Abbrev) {
+    llvm_unreachable("DXIL cannot contain DIFixedPointType Nodes");
+  }
   void writeDIStringType(const DIStringType *N,
                          SmallVectorImpl<uint64_t> &Record, unsigned Abbrev) {
     llvm_unreachable("DXIL cannot contain DIStringType Nodes");

@farzonl farzonl merged commit c1bf5e6 into llvm:main Mar 31, 2025
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants