Skip to content

Remove PSTL from the monolithic builders #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

AaronBallman
Copy link
Contributor

This directory was removed in
llvm/llvm-project@f8ed456

Copy link
Contributor

@joker-eph joker-eph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkistanova can we get a buildbot restart ASAP? (I'm assuming this is needed for this change to take effect)

@AaronBallman AaronBallman merged commit 9e8c5a4 into llvm:main Jun 26, 2025
2 checks passed
@AaronBallman AaronBallman deleted the aballman-remove-pstl branch June 26, 2025 13:04
@gkistanova
Copy link
Contributor

No restart is needed in this case. You should be good with this change.
Anyway, the restart is coming tonight.

@AaronBallman
Copy link
Contributor Author

No restart is needed in this case. You should be good with this change. Anyway, the restart is coming tonight.

Thanks! For my own education, then why did landing the changes to remove PSTL from the CMake not actually address the issue?

I landed my changes long before @rnk landed his workaround in: https://lab.llvm.org/buildbot/#/builders/153/builds/36237 which is when the bot went back to green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants