Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to null safety #6

Closed
wants to merge 2 commits into from
Closed

migrate to null safety #6

wants to merge 2 commits into from

Conversation

britannio
Copy link

@britannio britannio commented Mar 15, 2021 •
edited
Loading

Closes #5

ryanheise
ryanheise reviewed May 5, 2021
View reviewed changes
lib/src/widgets/blob.dart
duration: widget.duration,
child: widget.child,
duration: widget.duration!,
child: widget.child!,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting null check assertions here. The child should not be required.

@ryanheise ryanheise mentioned this pull request May 5, 2021
Merged
@britannio
Copy link
Author

Closing in favour of #7

@britannio britannio closed this May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanheise ryanheise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MIgrate to null safety
2 participants
@britannio @ryanheise