Feature/validate #44
Feature/validate #44
Conversation
feat: GCP budget alert building block ci: adding changes to the validate process feat: GCP budget alert building block
feat: GCP budget alert building block ci: adding changes to the validate process feat: GCP budget alert building block chore: adding tf stuff to git ignore feat: GCP budget alert building block ci: adding changes to the validate process feat: GCP budget alert building block chore: adding tf stuff to git ignore chore: adding tf stuff to git ignore
ci: test script ci: test script ci: test script ci: test script ci: test script ci: test script ci: test script
florianow
force-pushed
the
feature/validate
branch
from
61a48e8 to
4ab1753
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
florianow
force-pushed
the
feature/validate
branch
from
ac52865 to
80d28b1
Compare
ci: adding everything to pre-commit ci: adding everything to pre-commit ci: adding everything to pre-commit
florianow
force-pushed
the
feature/validate
branch
2 times, most recently
from
d49d936 to
0bd5449
Compare
chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules
florianow
force-pushed
the
feature/validate
branch
from
0bd5449 to
dadec5d
Compare
florianow
force-pushed
the
feature/validate
branch
2 times, most recently
from
3129081 to
e5a5616
Compare
chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding "how to contribute" chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding "how to contribute" chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding "how to contribute" chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding "how to contribute" chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding "how to contribute" chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding "how to contribute" chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding "how to contribute" chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules chore: adding files to modules
florianow
force-pushed
the
feature/validate
branch
from
18cc89b to
9fa4177
Compare
|
|
||
| - uses: meshcloud/setup-collie@main | ||
| - name: Set up meshcloud collie CLI |
| #!/bin/bash | ||
| set -e | ||
|
|
||
| warnings=() |
There was a problem hiding this comment.
d: i appreciate that AI generated script, but can't we use sth builtin for tflint maybe?
(don't spend a ton of time reseaching this, the script is fine)
| if ! grep -q "supportedPlatforms:" "$readme_path"; then | ||
| errors+=("Missing 'supportedPlatforms' in README.md at $readme_path") | ||
|
|
||
| # 3. Extract YAML block |
There was a problem hiding this comment.
I#d rather appreciate we did a proper jq parsing of this thing? iirc there's also yq (jq but for yaml) that we could just get via nix?
There was a problem hiding this comment.
true, that exists :) I will use it
| check_readme_format "$readme_file" | ||
| done | ||
|
|
||
| for png_file in $(find $modules_glob -name '*.png'); do | ||
| # Check PNG files only directly inside each buildingblock | ||
| for png_file in $(find $modules_glob -maxdepth 1 -name '*.png'); do |
There was a problem hiding this comment.
you know what I'd also love to have: automatically optimizing the png files (meshStack needs them small) with sth like optipng and making sure they are as small as possible (lossless ofc)
| @@ -0,0 +1,7 @@ | |||
| provider "azurerm" { | |||
There was a problem hiding this comment.
tbh I'm probably against having empty default provider.tfs as that makes it very difficult to inject additional provider config via terragrunt? If I'm overriding the providers then I need to also user provider.tf as a name to make 100% sure I override the right one.
For BBs our standard pattern is "just use env vars supported by the providers for configuration" and that seems to be also the standard pattern for reusable terraform modules
we should 100% have versions.tf files
and for BBs maybe even lockfiles (for all architectures... which is a PITA)
No description provided.