Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microbit-foundation/codal-microbit-nrf5sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: microbit-foundation/codal-microbit-nrf5sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: clang-compatibility
Choose a head ref
  • 2 commits
  • 11 files changed
  • 1 contributor

Commits on Jun 28, 2023

  1. A SDK_mods compliant Clang compatibility patch. 

    These changes should remain non-breaking as the changed code should only be invoked when Clang is being used as the compiler. Changes documented below as git hasn't tracked them very well.

1. nrfsvc.py patch applied from https://github.com/eblot/nrf5-llvm.
2. error_handler.patch applied from https://github.com/eblot/nrf5-llvm.
3. replace "ldr.w r12, =%0"
with
" movw r12, %0 "
" movt r12, %1 "
as the pseudo instruction isn't understood by clang.
4. Finally copy these changes into the SDK_mods directory, and modify the CMakeList to instead use this changes when building with Clang.
    @Johnn333
    Johnn333 committed Jun 28, 2023
    Copy the full SHA
    200ff38 View commit details

Commits on Jul 19, 2023

  1. Document the modifications to the files placed in nRF5SDK_mods/clang/ 

    Where did the files come from, and where changes took place so diffs are easier
    @Johnn333
    Johnn333 committed Jul 19, 2023
    Copy the full SHA
    b33140a View commit details

This comparison is taking too long to generate.

Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.

You can try running this command locally to see the comparison on your machine:
git diff master...clang-compatibility