Skip to content

Upgrade to Vite 6 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade to Vite 6 #599

wants to merge 2 commits into from

Conversation

microbit-robert
Copy link

Upgrades vite, vitest and vite plugins.

Copy link

Preview build will be at
https://review-createai.microbit.org/vite-upgrade/

@@ -68,7 +67,6 @@
"@tensorflow/tfjs": "^4.20.0",
"@types/w3c-web-serial": "^1.0.6",
"@types/w3c-web-usb": "^1.0.6",
"@vitejs/plugin-react": "^4.3.1",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably just a dev dependency, and not needed twice.

@@ -50,10 +50,9 @@
"playwright": "^1.42.1",
"prettier": "2.8.8",
"typescript": "^5.4.2",
"vite": "^5.1.5",
"vite-plugin-pwa": "^0.19.8",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

@microbit-robert
Copy link
Author

  • Build looks good, bundle size looks the same
  • Routing works on review branch
  • ejs templating still works
  • hex files still download
  • vitest looks good
  • theme package looks good

@microbit-robert microbit-robert marked this pull request as ready for review June 13, 2025 15:37
@microbit-robert microbit-robert requested a review from a team June 13, 2025 15:37
Copy link

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vitest has switched to forks by default which uses
node:child_process. This is slightly slower than threads, but
more stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants