-
Notifications
You must be signed in to change notification settings - Fork 2
Add in-context translations #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Clicking "Edit in MakeCode" seem to cause an error when doing in-context translation. Needs investigating.
Seems to do with the Fixed (see comment below) |
573c693
to
8f3b9d7
Compare
src/components/ButtonWithLoading.tsx
Outdated
// Workaround to avoid error caused by DOM changes when doing in-context translations. | ||
export const ButtonWithLoading = ({ isLoading, ...props }: ButtonProps) => { | ||
return ( | ||
<Button | ||
{...props} | ||
isLoading={isLoading && !flags.translate} | ||
disabled={isLoading} | ||
/> | ||
); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very ideal. Suggestions on a better way of doing this welcome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh. No good suggestions unfortunately.
Task (Private)
Add translate flag for changing the language to lol and for adding jipt script.