Disassemble compiler package #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW I personally find this package structure "too flat"; I feel like there are bits which could still be nested further into |
jakebailey
force-pushed
the
jabaile/move-rest
branch
from
b4c4385 to
309e4db
Compare
|
Of course, things are racing due to the symbol ID stuff :| |
rbuckton
approved these changes
Jan 15, 2025
jakebailey
commented
Jan 24, 2025
| @@ -1,4 +1,4 @@ | |||
| package compiler | |||
| package program | |||
There was a problem hiding this comment.
Downside: we often use the name program as a variable name.
jakebailey
commented
Jan 24, 2025
| RootFiles: rootFiles, | ||
| Host: host, | ||
| Options: options, | ||
| DefaultLibraryPath: bundled.LibPath(), | ||
| } | ||
| program := compiler.NewProgram(programOptions) | ||
| program := program.NewProgram(programOptions) |
There was a problem hiding this comment.
Note that one can shadow here and that's "okay", but once you do this, you can't touch the package anymore in scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves packages around, renames
compilertoprogram.This PR is on top of #227