-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic jsdoc tag types #610
Merged
+13,471
−15,095
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
10c944c
First example of JS tag emitting types
sandersn d601063
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn 12dc74c
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn eac0860
couple of small bug fixes/refactors
sandersn fce99be
Add basic uses of type and return tags
sandersn 34666c3
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn b15e970
Basic param support
sandersn 551f4a4
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn b6e920b
Completely unfinished typedef, need to push to sync to laptop
sandersn 24efd00
finish adding @typedef
sandersn 6e1b734
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn d8d091f
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn 355a339
Remove JSTypeExpression wrapper, use Clone instead
sandersn 5184fda
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn 4d420bc
Various fixes+ features
sandersn 449315c
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn 20a6f6a
Add some tags, accept baselines
sandersn 85a68a1
Add Host pointer to JSDocTypeExpression,fix name resolution
sandersn a74d9a8
support variabledeclaration as well
sandersn c0056b3
undo stray merge change
sandersn 4d51c72
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn f13059f
cosmetic cleanup
sandersn 49fb006
undo bad typedef parsing simplification
sandersn f2852a8
remove unused JS checks in checker
sandersn e2c807e
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn 0fb08ce
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn d448d64
remove JSTypeAliasDeclaration type, keep kind
sandersn fc6199b
remove another jsdoc todo
sandersn 6146316
fix formatting
sandersn 00e3d76
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn 9225da2
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn f39861f
delete unused baselines
sandersn 8c3e3ea
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn bac9152
Merge branch 'add-basic-jsdoc-tag-types' of github.com:sandersn/types…
sandersn 13ec1c3
Improve locations of reparsed nodes
sandersn 8e71486
remove now-unneeded check in rangeOfTypeParameters
sandersn c7ae384
hereby format
sandersn 6ba9c18
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn 7af2df5
update tests after merge
sandersn 57badae
re-delete unused baselines
sandersn 807d725
skip baselining all reparsed nodes except `as`
sandersn 983f3b7
Merge branch 'main' into add-basic-jsdoc-tag-types
sandersn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike
type
,@typedef
is allowed as a local inside classes.I haven't checked to see how common this is so I added support for now as a way of fixing a nil panic. But I will remove it if it's not common.