CSHARP-5527: Support $sigmoid expression #1638
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanych-sun
requested changes
Mar 19, 2025
...ionExpressionTranslators/MethodTranslators/SigmoidMethodToAggregationExpressionTranslator.cs
Outdated
Show resolved
Hide resolved
tests/MongoDB.Driver.Tests/Linq/Linq3Implementation/Jira/CSharp5527Tests.cs
Outdated
Show resolved
Hide resolved
tests/MongoDB.Driver.Tests/Linq/Linq3Implementation/Jira/CSharp5527Tests.cs
Outdated
Show resolved
Hide resolved
rstam
requested changes
Mar 21, 2025
...ionExpressionTranslators/MethodTranslators/SigmoidMethodToAggregationExpressionTranslator.cs
Outdated
Show resolved
Hide resolved
...ionExpressionTranslators/MethodTranslators/SigmoidMethodToAggregationExpressionTranslator.cs
Outdated
Show resolved
Hide resolved
| /// </summary> | ||
| /// <param name="value">The input value.</param> | ||
| /// <returns>The transformed value.</returns> | ||
| public static double Sigmoid(double value) |
There was a problem hiding this comment.
While this is a perfectly reasonable place to declare this method we should discuss a bit whether going forward we want all new methods like this to live in the Mql class.
sanych-sun
approved these changes
Mar 25, 2025
| } | ||
|
|
||
| [Fact] | ||
| public void Sigmoid_should_work() |
There was a problem hiding this comment.
Minor: I would suggest test to check failure in case non-numeric representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.