Skip to content

Commit 91eeb98

Browse files
committedJul 18, 2019
s/preferFloat32/forceFloat32/
1 parent 4cf02b1 commit 91eeb98

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed
 

‎README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ extensionCodec | ExtensionCodec | `ExtensinCodec.defaultCodec`
114114
maxDepth | number | `100`
115115
initialBufferSize | number | `2048`
116116
sortKeys | boolean | false
117-
preferFloat32 | boolean | false
117+
forceFloat32 | boolean | false
118118

119119
### `decode(buffer: ArrayLike<number> | ArrayBuffer, options?: DecodeOptions): unknown`
120120

‎src/Encoder.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class Encoder {
1818
readonly maxDepth = DEFAULT_MAX_DEPTH,
1919
readonly initialBufferSize = DEFAULT_INITIAL_BUFFER_SIZE,
2020
readonly sortKeys = false,
21-
readonly preferFloat32 = false,
21+
readonly forceFloat32 = false,
2222
) {}
2323

2424
encode(object: unknown, depth: number): void {
@@ -120,7 +120,7 @@ export class Encoder {
120120
}
121121
} else {
122122
// non-integer numbers
123-
if (this.preferFloat32) {
123+
if (this.forceFloat32) {
124124
// float 32
125125
this.writeU8(0xca);
126126
this.writeF32(object);

‎src/encode.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ export type EncodeOptions = Partial<
99
sortKeys: boolean;
1010

1111
/**
12-
* If `true`, float32 is preferred in encoding non-integer numbers, insted of float64.
12+
* If `true`, non-integer numbers are encoded in float32, not in float64 (the default).
13+
*
14+
* Only use it if precisions don't matter.
1315
*/
14-
preferFloat32: boolean;
16+
forceFloat32: boolean;
1517
}>
1618
>;
1719

@@ -29,7 +31,7 @@ export function encode(value: unknown, options: EncodeOptions = defaultEncodeOpt
2931
options.maxDepth,
3032
options.initialBufferSize,
3133
options.sortKeys,
32-
options.preferFloat32,
34+
options.forceFloat32,
3335
);
3436
encoder.encode(value, 1);
3537
return encoder.getUint8Array();

‎test/encode.test.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,18 @@ describe("encode", () => {
88
});
99
});
1010

11-
context("preferFloat32", () => {
12-
it("encodes numbers in float64 wihout preferFloat32", () => {
11+
context("forceFloat32", () => {
12+
it("encodes numbers in float64 wihout forceFloat32", () => {
1313
assert.deepStrictEqual(encode(3.14), Uint8Array.from([0xcb, 0x40, 0x9, 0x1e, 0xb8, 0x51, 0xeb, 0x85, 0x1f]));
1414
});
1515

16-
it("encodes numbers in float32 when preferFloate32=true", () => {
17-
assert.deepStrictEqual(encode(3.14, { preferFloat32: true }), Uint8Array.from([0xca, 0x40, 0x48, 0xf5, 0xc3]));
16+
it("encodes numbers in float32 when forceFloate32=true", () => {
17+
assert.deepStrictEqual(encode(3.14, { forceFloat32: true }), Uint8Array.from([0xca, 0x40, 0x48, 0xf5, 0xc3]));
1818
});
1919

20-
it("encodes numbers in float64 with preferFloat32=false", () => {
20+
it("encodes numbers in float64 with forceFloat32=false", () => {
2121
assert.deepStrictEqual(
22-
encode(3.14, { preferFloat32: false }),
22+
encode(3.14, { forceFloat32: false }),
2323
Uint8Array.from([0xcb, 0x40, 0x9, 0x1e, 0xb8, 0x51, 0xeb, 0x85, 0x1f]),
2424
);
2525
});

0 commit comments

Comments
 (0)
Failed to load comments.