Update docs

Author: jeffgbutler

CHANGELOG.md

@@ -13,7 +13,11 @@ but fails to render because all the optional conditionals drop out of the where
 throw a `NonRenderingWhereClauseException`. We have made this change out of an abundance of caution. The prior
 behavior would allow generation of statements that inadvertently affected all rows in a table.
 
-Because of this change, we have also deprecated the "empty callback" functions in the "in" conditions.
+We have also deprecated the "empty callback" functions in the "in" conditions in favor of this new configuration
+strategy. The "empty callback" methods were effective for "in" conditions that failed to render, but they offered
+no help for other conditions that failed to render, or if all conditions fail to render - which is arguably a more
+dangerous outcome. If you were using any of these methods, you should remove the calls to those methods and catch the
+new `NonRenderingWhereClauseException`.
 
 If you desire the prior behavior where non rendering where clauses are allowed, you can change the global configuration
 of the library or - even better - change the configuration of individual statements where this behavior should be allowed.
@@ -32,8 +36,8 @@ For examples of global and statement configuration, see the "Configuration of th
    accurately represent the nullable/non-nullable expectations for API method calls.
    ([#496](https://github.com/mybatis/mybatis-dynamic-sql/pull/496))
 4. Added the ability to configure the library and change some default behaviors. Currently, this is limited to changing
-   the behavior of the library in regard to where clauses that will not render. See the new configuration page for
-   details.
+   the behavior of the library in regard to where clauses that will not render. See the "Configuration of the Library"
+   page for details.
 
 ## Release 1.4.0 - March 3, 2022
 

src/site/markdown/docs/configuration.md

@@ -1,8 +1,7 @@
 # Configuration of the Library
 
-Most behaviors of MyBatis Dynamic SQL are not configurable - the library does what it does.
-This page will detail the behaviors that can be modified. Configuration is available with version 1.4.1 and later
-of the library.
+This page will detail the behaviors of MyBatis Dynamic SQL that can be modified.
+Configuration is available with version 1.4.1 and later of the library.
 
 The library can be configured globally - which will change the behavior for all statements - or each individual statement
 can be configured. There are sensible defaults for all configuration values, so configuration is not strictly necessary.
@@ -12,12 +11,11 @@ Prior to version 1.4.1 of the library, there was no configurable behavior in the
 the default behavior of the library to throw an exception if a where clause fails to render. We did this out of an
 abundance of caution because the optional conditions in a where clause could lead to a statement that affected all
 rows in a table (for example, a delete statement could inadvertently delete all rows in a table). If you want the library
-to function as it did before version 1.4.1 where it was acceptable to have a where clause that didn't render, then you
-can change the global configuration as shown below.
+to function as it did before version 1.4.1 , then you can change the global configuration as shown below.
 
 ## Global Configuration
 
-On first use the library will initialize the global configuration. The global configuration can be changed via a property
+On first use the library will initialize the global configuration. The global configuration can be specified via a property
 file named `mybatis-dynamic-sql.properties` in the root of the classpath. If you wish to use a different file name,
 you can specify the file name as a JVM property named `mybatis-dynamic-sql.configurationFile`. Note that the global
 configuration is created one time and shared for every statement in the same JVM.
@@ -26,9 +24,9 @@ The configuration file is a standard Java properties file. The possible values a
 
 ## Global Configuration Properties
 
-| Property                       | Default | Meaning                                                                                                                                                                                                                                                                                              |
-|--------------------------------|---------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| nonRenderingWhereClauseAllowed | false   | If a where clause is specified, but fails to render, then the library will throw a `NonRenderingWhereClauseException` by default. If you set this value to true, then no exception will be thrown. This could cause statements to be rendered without where clauses that affect all rows in a table. |
+| Property                       | Default | Meaning                                                                                                                                                                                                                                                                                               |
+|--------------------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| nonRenderingWhereClauseAllowed | false   | If a where clause is specified, but fails to render, then the library will throw a `NonRenderingWhereClauseException` by default. If you set this value to true, then no exception will be thrown. This could enable statements to be rendered without where clauses that affect all rows in a table. |
 
 ## Statement Configuration
 
@@ -37,13 +35,13 @@ DSL. Consider the following statement:
 
 ```java
 DeleteStatementProvider deleteStatement = deleteFrom(animalData)
-    .where(id, isNotIn(null, 22, null).filter(Objects::nonNull).filter(i -> i != 22))
+    .where(id, isIn(null, 22, null).filter(Objects::nonNull).filter(i -> i != 22))
     .configureStatement(c -> c.setNonRenderingWhereClauseAllowed(true))
     .build()
     .render(RenderingStrategies.MYBATIS3);
 ```
 
-In this case, the `isNotIn` condition has filters that will remove all values from the condition. In that case, the
+In this case, the `isIn` condition has filters that will remove all values from the condition. In that case, the
 condition will not render and, subsequently, the where clause will not render. This means that the generated delete
 statement would delete all rows in the table. By default, the global configuration will block this statement from
 rendering and throw a `NonRenderingWhereClauseException`. If for some reason you would like to allow a statement
@@ -53,7 +51,7 @@ The Kotlin DSL contains the same function:
 
 ```kotlin
 val deleteStatement = deleteFrom(person) {
-    where { id isNotEqualToWhenPresent null }
+    where { id isEqualToWhenPresent null }
     configureStatement { isNonRenderingWhereClauseAllowed = true } 
 }
 ```