Bug#37471922: Auto-fix clang-tidy warnings [31/n] [noclose]

Generate fixes for a number of warnings that clang-tidy can fix automatically.
This commit fixes the warning 'performance-faster-string-find'.

Change example:
 - std::size_t slash = full.rfind("/");
 + std::size_t slash = full.rfind('/');

Change-Id: I312891503a379c1e7c0f665102bfb0624912ff9d

Author: MRajcic

libmysql/authentication_kerberos/gssapi_authentication_client.cc

@@ -143,7 +143,7 @@ std::string Gssapi_client::get_user_name() {
   if (m_kerberos->get_upn(&cached_user_name)) {
     size_t pos = std::string::npos;
     /* Remove realm */
-    if ((pos = cached_user_name.find("@")) != std::string::npos) {
+    if ((pos = cached_user_name.find('@')) != std::string::npos) {
       log_client_dbg("Trimming realm from upn.");
       cached_user_name.erase(pos, cached_user_name.length() - pos + 1);
     }

libmysql/authentication_ldap/auth_ldap_kerberos.cc

@@ -336,7 +336,7 @@ bool Kerberos::get_kerberos_config() {
 
   /* IPV6 */
   if (m_ldap_server_host[0] == '[') {
-    auto pos = m_ldap_server_host.find("]");
+    auto pos = m_ldap_server_host.find(']');
     if (pos != m_ldap_server_host.npos &&
         (m_ldap_server_host.length() > (pos + 1)) &&
         (m_ldap_server_host[pos + 1] == ':')) {
@@ -345,7 +345,7 @@ bool Kerberos::get_kerberos_config() {
   }
   /* IPV4 */
   else {
-    auto pos = m_ldap_server_host.find(":");
+    auto pos = m_ldap_server_host.find(':');
     if (pos != m_ldap_server_host.npos) {
       m_ldap_server_host.erase(pos);
     }

mysys/my_default.cc

@@ -1497,7 +1497,7 @@ void update_variable_source(const char *opt_name, const char *value) {
   /* opt_name must be of form --XXXXX which means min length must be 3 */
   if (var_name.length() < 3) return;
 
-  std::size_t pos = var_name.find("=");
+  std::size_t pos = var_name.find('=');
   /* strip the value part if present */
   if (pos != string::npos) var_name = var_name.substr(0, pos);
 
@@ -1508,7 +1508,7 @@ void update_variable_source(const char *opt_name, const char *value) {
   var_name = var_name.substr(2);
 
   /* replace all '-' to '_' */
-  while ((pos = var_name.find("-")) != string::npos)
+  while ((pos = var_name.find('-')) != string::npos)
     var_name.replace(pos, 1, "_");
 
   /*
@@ -1575,7 +1575,7 @@ void set_variable_source(const char *opt_name, void *value) {
   std::size_t pos;
 
   /* replace all '-' to '_' */
-  while ((pos = src_name.find("-")) != string::npos)
+  while ((pos = src_name.find('-')) != string::npos)
     src_name.replace(pos, 1, "_");
 
   auto it = variables_hash.find(src_name);

plugin/clone/src/clone_plugin.cc

@@ -188,13 +188,13 @@ static bool scan_donor_list(const std::string &donor_list,
 
   try {
     /* Don't allow space in donor list. */
-    auto space_pos = donor_list.find(" ");
+    auto space_pos = donor_list.find(' ');
     if (space_pos != std::string::npos) {
       return (false);
     }
     /* Scan through all entries. */
     while (comma_pos != std::string::npos) {
-      comma_pos = donor_list.find(",", begin_pos);
+      comma_pos = donor_list.find(',', begin_pos);
       auto entry_len = comma_pos;
 
       if (entry_len != std::string::npos) {
@@ -206,7 +206,7 @@ static bool scan_donor_list(const std::string &donor_list,
       }
 
       const std::string entry = donor_list.substr(begin_pos, entry_len);
-      auto colon_pos = entry.find(":");
+      auto colon_pos = entry.find(':');
 
       /* Bad entry if no separator is found or found in beginning. */
       if (colon_pos == std::string::npos || colon_pos == 0) {

plugin/group_replication/libmysqlgcs/src/interface/gcs_logging.cc

@@ -175,7 +175,7 @@ bool Gcs_debug_options::get_debug_options(const std::string &debug_options,
       return true;
   }
 
-  if (!match && (debug_options.find(",") != std::string::npos)) return true;
+  if (!match && (debug_options.find(',') != std::string::npos)) return true;
 
   return false;
 }

storage/ndb/ndbapi-examples/ndbapi_array_simple/ndbapi_array_simple.cpp

@@ -125,7 +125,7 @@ static int get_string(const NdbRecAttr *attr, string &str) {
     str = string(data_start_ptr, attr_bytes);
     if (attr->getType() == NdbDictionary::Column::Char) {
       /* Fixed Char : remove blank spaces at the end */
-      size_t endpos = str.find_last_not_of(" ");
+      size_t endpos = str.find_last_not_of(' ');
       if (string::npos != endpos) {
         str = str.substr(0, endpos + 1);
       }

storage/ndb/tools/ndb_import.cpp

@@ -380,7 +380,7 @@ static int checkarg(TableArg &arg, const char *str) {
     std::string full = str;  // foo/t1.bar.csv
     convertpath(full);
     std::string base = full;  // t1.bar.csv
-    std::size_t slash = full.rfind("/");
+    std::size_t slash = full.rfind('/');
     if (slash != std::string::npos) {
       base = full.substr(slash + 1);
     }
@@ -392,13 +392,13 @@ static int checkarg(TableArg &arg, const char *str) {
     }
     CHK1(ret == 0);
     std::string stem = base;  // t1.bar
-    std::size_t rdot = base.rfind(".");
+    std::size_t rdot = base.rfind('.');
     if (rdot != std::string::npos) {
       stem = base.substr(0, rdot);
     }
     if (g_opt.m_table == nullptr) {
       std::string table = stem;  // t1
-      std::size_t ldot = stem.find(".");
+      std::size_t ldot = stem.find('.');
       if (ldot != std::string::npos) {
         table = stem.substr(0, ldot);
       }