WL#10956 Binlog Access API - Step3 Relaylog Applier Reader

This patch replaced the last Log_event::read_log_event() call to
Relaylog_file_reader which was introduced in Step2 patch. So
Log_event::read_log_event() was finally removed from the code.

It also did some refacotring
- It created Rpl_applier_reader class which is responsible for reading
  events from relaylog files.
- The code of next_event was moved into Rpl_applier_reader class and
  separated into a few functions.
- The applier reader is only need when applier is online. It is used
  as a local variable of handle_slave_sql().
- change_master and purge_relay_logs don't need to reopen or reinitialize
  the applier read anymore. So rli::init_relay_log_pos is reorganized as
  group_relay_log_is_valid() to verify group_relay_log_name existing.
- rli::event_relay_log_pos and rli::event_relay_log_name are only used
  when applying events. So they just need to be intilaized in Rpl_applier_reader
  class.
- Moved the code period checking out mts_checkpoint_routine. It was
  encapsulated into a new function called rli::is_time_for_mts_checkpoint

Author: Libing Song

client/mysqlbinlog.cc

@@ -1964,8 +1964,7 @@ static Exit_status dump_multiple_logs(int argc, char **argv) {
   When reading a remote binlog, this function is used to grab the
   Format_description_log_event in the beginning of the stream.
 
-  This is not as smart as check_header() (used for local log); it will
-  not work for a binlog which mixes format. TODO: fix this.
+  It will not work for a binlog which mixes format. TODO: fix this.
 
   @retval ERROR_STOP An error occurred - the program should terminate.
   @retval OK_CONTINUE No error, the program should continue.
@@ -2399,11 +2398,13 @@ class Stdin_binlog_istream : public Basic_seekable_istream,
     return false;
   }
 
+  /* purecov: begin inspected */
   /** Stdin has no length. It should never be called. */
   my_off_t length() override {
     DBUG_ASSERT(0);
     return 0;
   };
+  /* purecov: end */
 
  private:
   /**

mysql-test/suite/binlog/r/binlog_reader_coverage.result

@@ -0,0 +1,20 @@
+call mtr.add_suppression("Binary logging not possible");
+call mtr.add_suppression("Attempting backtrace");
+RESET MASTER;
+CREATE TABLE t1(c1 INT);
+SET debug = "+d,simulate_init_io_cache_failure";
+SHOW BINLOG EVENTS;
+ERROR HY000: Error when executing command SHOW BINLOG EVENTS: Could not open log file
+SET debug = "-d,simulate_init_io_cache_failure";
+SET debug = "+d,simulate_allocate_failure";
+SHOW BINLOG EVENTS;
+ERROR HY000: Error when executing command SHOW BINLOG EVENTS: memory allocation failed reading log event
+SET debug = "-d,simulate_allocate_failure";
+SET debug = "+d,simulate_seek_failure";
+SHOW BINLOG EVENTS FROM 337;
+ERROR HY000: Error when executing command SHOW BINLOG EVENTS: I/O error reading log event
+SET debug = "-d,simulate_seek_failure";
+SET debug = "+d,simulate_ostream_write_failure";
+INSERT INTO t1 VALUES(1);
+ERROR HY000: Binary logging not possible. Message: An error occurred during flush stage of the commit. 'binlog_error_action' is set to 'ABORT_SERVER'. Hence aborting the server.
+DROP TABLE t1;

mysql-test/suite/binlog/t/binlog_reader_coverage.test

@@ -0,0 +1,48 @@
+# Coverage Tests for WL#10956
+--source include/not_valgrind.inc
+--source include/have_debug.inc
+--source include/have_binlog_format_row.inc
+call mtr.add_suppression("Binary logging not possible");
+call mtr.add_suppression("Attempting backtrace");
+RESET MASTER;
+
+CREATE TABLE t1(c1 INT);
+--let $start_pos = query_get_value(SHOW MASTER STATUS, Position, 1)
+
+SET debug = "+d,simulate_init_io_cache_failure";
+--error ER_ERROR_WHEN_EXECUTING_COMMAND
+SHOW BINLOG EVENTS;
+SET debug = "-d,simulate_init_io_cache_failure";
+
+SET debug = "+d,simulate_allocate_failure";
+--error ER_ERROR_WHEN_EXECUTING_COMMAND
+SHOW BINLOG EVENTS;
+SET debug = "-d,simulate_allocate_failure";
+
+SET debug = "+d,simulate_seek_failure";
+--error ER_ERROR_WHEN_EXECUTING_COMMAND
+eval SHOW BINLOG EVENTS FROM $start_pos;
+SET debug = "-d,simulate_seek_failure";
+
+--exec echo "wait" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
+SET debug = "+d,simulate_ostream_write_failure";
+--error ER_BINLOG_LOGGING_IMPOSSIBLE
+INSERT INTO t1 VALUES(1);
+
+--exec echo "restart" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
+--enable_reconnect
+--source include/wait_until_connected_again.inc
+
+--error 1
+--exec $MYSQL_BINLOG file_not_exist >/dev/null
+
+--error 1,12
+--exec $MYSQL_BINLOG -#d,simulate_init_io_cache_failure - > /dev/null 2>&1
+
+--error 1,12
+--exec $MYSQL_BINLOG -#d,simulate_init_io_cache_failure binlog.000001 > /dev/null  2>&1
+
+--error 1,12
+--exec $MYSQL_BINLOG --start-position=100000000 binlog.000001 > /dev/null 2>&1
+DROP TABLE t1;
+

mysql-test/suite/ndb_rpl/r/ndb_rpl_checksum.result

@@ -77,7 +77,7 @@ include/start_slave.inc
 set @@global.master_verify_checksum = 1;
 set @@session.debug='d,simulate_checksum_test_failure';
 show binlog events;
-ERROR HY000: Error when executing command SHOW BINLOG EVENTS: Wrong offset or I/O error
+ERROR HY000: Error when executing command SHOW BINLOG EVENTS: event read from binlog did not pass crc check
 set @@session.debug='';
 set @@global.master_verify_checksum = default;
 include/stop_slave.inc
@@ -92,7 +92,7 @@ set @@global.slave_sql_verify_checksum = 1;
 set @@global.debug='d,simulate_checksum_test_failure';
 start slave sql_thread;
 include/wait_for_slave_sql_error.inc [errno=13117]
-Last_SQL_Error = 'Error initializing relay log position: I/O error reading event at position 4'
+Last_SQL_Error = 'Error initializing relay log position: event read from binlog did not pass crc check'
 include/stop_slave.inc
 set @@global.debug='';
 include/start_slave.inc

mysql-test/suite/rpl/r/rpl_multi_source_channel_map_stress.result

@@ -7,6 +7,7 @@ Note	####	Storing MySQL user name or password information in the master info rep
 CALL mtr.add_suppression('Slave failed to initialize master info structure from the repository');
 CALL mtr.add_suppression('This operation cannot be performed with a running slave');
 CALL mtr.add_suppression('Could not find target log file mentioned in relay log info in the index file');
+CALL mtr.add_suppression('Could not find relay log file');
 CALL mtr.add_suppression('A slave with the same server_uuid/server_id as this slave has connected to the master');
 SET @saved_event_scheduler= @@GLOBAL.event_scheduler;
 SET @saved_relay_log_purge= @@GLOBAL.relay_log_purge;

mysql-test/suite/rpl/r/rpl_reset_slave_fail.result

@@ -22,6 +22,8 @@ call mtr.add_suppression("Could not find target log file mentioned in relay log
 call mtr.add_suppression("Failed to initialize the relay-log-info structure");
 call mtr.add_suppression("Failed to initialize the master info structure");
 call mtr.add_suppression("Failed to create or recover replication info repositories");
+call mtr.add_suppression("listed in the index, but failed to stat");
+call mtr.add_suppression("Error counting relay log space");
 include/rpl_stop_server.inc [server_number=2]
 # Removing  file(s)
 include/rpl_start_server.inc [server_number=2]

mysql-test/suite/rpl/t/rpl_multi_source_channel_map_stress.test

@@ -26,6 +26,13 @@
 CALL mtr.add_suppression('Slave failed to initialize master info structure from the repository');
 CALL mtr.add_suppression('This operation cannot be performed with a running slave');
 CALL mtr.add_suppression('Could not find target log file mentioned in relay log info in the index file');
+# For case:
+# STOP SLAVE SQL_THREAD; // IO_THREAD is running
+# CHANGE MASTER TO relay_log_name = 'non-existing relay log name',...;
+# While CHANGE MASTER throwns an error, group_relay_log_name is changed to the
+# non-existing file name.
+# START SLAVE SQL_THREAD; // It will log below error.
+CALL mtr.add_suppression('Could not find relay log file');
 CALL mtr.add_suppression('A slave with the same server_uuid/server_id as this slave has connected to the master');
 
 # Save current event scheduler status

mysql-test/suite/rpl/t/rpl_multi_source_slave_files.cnf

@@ -12,7 +12,6 @@ relay-log-purge=0
 relay-log-recovery=1
 sync_relay_log=10
 max-relay-log-size=1073741824
-relay-log-space-limit=1073741824
 relay-log=relaylog-msr
 relay-log-index=relaylog-msr.index
 sync-master-info=10

mysql-test/suite/rpl/t/rpl_reset_slave_fail.test

@@ -41,6 +41,8 @@ call mtr.add_suppression("Could not find target log file mentioned in relay log
 call mtr.add_suppression("Failed to initialize the relay-log-info structure");
 call mtr.add_suppression("Failed to initialize the master info structure");
 call mtr.add_suppression("Failed to create or recover replication info repositories");
+call mtr.add_suppression("listed in the index, but failed to stat");
+call mtr.add_suppression("Error counting relay log space");
 
 # Stop slave
 --let $rpl_server_number= 2

mysql-test/suite/rpl_nogtid/r/rpl_checksum.result

@@ -92,7 +92,7 @@ set @@global.slave_sql_verify_checksum = 1;
 set @@global.debug='d,simulate_checksum_test_failure';
 start slave sql_thread;
 include/wait_for_slave_sql_error.inc [errno=13117]
-Last_SQL_Error = 'Error initializing relay log position: I/O error reading event at position 4'
+Last_SQL_Error = 'Event crc check failed! Most likely there is event corruption.'
 include/stop_slave.inc
 set @@global.debug='';
 include/start_slave.inc