Bug #28971954 MOVE GCS_XCOM_CONTROL_INTERFACE-T.CC TO THE UNIT TESTS DIRECTORY

Problem and analysis
========================================================================
The gcs_xcom_control_interface-t.cc test file is in the smoke tests'
directory but it should be in the unit tests'.
The file's tests take around ~300 seconds, which is too much.
The reason is that we wait for the suspicions processing thread to wake
up on its own, and terminate, when we we leave the group.

Solution
========================================================================
Proactively wake up the suspicions processing thread when we leave the
group, instead of waiting for the thread to wake up on its own. This
cuts down the duration of several tests substantially.

Move the gcs_xcom_control_interface-t.cc file to the unit tests'
directory and merge it with the recently created
gcs_xcom_control_interface_unit-t.cc.

Suppress a message about misconfigured local_address on
gr_autorejoin_stop_gr. This message is expected because the test
misconfigures local_address to trigger the rejoin procedure.
The hypothesis is that the message did not appear before due to the
artificial delay in the leave operation. (Waiting for the suspicions
processing thread to wake up.)

Suppress a message about view change timeout on gr_recovery_no_donors.
This message appears because there is a circular dependency between the
delivery of view change notifications and an ongoing recovery procedure.
Specifically, the view change notifications are only sent after the
recovery procedure terminates, but the recovery procedure only
terminates after receiving the view change notification: both wait for
each other until they time out.
The message did not appear before due to the artificial delay in the
leave operation. (Waiting for the suspicions processing thread to wake
up.) The recovery procedure would finish before the view change, whereas
now the view change is delivered while the recovery procedur is ongoing.
A bug report was opened to deal with this situation, whose patch should
remove the suppressions.

Reviewed-by: Andre Negrao <andre.negrao@oracle.com>
Reviewed-by: Tiago Jorge <tiago.jorge@oracle.com>
RB: 21373

Author: tvale

mysql-test/suite/group_replication/t/gr_autorejoin_stop_gr.test

@@ -42,6 +42,10 @@ call mtr.add_suppression("\\[GCS\\] The member has left the group but the new vi
 call mtr.add_suppression("\\[GCS\\] read failed");
 call mtr.add_suppression("Started auto-rejoin procedure attempt*");
 call mtr.add_suppression("Auto-rejoin procedure attempt*");
+--disable_query_log # No need for the result file to specify suppressions.
+call mtr.add_suppression("\\[GCS\\] There is no local IP address matching the one configured for the local node .*");
+call mtr.add_suppression("Unable to initialize the group communication engine");
+--enable_query_log
 SET sql_log_bin = 1;
 
 --source include/gr_autorejoin_monitoring.inc

mysql-test/suite/group_replication/t/gr_recovery_no_donors.test

@@ -40,6 +40,9 @@ call mtr.add_suppression("Skipping leave operation: concurrent attempt to leave
 call mtr.add_suppression("Maximum number of retries when trying to connect to a donor reached. Aborting group replication recovery.");
 call mtr.add_suppression("Transaction cannot be executed while Group Replication is stopping.");
 call mtr.add_suppression("Run function 'before_commit' in plugin 'group_replication' failed");
+--disable_query_log # No need for the result file to specify suppressions.
+call mtr.add_suppression("While leaving the group due to a stop, shutdown or failure there was a timeout receiving a view change. This can lead to a possible inconsistent state. Check the log for more details");
+--enable_query_log
 SET SESSION sql_log_bin= 1;
 
 CREATE TABLE t1 (a INT PRIMARY KEY AUTO_INCREMENT NOT NULL);
@@ -97,6 +100,9 @@ call mtr.add_suppression("All donors left. Aborting group replication recovery."
 call mtr.add_suppression("The member is already leaving or joining a group.");
 call mtr.add_suppression("Skipping leave operation: member already left the group.");
 call mtr.add_suppression("Skipping leave operation: concurrent attempt to leave the group is on-going.");
+--disable_query_log # No need for the result file to specify suppressions.
+call mtr.add_suppression("While leaving the group due to a stop, shutdown or failure there was a timeout receiving a view change. This can lead to a possible inconsistent state. Check the log for more details");
+--enable_query_log
 SET SESSION sql_log_bin= 1;
 
 

plugin/group_replication/libmysqlgcs/src/bindings/xcom/gcs_xcom_control_interface.cc

@@ -686,7 +686,7 @@ enum_gcs_error Gcs_xcom_control::do_leave() {
 
   assert(m_xcom_proxy->xcom_is_exit());
 
-  set_terminate_suspicion_thread(true);
+  m_suspicions_manager->wake_suspicions_processing_thread(true);
 
   m_suspicions_processing_thread.join(NULL);
   MYSQL_GCS_LOG_TRACE("The suspicions processing thread has joined.");

unittest/gunit/libmysqlgcs/CMakeLists.txt

@@ -86,6 +86,7 @@ SET(GCS_XCOM_TESTS
     xcom/gcs_xcom_xcom_transport
     xcom/gcs_xcom_communication_protocol_changer
     xcom/gcs_xcom_xcom_cache
+    xcom/gcs_xcom_control_interface
    )
 
 ###