Bug#37471922: Auto-fix clang-tidy warnings [17/n] [noclose]

Generate fixes for a number of warnings that clang-tidy can fix automatically.
This commit fixes the warning 'readability-simplify-boolean-expr'.

Change example:
 - if (check_length(size) == true) {
 + if (check_length(size)) {

Change-Id: If3c334e3b040a69ddb756113eda17f261ed8c8f3

Author: MRajcic

client/mysql_config_editor.cc

@@ -592,7 +592,7 @@ static int remove_command(void) {
 
   /* Warn if no login path is specified. */
   if (opt_warn && ((locate_login_path(&file_buf, opt_login_path)) != nullptr) &&
-      (login_path_specified == false)) {
+      (!login_path_specified)) {
     int choice;
     printf(
         "WARNING : No login path specified, so options from the default "

client/mysql_secure_installation.cc

@@ -202,7 +202,7 @@ static int get_response(const char *opt_message, int default_answer = -1) {
   int i = 0;
   if (opt_message) {
     fprintf(stdout, "%s", opt_message);
-    if (opt_use_default == true && default_answer != -1) {
+    if (opt_use_default && default_answer != -1) {
       fprintf(stdout, " %c \n", (char)default_answer);
       return default_answer;
     }
@@ -462,9 +462,7 @@ static bool mysql_set_password(MYSQL *mysql, char *password) {
 static bool mysql_expire_password(MYSQL *mysql) {
   char sql[] = "UPDATE mysql.user SET password_expired= 'Y'";
   const size_t sql_len = strlen(sql);
-  if (mysql_real_query(mysql, sql, (ulong)sql_len)) return false;
-
-  return true;
+  return mysql_real_query(mysql, sql, (ulong)sql_len) == 0;
 }
 
 /**
@@ -818,7 +816,7 @@ int main(int argc, char *argv[]) {
   if (!hadpass) {
     fprintf(stdout, "Please set the password for %s here.\n", opt_user);
     set_opt_user_password(component_set);
-  } else if (opt_use_default == false) {
+  } else if (!opt_use_default) {
     char prompt[256];
     fprintf(stdout, "Using existing password for %s.\n", opt_user);
 
@@ -852,8 +850,8 @@ int main(int argc, char *argv[]) {
     to be marked for expiration upon exit so the DBA will remember to set a new
     one.
   */
-  if (g_expire_password_on_exit == true) {
-    if (mysql_expire_password(&mysql_handle) == false) {
+  if (g_expire_password_on_exit) {
+    if (!mysql_expire_password(&mysql_handle)) {
       fprintf(stdout,
               "... Failed to expire password!\n"
               "** Please consult the MySQL server documentation. **\n"

client/mysqladmin.cc

@@ -468,7 +468,7 @@ int main(int argc, char *argv[]) {
                   (char *)&opt_enable_cleartext_plugin);
 
   first_command = find_type(argv[0], &command_typelib, FIND_TYPE_BASIC);
-  can_handle_passwords = first_command == ADMIN_PASSWORD ? true : false;
+  can_handle_passwords = first_command == ADMIN_PASSWORD;
   mysql_options(&mysql, MYSQL_OPT_CAN_HANDLE_EXPIRED_PASSWORDS,
                 &can_handle_passwords);
 

client/mysqldump.cc

@@ -5308,10 +5308,10 @@ static int dump_selected_tables(char *db, char **table_names, int tables) {
 
   /* Can't LOCK TABLES in I_S / P_S, so don't try. */
   if (lock_tables &&
-      !(mysql_get_server_version(mysql) >= FIRST_INFORMATION_SCHEMA_VERSION &&
-        !my_strcasecmp(&my_charset_latin1, db, INFORMATION_SCHEMA_DB_NAME)) &&
-      !(mysql_get_server_version(mysql) >= FIRST_PERFORMANCE_SCHEMA_VERSION &&
-        !my_strcasecmp(&my_charset_latin1, db, PERFORMANCE_SCHEMA_DB_NAME))) {
+      (mysql_get_server_version(mysql) < FIRST_INFORMATION_SCHEMA_VERSION ||
+       my_strcasecmp(&my_charset_latin1, db, INFORMATION_SCHEMA_DB_NAME)) &&
+      (mysql_get_server_version(mysql) < FIRST_PERFORMANCE_SCHEMA_VERSION ||
+       my_strcasecmp(&my_charset_latin1, db, PERFORMANCE_SCHEMA_DB_NAME))) {
     if (mysql_real_query(mysql, lock_tables_query.str,
                          (ulong)(lock_tables_query.length - 1))) {
       if (!opt_force) {
@@ -5962,7 +5962,7 @@ static bool get_gtid_mode(MYSQL *mysql_con) {
      get the gtid_mode value from the second column.
   */
   gtid_mode_val = gtid_mode_row ? (char *)gtid_mode_row[1] : nullptr;
-  gtid_mode = (gtid_mode_val && strcmp(gtid_mode_val, "OFF")) ? true : false;
+  gtid_mode = gtid_mode_val && strcmp(gtid_mode_val, "OFF");
   mysql_free_result(gtid_mode_res);
 
   return gtid_mode;

client/mysqlslap.cc

@@ -1164,8 +1164,7 @@ static int get_options(int *argc, char ***argv) {
     that we actually added a key!
   */
   if (auto_generate_sql && auto_generate_sql_type[0] == 'k')
-    if (auto_generate_sql_autoincrement == false &&
-        auto_generate_sql_guid_primary == false) {
+    if (!auto_generate_sql_autoincrement && !auto_generate_sql_guid_primary) {
       fprintf(stderr, "%s: Can't perform key test without a primary key!\n",
               my_progname);
       exit(1);

client/mysqltest.cc

@@ -816,10 +816,7 @@ static bool async_mysql_read_query_result_wrapper(MYSQL *mysql) {
     const int result = socket_event_listen(mysql_get_socket_descriptor(mysql));
     if (result == -1) return true;
   }
-  if (status == NET_ASYNC_ERROR) {
-    return true;
-  }
-  return false;
+  return status == NET_ASYNC_ERROR;
 }
 
 static int async_mysql_next_result_wrapper(MYSQL *mysql) {
@@ -2478,7 +2475,7 @@ void var_set(const char *var_name, const char *var_name_end,
     var_name++;
 
   digit = *var_name - '0';
-  if (!(digit < 10 && digit >= 0)) {
+  if (digit >= 10 || digit < 0) {
     v = var_obtain(var_name, (uint)(var_name_end - var_name));
   } else
     v = var_reg + digit;
@@ -7188,7 +7185,7 @@ static void do_block(enum block_cmd cmd, struct st_command *command) {
 
       case NE_OP:
         if (v.is_int)
-          v.int_val = !(v2.is_int && v2.int_val == v.int_val);
+          v.int_val = !v2.is_int || v2.int_val != v.int_val;
         else
           v.int_val = (std::strcmp(v.str_val, v2.str_val) != 0);
         break;

client/path.cc

@@ -116,10 +116,7 @@ bool Path::qpath(const std::string &qp) {
     filename(qp.substr(idx + 1, qp.size() - idx));
     path(qp.substr(0, idx));
   }
-  if (is_qualified_path())
-    return true;
-  else
-    return false;
+  return is_qualified_path();
 }
 
 bool Path::normalize_path() {

components/audit_api_message_emit/audit_api_message_emit.cc

@@ -265,7 +265,7 @@ static int arg_check(IError_handler &handler, unsigned int arg_count,
   /*
     At least one argument count was matched against definition.
   */
-  if (result == false) {
+  if (!result) {
     handler.error("Invalid argument count.");
     return -1;
   }
@@ -287,7 +287,7 @@ static int arg_check(IError_handler &handler, unsigned int arg_count,
         result = true;
     }
 
-    if (result == false) {
+    if (!result) {
       handler.error("Invalid argument type [%d].", i);
       return -1;
     }
@@ -301,7 +301,7 @@ static int arg_check(IError_handler &handler, unsigned int arg_count,
                                    handler, args[i], arg_lengths[i], i))))
         result = true;
 
-    if (result == false) {
+    if (!result) {
       /*
         Error has been already set by the validator.
       */
@@ -369,9 +369,7 @@ static bool arg_check(IError_handler &handler, UDF_ARGS *args) {
     arg_lengths += audit_log_extra_args_def[arg_res].count;
   };
 
-  if (set_args_charset_info(args, handler)) return true;
-
-  return false;
+  return set_args_charset_info(args, handler);
 }
 
 /**

components/libminchassis/dynamic_loader_scheme_file.cc

@@ -158,7 +158,7 @@ DEFINE_BOOL_METHOD(mysql_dynamic_loader_scheme_file_imp::load,
 
     /* Check if library is not already loaded, by comparing "list_components"
       function address. */
-    if (library_entry_set.insert(list_func).second == false) {
+    if (!library_entry_set.insert(list_func).second) {
       return true;
     }
 
@@ -175,7 +175,7 @@ DEFINE_BOOL_METHOD(mysql_dynamic_loader_scheme_file_imp::load,
 
     /* Add library and it's handle to list of loaded libraries. */
 
-    if (object_files_list.emplace(urn_string, handle).second == false) {
+    if (!object_files_list.emplace(urn_string, handle).second) {
       return true;
     }
 

components/pfs_component/pfs_example_continent.cc

@@ -232,7 +232,7 @@ int write_rows_from_component(Continent_Table_Handle *handle) {
     int i = (continent_next_available_index + 1) % CONTINENT_MAX_ROWS;
     int itr_count = 0;
     while (itr_count < CONTINENT_MAX_ROWS) {
-      if (continent_records_array[i].m_exist == false) {
+      if (!continent_records_array[i].m_exist) {
         continent_next_available_index = i;
         break;
       }