Skip to content

Commit 43a68bf

Browse files
author
Erik Froseth
committed
Bug#29833332 MANY MTR TESTS ARE NOT DETERMINISTIC
Post push fix: Make a few more test cases deterministic. Change-Id: Iaa10cd8fc8f8ba50f6403d3dc5ea266cd3527c54
1 parent 247943d commit 43a68bf

13 files changed

+22
-15
lines changed

Diff for: mysql-test/include/subquery.inc

+2
Original file line numberDiff line numberDiff line change
@@ -4540,7 +4540,9 @@ SELECT * FROM (SELECT 1 a UNION SELECT 1 a ORDER BY a LIMIT 1) t1a;
45404540

45414541
# Test of rule
45424542
# table_factor: '(' get_select_lex query_expression_body ')' opt_table_alias
4543+
--sorted_result
45434544
SELECT * FROM t1 JOIN (SELECT 1 UNION SELECT 1) alias ON 1;
4545+
--sorted_result
45444546
SELECT * FROM t1 JOIN ((SELECT 1 UNION SELECT 1)) alias ON 1;
45454547
--error ER_DERIVED_MUST_HAVE_ALIAS
45464548
SELECT * FROM t1 JOIN (SELECT 1 UNION SELECT 1) ON 1;

Diff for: mysql-test/r/derived.result

+1-1
Original file line numberDiff line numberDiff line change
@@ -262,8 +262,8 @@ insert into t1 values (1),(2);
262262
select * from ( select * from t1 union select * from t1) a,(select * from t1 union select * from t1) b;
263263
a a
264264
1 1
265-
2 1
266265
1 2
266+
2 1
267267
2 2
268268
explain select * from ( select * from t1 union select * from t1) a,(select * from t1 union select * from t1) b;
269269
id select_type table partitions type possible_keys key key_len ref rows filtered Extra

Diff for: mysql-test/suite/funcs_1/datadict/is_triggers.inc

+1
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ eval SHOW COLUMNS FROM information_schema.$is_table;
7777

7878
# Show that several columns are always NULL.
7979
--replace_column 17 #
80+
--sorted_result
8081
SELECT * FROM information_schema.triggers
8182
WHERE trigger_catalog IS NOT NULL OR event_object_catalog IS NOT NULL
8283
OR action_condition IS NOT NULL OR action_reference_old_table IS NOT NULL

Diff for: mysql-test/suite/funcs_1/r/is_triggers.result

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,10 @@ WHERE trigger_catalog IS NOT NULL OR event_object_catalog IS NOT NULL
8282
OR action_condition IS NOT NULL OR action_reference_old_table IS NOT NULL
8383
OR action_reference_new_table IS NOT NULL;
8484
TRIGGER_CATALOG TRIGGER_SCHEMA TRIGGER_NAME EVENT_MANIPULATION EVENT_OBJECT_CATALOG EVENT_OBJECT_SCHEMA EVENT_OBJECT_TABLE ACTION_ORDER ACTION_CONDITION ACTION_STATEMENT ACTION_ORIENTATION ACTION_TIMING ACTION_REFERENCE_OLD_TABLE ACTION_REFERENCE_NEW_TABLE ACTION_REFERENCE_OLD_ROW ACTION_REFERENCE_NEW_ROW CREATED SQL_MODE DEFINER CHARACTER_SET_CLIENT COLLATION_CONNECTION DATABASE_COLLATION
85+
def mtr gs_insert INSERT def mtr global_suppressions 1 NULL BEGIN DECLARE dummy INT; SET GLOBAL regexp_time_limit = 0; SELECT "" REGEXP NEW.pattern INTO dummy; SET GLOBAL regexp_time_limit = DEFAULT; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION root@localhost latin1 latin1_swedish_ci utf8mb4_0900_ai_ci
86+
def mtr ts_insert INSERT def mtr test_suppressions 1 NULL BEGIN DECLARE dummy INT; SET GLOBAL regexp_time_limit = 0; SELECT "" REGEXP NEW.pattern INTO dummy; SET GLOBAL regexp_time_limit = DEFAULT; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION root@localhost latin1 latin1_swedish_ci utf8mb4_0900_ai_ci
8587
def sys sys_config_insert_set_user INSERT def sys sys_config 1 NULL BEGIN IF @sys.ignore_sys_config_triggers != true AND NEW.set_by IS NULL THEN SET NEW.set_by = USER(); END IF; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION mysql.sys@localhost utf8mb4 utf8mb4_0900_ai_ci utf8mb4_0900_ai_ci
8688
def sys sys_config_update_set_user UPDATE def sys sys_config 1 NULL BEGIN IF @sys.ignore_sys_config_triggers != true AND NEW.set_by IS NULL THEN SET NEW.set_by = USER(); END IF; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION mysql.sys@localhost utf8mb4 utf8mb4_0900_ai_ci utf8mb4_0900_ai_ci
87-
def mtr ts_insert INSERT def mtr test_suppressions 1 NULL BEGIN DECLARE dummy INT; SET GLOBAL regexp_time_limit = 0; SELECT "" REGEXP NEW.pattern INTO dummy; SET GLOBAL regexp_time_limit = DEFAULT; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION root@localhost latin1 latin1_swedish_ci utf8mb4_0900_ai_ci
88-
def mtr gs_insert INSERT def mtr global_suppressions 1 NULL BEGIN DECLARE dummy INT; SET GLOBAL regexp_time_limit = 0; SELECT "" REGEXP NEW.pattern INTO dummy; SET GLOBAL regexp_time_limit = DEFAULT; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION root@localhost latin1 latin1_swedish_ci utf8mb4_0900_ai_ci
8989
##################################################################################
9090
# Testcase 3.2.18.2 + 3.2.18.3: INFORMATION_SCHEMA.TRIGGERS accessible information
9191
##################################################################################

Diff for: mysql-test/suite/funcs_1/r/is_triggers_ci.result

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,10 @@ WHERE trigger_catalog IS NOT NULL OR event_object_catalog IS NOT NULL
8282
OR action_condition IS NOT NULL OR action_reference_old_table IS NOT NULL
8383
OR action_reference_new_table IS NOT NULL;
8484
TRIGGER_CATALOG TRIGGER_SCHEMA TRIGGER_NAME EVENT_MANIPULATION EVENT_OBJECT_CATALOG EVENT_OBJECT_SCHEMA EVENT_OBJECT_TABLE ACTION_ORDER ACTION_CONDITION ACTION_STATEMENT ACTION_ORIENTATION ACTION_TIMING ACTION_REFERENCE_OLD_TABLE ACTION_REFERENCE_NEW_TABLE ACTION_REFERENCE_OLD_ROW ACTION_REFERENCE_NEW_ROW CREATED SQL_MODE DEFINER CHARACTER_SET_CLIENT COLLATION_CONNECTION DATABASE_COLLATION
85+
def mtr gs_insert INSERT def mtr global_suppressions 1 NULL BEGIN DECLARE dummy INT; SET GLOBAL regexp_time_limit = 0; SELECT "" REGEXP NEW.pattern INTO dummy; SET GLOBAL regexp_time_limit = DEFAULT; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION root@localhost latin1 latin1_swedish_ci utf8mb4_0900_ai_ci
86+
def mtr ts_insert INSERT def mtr test_suppressions 1 NULL BEGIN DECLARE dummy INT; SET GLOBAL regexp_time_limit = 0; SELECT "" REGEXP NEW.pattern INTO dummy; SET GLOBAL regexp_time_limit = DEFAULT; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION root@localhost latin1 latin1_swedish_ci utf8mb4_0900_ai_ci
8587
def sys sys_config_insert_set_user INSERT def sys sys_config 1 NULL BEGIN IF @sys.ignore_sys_config_triggers != true AND NEW.set_by IS NULL THEN SET NEW.set_by = USER(); END IF; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION mysql.sys@localhost utf8mb4 utf8mb4_0900_ai_ci utf8mb4_0900_ai_ci
8688
def sys sys_config_update_set_user UPDATE def sys sys_config 1 NULL BEGIN IF @sys.ignore_sys_config_triggers != true AND NEW.set_by IS NULL THEN SET NEW.set_by = USER(); END IF; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION mysql.sys@localhost utf8mb4 utf8mb4_0900_ai_ci utf8mb4_0900_ai_ci
87-
def mtr ts_insert INSERT def mtr test_suppressions 1 NULL BEGIN DECLARE dummy INT; SET GLOBAL regexp_time_limit = 0; SELECT "" REGEXP NEW.pattern INTO dummy; SET GLOBAL regexp_time_limit = DEFAULT; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION root@localhost latin1 latin1_swedish_ci utf8mb4_0900_ai_ci
88-
def mtr gs_insert INSERT def mtr global_suppressions 1 NULL BEGIN DECLARE dummy INT; SET GLOBAL regexp_time_limit = 0; SELECT "" REGEXP NEW.pattern INTO dummy; SET GLOBAL regexp_time_limit = DEFAULT; END ROW BEFORE NULL NULL OLD NEW # ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION root@localhost latin1 latin1_swedish_ci utf8mb4_0900_ai_ci
8989
##################################################################################
9090
# Testcase 3.2.18.2 + 3.2.18.3: INFORMATION_SCHEMA.TRIGGERS accessible information
9191
##################################################################################

Diff for: mysql-test/suite/innodb/include/innodb_dict.inc

+1
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@ INNER JOIN sys_tables st ON i.TABLE_ID=st.TABLE_ID ORDER BY i.NAME,i.POS;
55
SELECT si.NAME,i.POS,i.NAME FROM INFORMATION_SCHEMA.INNODB_FIELDS i
66
INNER JOIN sys_indexes si ON i.INDEX_ID=si.INDEX_ID ORDER BY si.NAME, i.POS;
77

8+
--sorted_result
89
SELECT i.FOR_COL_NAME, i.REF_COL_NAME, i.POS FROM INFORMATION_SCHEMA.INNODB_FOREIGN_COLS i
910
INNER JOIN sys_foreign sf ON i.ID = sf.ID;

Diff for: mysql-test/suite/perfschema/include/digest_execution.inc

+2
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,12 @@ WITH cte (x,y,z)AS (SELECT a,1,1 FROM t1) SELECT 1, cte.*, cte2.* FROM cte, cte
151151
--sorted_result
152152
WITH cte (x,y,z)AS (SELECT a,2,2 FROM t1) SELECT 2, cte.*, cte2.* FROM cte, cte AS cte2;
153153

154+
--sorted_result
154155
WITH RECURSIVE cte (x,y,z) AS
155156
(SELECT a,1,1 FROM t1 UNION ALL SELECT a+1,a*1,11 FROM t1 WHERE 0)
156157
SELECT 1, cte.*, cte2.* FROM cte, cte AS cte2;
157158

159+
--sorted_result
158160
WITH RECURSIVE cte (x,y,z) AS
159161
(SELECT a,2,2 FROM t1 UNION ALL SELECT a+2,a*2,22 FROM t1 WHERE 0)
160162
SELECT 2, cte.*, cte2.* FROM cte, cte AS cte2;

Diff for: mysql-test/suite/perfschema/r/digest_table_full.result

+2-2
Original file line numberDiff line numberDiff line change
@@ -157,16 +157,16 @@ WITH RECURSIVE cte (x,y,z) AS
157157
SELECT 1, cte.*, cte2.* FROM cte, cte AS cte2;
158158
1 x y z x y z
159159
1 1 1 1 1 1 1
160-
1 2 1 1 1 1 1
161160
1 1 1 1 2 1 1
161+
1 2 1 1 1 1 1
162162
1 2 1 1 2 1 1
163163
WITH RECURSIVE cte (x,y,z) AS
164164
(SELECT a,2,2 FROM t1 UNION ALL SELECT a+2,a*2,22 FROM t1 WHERE 0)
165165
SELECT 2, cte.*, cte2.* FROM cte, cte AS cte2;
166166
2 x y z x y z
167167
2 1 2 2 1 2 2
168-
2 2 2 2 1 2 2
169168
2 1 2 2 2 2 2
169+
2 2 2 2 1 2 2
170170
2 2 2 2 2 2 2
171171
####################################
172172
# QUERYING PS STATEMENT DIGEST

Diff for: mysql-test/suite/perfschema/r/start_server_no_digests.result

+2-2
Original file line numberDiff line numberDiff line change
@@ -157,16 +157,16 @@ WITH RECURSIVE cte (x,y,z) AS
157157
SELECT 1, cte.*, cte2.* FROM cte, cte AS cte2;
158158
1 x y z x y z
159159
1 1 1 1 1 1 1
160-
1 2 1 1 1 1 1
161160
1 1 1 1 2 1 1
161+
1 2 1 1 1 1 1
162162
1 2 1 1 2 1 1
163163
WITH RECURSIVE cte (x,y,z) AS
164164
(SELECT a,2,2 FROM t1 UNION ALL SELECT a+2,a*2,22 FROM t1 WHERE 0)
165165
SELECT 2, cte.*, cte2.* FROM cte, cte AS cte2;
166166
2 x y z x y z
167167
2 1 2 2 1 2 2
168-
2 2 2 2 1 2 2
169168
2 1 2 2 2 2 2
169+
2 2 2 2 1 2 2
170170
2 2 2 2 2 2 2
171171
####################################
172172
# QUERYING PS STATEMENT DIGEST

Diff for: mysql-test/suite/perfschema/r/statement_digest.result

+2-2
Original file line numberDiff line numberDiff line change
@@ -158,16 +158,16 @@ WITH RECURSIVE cte (x,y,z) AS
158158
SELECT 1, cte.*, cte2.* FROM cte, cte AS cte2;
159159
1 x y z x y z
160160
1 1 1 1 1 1 1
161-
1 2 1 1 1 1 1
162161
1 1 1 1 2 1 1
162+
1 2 1 1 1 1 1
163163
1 2 1 1 2 1 1
164164
WITH RECURSIVE cte (x,y,z) AS
165165
(SELECT a,2,2 FROM t1 UNION ALL SELECT a+2,a*2,22 FROM t1 WHERE 0)
166166
SELECT 2, cte.*, cte2.* FROM cte, cte AS cte2;
167167
2 x y z x y z
168168
2 1 2 2 1 2 2
169-
2 2 2 2 1 2 2
170169
2 1 2 2 2 2 2
170+
2 2 2 2 1 2 2
171171
2 2 2 2 2 2 2
172172
####################################
173173
# QUERYING PS STATEMENT DIGEST

Diff for: mysql-test/suite/perfschema/r/statement_digest_consumers.result

+2-2
Original file line numberDiff line numberDiff line change
@@ -174,16 +174,16 @@ WITH RECURSIVE cte (x,y,z) AS
174174
SELECT 1, cte.*, cte2.* FROM cte, cte AS cte2;
175175
1 x y z x y z
176176
1 1 1 1 1 1 1
177-
1 2 1 1 1 1 1
178177
1 1 1 1 2 1 1
178+
1 2 1 1 1 1 1
179179
1 2 1 1 2 1 1
180180
WITH RECURSIVE cte (x,y,z) AS
181181
(SELECT a,2,2 FROM t1 UNION ALL SELECT a+2,a*2,22 FROM t1 WHERE 0)
182182
SELECT 2, cte.*, cte2.* FROM cte, cte AS cte2;
183183
2 x y z x y z
184184
2 1 2 2 1 2 2
185-
2 2 2 2 1 2 2
186185
2 1 2 2 2 2 2
186+
2 2 2 2 1 2 2
187187
2 2 2 2 2 2 2
188188
####################################
189189
# QUERYING PS STATEMENT DIGEST

Diff for: mysql-test/suite/perfschema/r/statement_digest_consumers2.result

+2-2
Original file line numberDiff line numberDiff line change
@@ -174,16 +174,16 @@ WITH RECURSIVE cte (x,y,z) AS
174174
SELECT 1, cte.*, cte2.* FROM cte, cte AS cte2;
175175
1 x y z x y z
176176
1 1 1 1 1 1 1
177-
1 2 1 1 1 1 1
178177
1 1 1 1 2 1 1
178+
1 2 1 1 1 1 1
179179
1 2 1 1 2 1 1
180180
WITH RECURSIVE cte (x,y,z) AS
181181
(SELECT a,2,2 FROM t1 UNION ALL SELECT a+2,a*2,22 FROM t1 WHERE 0)
182182
SELECT 2, cte.*, cte2.* FROM cte, cte AS cte2;
183183
2 x y z x y z
184184
2 1 2 2 1 2 2
185-
2 2 2 2 1 2 2
186185
2 1 2 2 2 2 2
186+
2 2 2 2 1 2 2
187187
2 2 2 2 2 2 2
188188
####################################
189189
# QUERYING PS STATEMENT DIGEST

Diff for: mysql-test/t/derived.test

+1
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ drop table t1;
155155

156156
create table t1 (a int);
157157
insert into t1 values (1),(2);
158+
--sorted_result
158159
select * from ( select * from t1 union select * from t1) a,(select * from t1 union select * from t1) b;
159160
explain select * from ( select * from t1 union select * from t1) a,(select * from t1 union select * from t1) b;
160161
drop table t1;

0 commit comments

Comments
 (0)