WL#10380: Group Replication: Monitoring improvements

Description:
This worklog goal is to improve Group Replication by introducing additional
columns in existing performance schema.

Schema after code changes:

For table - performance_schema.replication_group_member_stats
New suggested columns:
Field          Type     Null Key  Default Description
MEMBER_ROLE    char(64) NO        NULL    Member role in a group; can be any of
the PRIMARY or SECONDARY
MEMBER_VERSION char(64) NO        NULL    The MySQL version of the member.
NOTE: Columns will be added in same sequence as listed above.

For table - performance_schema.replication_group_member_stats
New suggested columns:
Field                                      Type                Null  Key
Default  Description
COUNT_TRANSACTIONS_REMOTE_IN_APPLIER_QUEUE bigint(20) unsigned NO         NULL
Transactions waiting apply, received from group.
COUNT_TRANSACTIONS_REMOTE_APPLIED          bigint(20) unsigned NO         NULL
Transactions applied, received from group.
COUNT_TRANSACTIONS_LOCAL_PROPOSED          bigint(20) unsigned No         NULL
Number of local transaction requested by member to Group Replication Plugin for
commit.
COUNT_TRANSACTIONS_LOCAL_ROLLBACK          bigint(20) unsigned No         NULL
Number of transaction originated from local member but rolledback at GROUP level
NOTE: Columns will be added in same sequence as listed above.

Author: Jaideep Karande

include/mysql/plugin_group_replication.h

@@ -1,4 +1,4 @@
-/* Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -22,7 +22,7 @@
 */
 
 #include <mysql/plugin.h>
-#define MYSQL_GROUP_REPLICATION_INTERFACE_VERSION 0x0101
+#define MYSQL_GROUP_REPLICATION_INTERFACE_VERSION 0x0102
 
 /*
   Callbacks for get_connection_status_info function.
@@ -59,6 +59,8 @@ typedef struct st_group_replication_group_members_callbacks
   void (*set_member_host)(void* const context, const char& value, size_t length);
   void (*set_member_port)(void* const context, unsigned int value);
   void (*set_member_state)(void* const context, const char& value, size_t length);
+  void (*set_member_role)(void* const context, const char& value, size_t length);
+  void (*set_member_version)(void* const context, const char& value, size_t length);
 } GROUP_REPLICATION_GROUP_MEMBERS_CALLBACKS;
 
 /*
@@ -82,6 +84,10 @@ typedef struct st_group_replication_member_stats_callbacks
   void (*set_transactions_certified)(void* const context, unsigned long long int value);
   void (*set_transactions_conflicts_detected)(void* const context, unsigned long long int value);
   void (*set_transactions_rows_in_validation)(void* const context, unsigned long long int value);
+  void (*set_transactions_remote_applier_queue)(void* const context, unsigned long long int value);
+  void (*set_transactions_remote_applied)(void* const context, unsigned long long int value);
+  void (*set_transactions_local_proposed)(void* const context, unsigned long long int value);
+  void (*set_transactions_local_rollback)(void* const context, unsigned long long int value);
 } GROUP_REPLICATION_GROUP_MEMBER_STATS_CALLBACKS;
 
 struct st_mysql_group_replication
@@ -123,6 +129,8 @@ struct st_mysql_group_replication
   /*
     This function is used to fetch information for group replication members.
 
+    @param index     Row index for which information needs to be fetched
+
     @param callbacks The set of callbacks and its context used to set the
                      information on caller.
 
@@ -136,14 +144,17 @@ struct st_mysql_group_replication
   /*
     This function is used to fetch information for group replication members statistics.
 
+    @param index     Row index for which information needs to be fetched
+
     @param callbacks The set of callbacks and its context used to set the
                      information on caller.
 
     @note The caller is responsible to free memory from the info structure and
           from all its fields.
   */
   bool (*get_group_member_stats_info)
-       (const GROUP_REPLICATION_GROUP_MEMBER_STATS_CALLBACKS& callbacks);
+       (unsigned int index,
+        const GROUP_REPLICATION_GROUP_MEMBER_STATS_CALLBACKS& callbacks);
 
   /*
     Get number of group replication members.

mysql-test/r/dd_upgrade_partition.result

@@ -27,6 +27,8 @@ call mtr.add_suppression("InnoDB: Unable to delete statistics for table mysql.")
 call mtr.add_suppression("Column count of performance_schema.replication_connection_status is wrong. Expected 20, found 11*");
 call mtr.add_suppression("Column count of performance_schema.replication_applier_status_by_coordinator is wrong. Expected 15, found 6.*");
 call mtr.add_suppression("Column count of performance_schema.replication_applier_status_by_worker is wrong. Expected 16, found 8.*");
+call mtr.add_suppression("Column count of performance_schema.replication_group_members is wrong. Expected 7, found 5.*");
+call mtr.add_suppression("Column count of performance_schema.replication_group_member_stats is wrong. Expected 13, found 9.*");
 call mtr.add_suppression("Column count of performance_schema.threads is wrong. Expected 18, found 17.*");
 # Copy the remote tablespace & DB zip files from suite location to working location.
 # Check that the file exists in the working folder.

mysql-test/r/dd_upgrade_test.result

@@ -28,6 +28,8 @@ call mtr.add_suppression("InnoDB: Unable to delete statistics for table mysql.")
 call mtr.add_suppression("Column count of performance_schema.replication_applier_status_by_worker is wrong. Expected 16, found 8.");
 call mtr.add_suppression("Column count of performance_schema.replication_applier_status_by_coordinator is wrong. Expected 15, found 6.");
 call mtr.add_suppression("Column count of performance_schema.replication_connection_status is wrong. Expected 20, found 11.");
+call mtr.add_suppression("Column count of performance_schema.replication_group_members is wrong. Expected 7, found 5.");
+call mtr.add_suppression("Column count of performance_schema.replication_group_member_stats is wrong. Expected 13, found 9.");
 call mtr.add_suppression("\\[Warning\\] InnoDB: Parent table of FTS auxiliary table.*");
 # Copy the remote tablespace & DB zip files from suite location to working location.
 # Check that the file exists in the working folder.

mysql-test/suite/perfschema/r/dml_replication_group_member_stats.result

@@ -1,9 +1,9 @@
 SELECT * FROM performance_schema.replication_group_member_stats
 LIMIT 1;
-CHANNEL_NAME	VIEW_ID	MEMBER_ID	COUNT_TRANSACTIONS_IN_QUEUE	COUNT_TRANSACTIONS_CHECKED	COUNT_CONFLICTS_DETECTED	COUNT_TRANSACTIONS_ROWS_VALIDATING	TRANSACTIONS_COMMITTED_ALL_MEMBERS	LAST_CONFLICT_FREE_TRANSACTION
+CHANNEL_NAME	VIEW_ID	MEMBER_ID	COUNT_TRANSACTIONS_IN_QUEUE	COUNT_TRANSACTIONS_CHECKED	COUNT_CONFLICTS_DETECTED	COUNT_TRANSACTIONS_ROWS_VALIDATING	TRANSACTIONS_COMMITTED_ALL_MEMBERS	LAST_CONFLICT_FREE_TRANSACTION	COUNT_TRANSACTIONS_REMOTE_IN_APPLIER_QUEUE	COUNT_TRANSACTIONS_REMOTE_APPLIED	COUNT_TRANSACTIONS_LOCAL_PROPOSED	COUNT_TRANSACTIONS_LOCAL_ROLLBACK
 SELECT * FROM performance_schema.replication_group_member_stats
 WHERE channel_name='FOO';
-CHANNEL_NAME	VIEW_ID	MEMBER_ID	COUNT_TRANSACTIONS_IN_QUEUE	COUNT_TRANSACTIONS_CHECKED	COUNT_CONFLICTS_DETECTED	COUNT_TRANSACTIONS_ROWS_VALIDATING	TRANSACTIONS_COMMITTED_ALL_MEMBERS	LAST_CONFLICT_FREE_TRANSACTION
+CHANNEL_NAME	VIEW_ID	MEMBER_ID	COUNT_TRANSACTIONS_IN_QUEUE	COUNT_TRANSACTIONS_CHECKED	COUNT_CONFLICTS_DETECTED	COUNT_TRANSACTIONS_ROWS_VALIDATING	TRANSACTIONS_COMMITTED_ALL_MEMBERS	LAST_CONFLICT_FREE_TRANSACTION	COUNT_TRANSACTIONS_REMOTE_IN_APPLIER_QUEUE	COUNT_TRANSACTIONS_REMOTE_APPLIED	COUNT_TRANSACTIONS_LOCAL_PROPOSED	COUNT_TRANSACTIONS_LOCAL_ROLLBACK
 INSERT INTO performance_schema.replication_group_member_stats
 SET channel_name='FOO', node_id=1;
 ERROR 42000: INSERT command denied to user 'root'@'localhost' for table 'replication_group_member_stats'

mysql-test/suite/perfschema/r/idx_replication_group_member_stats.result

@@ -9,7 +9,11 @@ replication_group_member_stats	CREATE TABLE `replication_group_member_stats` (
   `COUNT_CONFLICTS_DETECTED` bigint(20) unsigned NOT NULL,
   `COUNT_TRANSACTIONS_ROWS_VALIDATING` bigint(20) unsigned NOT NULL,
   `TRANSACTIONS_COMMITTED_ALL_MEMBERS` longtext NOT NULL,
-  `LAST_CONFLICT_FREE_TRANSACTION` text NOT NULL
+  `LAST_CONFLICT_FREE_TRANSACTION` text NOT NULL,
+  `COUNT_TRANSACTIONS_REMOTE_IN_APPLIER_QUEUE` bigint(20) unsigned NOT NULL,
+  `COUNT_TRANSACTIONS_REMOTE_APPLIED` bigint(20) unsigned NOT NULL,
+  `COUNT_TRANSACTIONS_LOCAL_PROPOSED` bigint(20) unsigned NOT NULL,
+  `COUNT_TRANSACTIONS_LOCAL_ROLLBACK` bigint(20) unsigned NOT NULL
 ) ENGINE=PERFORMANCE_SCHEMA DEFAULT CHARSET=utf8
 select * from INFORMATION_SCHEMA.STATISTICS
 where TABLE_SCHEMA = "performance_schema"

mysql-test/suite/perfschema/r/idx_replication_group_members.result

@@ -5,7 +5,9 @@ replication_group_members	CREATE TABLE `replication_group_members` (
   `MEMBER_ID` char(36) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL,
   `MEMBER_HOST` char(60) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL,
   `MEMBER_PORT` int(11) DEFAULT NULL,
-  `MEMBER_STATE` char(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL
+  `MEMBER_STATE` char(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL,
+  `MEMBER_ROLE` char(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL,
+  `MEMBER_VERSION` char(64) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL
 ) ENGINE=PERFORMANCE_SCHEMA DEFAULT CHARSET=utf8
 select * from INFORMATION_SCHEMA.STATISTICS
 where TABLE_SCHEMA = "performance_schema"

mysql-test/suite/perfschema/r/table_schema.result

@@ -1031,6 +1031,8 @@ def	performance_schema	replication_group_members	MEMBER_ID	2	NULL	NO	char	36	108
 def	performance_schema	replication_group_members	MEMBER_HOST	3	NULL	NO	char	60	180	NULL	NULL	NULL	utf8	utf8_bin	char(60)			select,insert,update,references		
 def	performance_schema	replication_group_members	MEMBER_PORT	4	NULL	YES	int	NULL	NULL	10	0	NULL	NULL	NULL	int(11)			select,insert,update,references		
 def	performance_schema	replication_group_members	MEMBER_STATE	5	NULL	NO	char	64	192	NULL	NULL	NULL	utf8	utf8_bin	char(64)			select,insert,update,references		
+def	performance_schema	replication_group_members	MEMBER_ROLE	6	NULL	NO	char	64	192	NULL	NULL	NULL	utf8	utf8_bin	char(64)			select,insert,update,references		
+def	performance_schema	replication_group_members	MEMBER_VERSION	7	NULL	NO	char	64	192	NULL	NULL	NULL	utf8	utf8_bin	char(64)			select,insert,update,references		
 def	performance_schema	replication_group_member_stats	CHANNEL_NAME	1	NULL	NO	char	64	192	NULL	NULL	NULL	utf8	utf8_general_ci	char(64)			select,insert,update,references		
 def	performance_schema	replication_group_member_stats	VIEW_ID	2	NULL	NO	char	60	180	NULL	NULL	NULL	utf8	utf8_bin	char(60)			select,insert,update,references		
 def	performance_schema	replication_group_member_stats	MEMBER_ID	3	NULL	NO	char	36	108	NULL	NULL	NULL	utf8	utf8_bin	char(36)			select,insert,update,references		
@@ -1040,6 +1042,10 @@ def	performance_schema	replication_group_member_stats	COUNT_CONFLICTS_DETECTED	6
 def	performance_schema	replication_group_member_stats	COUNT_TRANSACTIONS_ROWS_VALIDATING	7	NULL	NO	bigint	NULL	NULL	20	0	NULL	NULL	NULL	bigint(20) unsigned			select,insert,update,references		
 def	performance_schema	replication_group_member_stats	TRANSACTIONS_COMMITTED_ALL_MEMBERS	8	NULL	NO	longtext	4294967295	4294967295	NULL	NULL	NULL	utf8	utf8_general_ci	longtext			select,insert,update,references		
 def	performance_schema	replication_group_member_stats	LAST_CONFLICT_FREE_TRANSACTION	9	NULL	NO	text	65535	65535	NULL	NULL	NULL	utf8	utf8_general_ci	text			select,insert,update,references		
+def	performance_schema	replication_group_member_stats	COUNT_TRANSACTIONS_REMOTE_IN_APPLIER_QUEUE	10	NULL	NO	bigint	NULL	NULL	20	0	NULL	NULL	NULL	bigint(20) unsigned			select,insert,update,references		
+def	performance_schema	replication_group_member_stats	COUNT_TRANSACTIONS_REMOTE_APPLIED	11	NULL	NO	bigint	NULL	NULL	20	0	NULL	NULL	NULL	bigint(20) unsigned			select,insert,update,references		
+def	performance_schema	replication_group_member_stats	COUNT_TRANSACTIONS_LOCAL_PROPOSED	12	NULL	NO	bigint	NULL	NULL	20	0	NULL	NULL	NULL	bigint(20) unsigned			select,insert,update,references		
+def	performance_schema	replication_group_member_stats	COUNT_TRANSACTIONS_LOCAL_ROLLBACK	13	NULL	NO	bigint	NULL	NULL	20	0	NULL	NULL	NULL	bigint(20) unsigned			select,insert,update,references		
 def	performance_schema	rwlock_instances	NAME	1	NULL	NO	varchar	128	384	NULL	NULL	NULL	utf8	utf8_general_ci	varchar(128)	MUL		select,insert,update,references		
 def	performance_schema	rwlock_instances	OBJECT_INSTANCE_BEGIN	2	NULL	NO	bigint	NULL	NULL	20	0	NULL	NULL	NULL	bigint(20) unsigned	PRI		select,insert,update,references		
 def	performance_schema	rwlock_instances	WRITE_LOCKED_BY_THREAD_ID	3	NULL	YES	bigint	NULL	NULL	20	0	NULL	NULL	NULL	bigint(20) unsigned	MUL		select,insert,update,references		

mysql-test/t/dd_upgrade_partition.test

@@ -41,6 +41,8 @@ call mtr.add_suppression("InnoDB: Unable to delete statistics for table mysql.")
 call mtr.add_suppression("Column count of performance_schema.replication_connection_status is wrong. Expected 20, found 11*");
 call mtr.add_suppression("Column count of performance_schema.replication_applier_status_by_coordinator is wrong. Expected 15, found 6.*");
 call mtr.add_suppression("Column count of performance_schema.replication_applier_status_by_worker is wrong. Expected 16, found 8.*");
+call mtr.add_suppression("Column count of performance_schema.replication_group_members is wrong. Expected 7, found 5.*");
+call mtr.add_suppression("Column count of performance_schema.replication_group_member_stats is wrong. Expected 13, found 9.*");
 call mtr.add_suppression("Column count of performance_schema.threads is wrong. Expected 18, found 17.*");
 
 # Set different paths for --datadir

mysql-test/t/dd_upgrade_test.test

@@ -39,6 +39,8 @@ call mtr.add_suppression("InnoDB: Unable to delete statistics for table mysql.")
 call mtr.add_suppression("Column count of performance_schema.replication_applier_status_by_worker is wrong. Expected 16, found 8.");
 call mtr.add_suppression("Column count of performance_schema.replication_applier_status_by_coordinator is wrong. Expected 15, found 6.");
 call mtr.add_suppression("Column count of performance_schema.replication_connection_status is wrong. Expected 20, found 11.");
+call mtr.add_suppression("Column count of performance_schema.replication_group_members is wrong. Expected 7, found 5.");
+call mtr.add_suppression("Column count of performance_schema.replication_group_member_stats is wrong. Expected 13, found 9.");
 call mtr.add_suppression("\\[Warning\\] InnoDB: Parent table of FTS auxiliary table.*");
 # Set different paths for --datadir
 let $MYSQLD_DATADIR1 = $MYSQL_TMP_DIR/data57;

rapid/plugin/group_replication/include/certifier.h

@@ -722,7 +722,7 @@ class Certifier: public Certifier_interface
   Update method to store the count of the positively and negatively
   certified transaction on a particular group member.
 */
-  void update_certified_transaction_count(bool result);
+  void update_certified_transaction_count(bool result, bool local_transaction);
 };
 
 /*

rapid/plugin/group_replication/include/member_info.h

@@ -216,6 +216,11 @@ class Group_member_info: public Plugin_gcs_message
    */
   Group_member_role get_role();
 
+  /**
+    @return the member role type code in string
+   */
+  const char* get_member_role_string();
+
   /**
     @return the member plugin version
    */

rapid/plugin/group_replication/include/member_version.h

@@ -16,6 +16,8 @@
 #ifndef MEMBER_VERSION_INCLUDED
 #define	MEMBER_VERSION_INCLUDED
 
+#include <string>
+
 #include "my_inttypes.h"
 
 class Member_version
@@ -28,6 +30,10 @@ class Member_version
   */
   uint32 get_version() const;
 
+  /**
+    @return returns the member version in string format.
+  */
+  const std::string get_version_string() const;
   /**
     @return returns the major version (Major.v.v)
   */