Skip to content

Commit 841c3c7

Browse files
committed
Bug#34754817 Reconsider message "Failed to set ODirect errno:" as it is repeated
Follow up patch. Build breakage on OpenSUSE15 and Ubuntu 20.04 when compiling with GCC 9. AsyncFile.cpp:1172:52: error: use of deleted function 'AsyncFile::odirect_set_log_state::odirect_set_log_state()' 1172 | AsyncFile::odirect_set_log_bp[FsOpenReq::BP_MAX]; | ^ In file included from AsyncFile.cpp:32: AsyncFile.hpp:161:10: note: 'AsyncFile::odirect_set_log_state::odirect_set_log_state()' is implicitly deleted because the default definition would be ill-formed: 161 | struct odirect_set_log_state { | ^~~~~~~~~~~~~~~~~~~~~ AsyncFile.hpp:161:10: error: use of deleted function 'std::atomic<_Tp>::atomic() [with _Tp = NDB_TICKS]' In file included from AsyncFile.hpp:29, from AsyncFile.cpp:32: /usr/include/c++/9/atomic:198:7: note: 'std::atomic<_Tp>::atomic() noexcept [with _Tp = NDB_TICKS]' is implicitly deleted because its exception-specification does not match the implicit exception-specification '' 198 | atomic() noexcept = default; | ^~~~~~ Change-Id: I111c041825f193dec145bec00dd6428c554e6785
1 parent 4d19b5b commit 841c3c7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

storage/ndb/src/kernel/blocks/ndbfs/AsyncFile.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ class AsyncFile {
159159
static constexpr Uint64 odirect_set_log_suppress_period_s =
160160
4 * 60 * 60; // 4 hours in seconds
161161
struct odirect_set_log_state {
162-
std::atomic<NDB_TICKS> last_warning;
162+
std::atomic<NDB_TICKS> last_warning = NDB_TICKS{0};
163163
std::atomic<Uint32> failures = 0;
164164
std::atomic<Uint32> successes = 0;
165165
};

0 commit comments

Comments
 (0)