Bug#20462601: INCORRECT (SIGNED) TYPE ON CHANNEL_GET_APPLIERS_THREAD_ID() FUNCTION

The appliers_id parameter in the  channel_get_appliers_thread_id method of
the channel interface was signed, not matching the my_thread_id definition.
That is correct and the parameter is now unsigned.

Author: pedrolgomes

sql/rpl_channel_service_interface.cc

@@ -432,7 +432,8 @@ bool channel_is_active(const char* channel, enum_channel_thread_types thd_type)
   DBUG_RETURN(false);
 }
 
-int channel_get_appliers_thread_id(const char* channel, long** appliers_id)
+int channel_get_appliers_thread_id(const char* channel,
+                                   unsigned long** appliers_id)
 {
   DBUG_ENTER("channel_is_active(channel, thd_type");
 
@@ -452,9 +453,10 @@ int channel_get_appliers_thread_id(const char* channel, long** appliers_id)
     int num_workers= mi->rli->slave_parallel_workers;
     if (num_workers > 1)
     {
-      *appliers_id= (long*) my_malloc(PSI_NOT_INSTRUMENTED,
-                                      num_workers * sizeof(long),
-                                      MYF(MY_WME));
+      *appliers_id=
+          (unsigned long*) my_malloc(PSI_NOT_INSTRUMENTED,
+                                     num_workers * sizeof(unsigned long),
+                                     MYF(MY_WME));
 
       for (int i = 0; i < num_workers; i++)
       {
@@ -469,9 +471,9 @@ int channel_get_appliers_thread_id(const char* channel, long** appliers_id)
     {
       if (mi->rli->info_thd != NULL)
       {
-        *appliers_id= (long*) my_malloc(PSI_NOT_INSTRUMENTED,
-                                        sizeof(long),
-                                        MYF(MY_WME));
+        *appliers_id= (unsigned long*) my_malloc(PSI_NOT_INSTRUMENTED,
+                                                 sizeof(unsigned long),
+                                                 MYF(MY_WME));
         mysql_mutex_lock(&mi->rli->info_thd_lock);
         **appliers_id= mi->rli->info_thd->thread_id();
         mysql_mutex_unlock(&mi->rli->info_thd_lock);

sql/rpl_channel_service_interface.h

@@ -204,7 +204,8 @@ bool channel_is_active(const char* channel, enum_channel_thread_types type);
     @retval <=0  the channel does no exists, or the applier is not present
     @retval >0 the number of applier ids returned.
 */
-int channel_get_appliers_thread_id(const char* channel, long** appliers_id);
+int channel_get_appliers_thread_id(const char* channel,
+                                   unsigned long** appliers_id);
 
 /**
   Returns last GNO from applier from a given UUID.