Fix recently introduced Clang build warnings:

-Winconsistent-missing-override
-Winconsistent-missing-destructor-override
-Wconditional-uninitialized

Change-Id: Ia5fa42acfcc219360a5f3b3e93bf6bf230a31dfd

Author: jhauglid

sql/binlog.cc

@@ -243,7 +243,7 @@ bool normalize_binlog_name(char *to, const char *from, bool is_relay_log) {
  */
 class MYSQL_BIN_LOG::Binlog_ofile : public Basic_ostream {
  public:
-  ~Binlog_ofile() {
+  ~Binlog_ofile() override {
     DBUG_ENTER("Binlog_ofile::~Binlog_ofile");
     close();
     DBUG_VOID_RETURN;
@@ -7411,7 +7411,7 @@ int MYSQL_BIN_LOG::open_binlog(const char *opt_name) {
     Log_event *ev = 0;
     char log_name[FN_REFLEN];
     my_off_t valid_pos = 0;
-    my_off_t binlog_size;
+    my_off_t binlog_size = 0;
 
     do {
       strmake(log_name, log_info.log_file_name, sizeof(log_name) - 1);

sql/binlog_istream.h

@@ -108,7 +108,7 @@ class Binlog_read_error {
 */
 class Binlog_encryption_istream : public Basic_seekable_istream {
  public:
-  virtual ~Binlog_encryption_istream();
+  ~Binlog_encryption_istream() override;
 
   /**
     Initialize the context used in the decryption stream.

sql/binlog_ostream.h

@@ -207,7 +207,7 @@ class Binlog_cache_storage : public Basic_ostream {
 */
 class Binlog_encryption_ostream : public Truncatable_ostream {
  public:
-  ~Binlog_encryption_ostream();
+  ~Binlog_encryption_ostream() override;
 
   /**
     Initialize the context used in the encryption stream and write encryption

sql/item.h

@@ -3655,7 +3655,7 @@ class Item_param final : public Item, private Settable_routine_parameter {
   /** Item is a argument to a limit clause. */
   bool limit_clause_param;
   void set_param_type_and_swap_value(Item_param *from);
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   /**
     This should be called after any modification done to this Item, to
     propagate the said modification to all its clones.
@@ -4636,7 +4636,7 @@ class Item_ref : public Item_ident {
 
   bool repoint_const_outer_ref(uchar *arg) override;
   bool contains_alias_of_expr(uchar *arg) override;
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   bool check_function_as_value_generator(uchar *args) override {
     Check_function_as_value_generator_parameters *func_arg =
         pointer_cast<Check_function_as_value_generator_parameters *>(args);
@@ -5586,7 +5586,7 @@ class Item_cache : public Item_basic_constant {
   bool is_null() override {
     return value_cached ? null_value : example->is_null();
   }
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   bool check_function_as_value_generator(uchar *args) override {
     Check_function_as_value_generator_parameters *func_arg =
         pointer_cast<Check_function_as_value_generator_parameters *>(args);

sql/item_func.h

@@ -606,7 +606,7 @@ class Item_func : public Item_result_field {
     @return true if the function item can have named parameters
   */
   virtual bool may_have_named_parameters() const { return false; }
-  virtual bool is_non_const_over_literals(uchar *) { return false; }
+  virtual bool is_non_const_over_literals(uchar *) override { return false; }
 
   bool check_function_as_value_generator(uchar *args) override {
     if (is_deprecated()) {
@@ -2041,7 +2041,7 @@ class Item_func_get_lock final : public Item_int_func {
     maybe_null = true;
     return false;
   }
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   bool check_function_as_value_generator(uchar *args) override {
     Check_function_as_value_generator_parameters *func_arg =
         pointer_cast<Check_function_as_value_generator_parameters *>(args);
@@ -2067,7 +2067,7 @@ class Item_func_release_lock final : public Item_int_func {
     maybe_null = true;
     return false;
   }
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   bool check_function_as_value_generator(uchar *args) override {
     Check_function_as_value_generator_parameters *func_arg =
         pointer_cast<Check_function_as_value_generator_parameters *>(args);
@@ -2090,7 +2090,7 @@ class Item_func_release_all_locks final : public Item_int_func {
     unsigned_flag = true;
     return false;
   }
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   bool check_function_as_value_generator(uchar *args) override {
     Check_function_as_value_generator_parameters *func_arg =
         pointer_cast<Check_function_as_value_generator_parameters *>(args);
@@ -3043,7 +3043,7 @@ class Item_func_get_user_var : public Item_var_func,
     select @t1:=1,@t1,@t:="hello",@t from foo where (@t1:= t2.b)
   */
   const char *func_name() const override { return "get_user_var"; }
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   bool eq(const Item *item, bool binary_cmp) const override;
 
  private:
@@ -3158,7 +3158,7 @@ class Item_func_get_system_var final : public Item_var_func {
   bool resolve_type(THD *) override;
   void print(String *str, enum_query_type query_type) override;
   table_map used_tables() const override { return 0; }
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   enum Item_result result_type() const override;
   double val_real() override;
   longlong val_int() override;
@@ -3467,7 +3467,7 @@ class Item_func_is_free_lock final : public Item_int_func {
     maybe_null = true;
     return false;
   }
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   bool check_function_as_value_generator(uchar *args) override {
     Check_function_as_value_generator_parameters *func_arg =
         pointer_cast<Check_function_as_value_generator_parameters *>(args);
@@ -3492,7 +3492,7 @@ class Item_func_is_used_lock final : public Item_int_func {
     maybe_null = true;
     return false;
   }
-  bool is_non_const_over_literals(uchar *) { return true; }
+  bool is_non_const_over_literals(uchar *) override { return true; }
   bool check_function_as_value_generator(uchar *args) override {
     Check_function_as_value_generator_parameters *func_arg =
         pointer_cast<Check_function_as_value_generator_parameters *>(args);

sql/rpl_log_encryption.h

@@ -480,7 +480,7 @@ extern Rpl_encryption rpl_encryption;
 */
 class Rpl_cipher {
  public:
-  virtual ~Rpl_cipher(){};
+  virtual ~Rpl_cipher() {}
 
   /**
     Open the cipher with given password.
@@ -805,7 +805,7 @@ class Rpl_encryption_header_v1 : public Rpl_encryption_header {
 
   Rpl_encryption_header_v1() = default;
 
-  virtual ~Rpl_encryption_header_v1();
+  ~Rpl_encryption_header_v1() override;
 
   bool serialize(Basic_ostream *ostream) override;
   bool deserialize(Basic_istream *istream) override;
@@ -867,7 +867,7 @@ class Aes_ctr_cipher : public Rpl_cipher {
   static const int AES_BLOCK_SIZE = 16;
   static const int FILE_KEY_LENGTH = 32;
 
-  virtual ~Aes_ctr_cipher();
+  ~Aes_ctr_cipher() override;
 
   bool open(const Key_string &password, int header_size) override;
   void close() override;