Bug#34239456: Assertion '!thd->is_error()' failed in MySQL 8.0.29

Problem was a missing error return when processing an invalid ORDER BY
expression in a view definition. Fixed by adding an error return.

Change-Id: I5a89cb3dbb986863dfb70e10a5b303b0631a1f8d

Author: roylyseng

mysql-test/r/view.result

@@ -6808,3 +6808,17 @@ id	select_type	table	partitions	type	possible_keys	key	key_len	ref	rows	filtered
 Warnings:
 Note	1003	/* select#1 */ select `test`.`t1`.`pk` AS `foo`,`test`.`t1`.`col_int_key` AS `bar` from `test`.`t1`
 DROP TABLE t1;
+# Bug#34239456: Assertion '!thd->is_error()' failed in MySQL 8.0.29
+CREATE TABLE t0 (c0 INTEGER, c1 INTEGER);
+CREATE VIEW v0 AS
+SELECT c0
+FROM t0
+WHERE c1 = (SELECT 1
+UNION
+SELECT c0 FROM t0
+ORDER BY c1
+);
+SELECT * FROM v0;
+ERROR 42000: Table 't0' from one of the SELECTs cannot be used in global ORDER clause
+DROP VIEW v0;
+DROP TABLE t0;

mysql-test/t/view.test

@@ -6311,3 +6311,22 @@ DROP VIEW v1;
 EXPLAIN SELECT pk AS foo, col_int_key AS bar FROM t1;
 
 DROP TABLE t1;
+
+--echo # Bug#34239456: Assertion '!thd->is_error()' failed in MySQL 8.0.29
+
+CREATE TABLE t0 (c0 INTEGER, c1 INTEGER);
+
+CREATE VIEW v0 AS
+SELECT c0
+FROM t0
+WHERE c1 = (SELECT 1
+            UNION
+            SELECT c0 FROM t0
+            ORDER BY c1
+           );
+
+--error ER_TABLENAME_NOT_ALLOWED_HERE
+SELECT * FROM v0;
+
+DROP VIEW v0;
+DROP TABLE t0;

sql/parse_tree_items.cc

@@ -393,6 +393,7 @@ bool PTI_simple_ident_q_3d::itemize(Parse_context *pc, Item **res) {
                                                                    : db;
   if (pc->select->no_table_names_allowed) {
     my_error(ER_TABLENAME_NOT_ALLOWED_HERE, MYF(0), table, thd->where);
+    return true;
   }
   if ((pc->select->parsing_place != CTX_HAVING) ||
       (pc->select->get_in_sum_expr() > 0)) {