WL#10475 : Defaults: Enable Parallel Replication Applier

This worklog enbles parallel replication applier by enabling the 3 options by default :

Server Changes:
slave-parallel-type = LOGICAL_CLOCK : Enables the optimal generic parallelism
method.
slave-parallel-workers = 4 : Offers a good base level of parallelism.
slave-preserve-commit-order = ON : Ensures no user/application visible changes
in behavior.

User Override
slave-parallel-workers = 0 : disables parallel slave applier execution and
causes the other two options to be ignored

Author: Deepthi ES

mysql-test/collections/default.daily

@@ -47,8 +47,10 @@ perl mysql-test-run.pl --timer --force  --comment=memcached --vardir=var-memcach
 # MTR or mysqld options in this section
 
 # Additional modes for rpl. Multi-Threaded Slave
-perl mysql-test-run.pl --timer  --force --parallel=auto --comment=rpl_MTS_db_part --vardir=var-mts-rpl_db --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --mysqld=--slave-parallel-type=database --do-suite=rpl --no-skip
-perl mysql-test-run.pl --timer  --force --parallel=auto --comment=rpl_MTS_LC --vardir=var-mts-rpl_LC --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --mysqld=--slave-parallel-type=logical_clock --do-suite=rpl --no-skip
+perl mysql-test-run.pl --debug-server --timer  --force --parallel=auto --comment=rpl_MTS_db_part --vardir=var-mts-rpl_db --experimental=collections/default.experimental --mysqld=--slave-parallel-type=database --mysqld=--slave-preserve-commit-order=OFF --do-suite=rpl --no-skip
+
+# Additional mode for rpl. Single-Threaded Slave
+perl mysql-test-run.pl --debug-server --timer  --force --parallel=auto --comment=rpl_STS --vardir=var-rpl_sts --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=0 --do-suite=rpl --no-skip
 
 # Additional GTID coverage (rpl suite with gtid_mode=ON)
 perl mysql-test-run.pl --force --timer  --parallel=auto --experimental=collections/default.experimental --comment=rpl_with_gtid --vardir=var-rpl_gtid --suite=rpl --mysqld=--enforce-gtid-consistency --mysqld=--gtid-mode=on --no-skip

mysql-test/collections/default.weekly

@@ -48,9 +48,11 @@ perl mysql-test-run.pl --debug-server --timer --force  --comment=memcached --var
 # Add runs of rpl and binlog test suites with additional
 # MTR or mysqld options in this section
 
-# Additional modes for rpl. Multi-Threaded Slave
-perl mysql-test-run.pl --debug-server --timer  --force --parallel=auto --comment=rpl_MTS_db_part --vardir=var-mts-rpl_db --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --mysqld=--slave-parallel-type=database --do-suite=rpl --no-skip
-perl mysql-test-run.pl --debug-server --timer  --force --parallel=auto --comment=rpl_MTS_LC --vardir=var-mts-rpl_LC --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --mysqld=--slave-parallel-type=logical_clock --do-suite=rpl --no-skip
+# Additional mode for rpl. Multi-Threaded Slave
+perl mysql-test-run.pl --debug-server --timer  --force --parallel=auto --comment=rpl_MTS_db_part --vardir=var-mts-rpl_db --experimental=collections/default.experimental --mysqld=--slave-preserve-commit-order=OFF --mysqld=--slave-parallel-type=database --do-suite=rpl --no-skip
+
+# Additional mode for rpl. Single-Threaded Slave
+perl mysql-test-run.pl --debug-server --timer  --force --parallel=auto --comment=rpl_STS --vardir=var-rpl-sts --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=0 --do-suite=rpl --no-skip
 
 # Additional GTID coverage (rpl suite with gtid_mode=ON)
 perl mysql-test-run.pl --debug-server --force --timer  --parallel=auto --experimental=collections/default.experimental --comment=rpl_with_gtid --vardir=var-rpl_gtid --suite=rpl --mysqld=--enforce-gtid-consistency --mysqld=--gtid-mode=on --no-skip
@@ -125,14 +127,14 @@ perl mysql-test-run.pl --force --debug-server --timer --parallel=auto --experime
 perl mysql-test-run.pl --force --debug-server --timer --parallel=auto --experimental=collections/default.experimental --comment=binlog_row_hash_scan --vardir=var-binlog_row_hash_scan --mysqld=--binlog-format=row --do-suite=binlog --mysqld=--slave-rows-search-algorithms=HASH_SCAN,INDEX_SCAN --big-test --testcase-timeout=60  --no-skip
 perl mysql-test-run.pl --debug-server --timer --force --parallel=auto --comment=rpl_row_hash_MTS --vardir=var-mts-rpl-hash-n_mix --mysqld=--binlog-format=row --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --do-suite=rpl --mysqld=--slave-rows-search-algorithms=HASH_SCAN,INDEX_SCAN --no-skip
 perl mysql-test-run.pl --debug-server --timer --force --parallel=auto --comment=binlog_row_hash_MTS --vardir=var-mts-binlog-hash-n_mix --mysqld=--binlog-format=row --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --do-suite=binlog --mysqld=--slave-rows-search-algorithms=HASH_SCAN,INDEX_SCAN --no-skip
-perl mysql-test-run.pl --debug-server --timer --force --parallel=auto --comment=binlog_row_table_MTS --vardir=var-mts-binlog-table-n_mix --mysqld=--binlog-format=row --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --do-suite=binlog --mysqld=--slave-rows-search-algorithms=TABLE_SCAN,INDEX_SCAN --no-skip 
-perl mysql-test-run.pl --debug-server --timer --force --parallel=auto --comment=rpl_row_table_MTS --vardir=var-mts-rpl-table-n_mix --mysqld=--binlog-format=row --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --do-suite=rpl --mysqld=--slave-rows-search-algorithms=TABLE_SCAN,INDEX_SCAN --no-skip 
+perl mysql-test-run.pl --debug-server --timer --force --parallel=auto --comment=binlog_row_table_STS --vardir=var-sts-binlog-table-n_mix --mysqld=--binlog-format=row --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=0 --do-suite=binlog --mysqld=--slave-rows-search-algorithms=TABLE_SCAN,INDEX_SCAN --no-skip
+perl mysql-test-run.pl --debug-server --timer --force --parallel=auto --comment=rpl_row_table_STS --vardir=var-sts-rpl-table-n_mix --mysqld=--binlog-format=row --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=0 --do-suite=rpl --mysqld=--slave-rows-search-algorithms=TABLE_SCAN,INDEX_SCAN --no-skip
 
 perl mysql-test-run.pl --force --debug-server --timer --parallel=auto --experimental=collections/default.experimental --comment=binlog_row_table_scan --vardir=var-binlog_row_table_scan --mysqld=--binlog-format=row --do-suite=binlog --mysqld=--slave-rows-search-algorithms=TABLE_SCAN,INDEX_SCAN --big-test --testcase-timeout=60  --no-skip
 perl mysql-test-run.pl --force --debug-server --timer --parallel=auto --experimental=collections/default.experimental --comment=rpl_row_table_scan --vardir=var-rpl_row_table_scan --mysqld=--binlog-format=row --do-suite=rpl --mysqld=--slave-rows-search-algorithms=TABLE_SCAN,INDEX_SCAN --big-test --testcase-timeout=60  --no-skip
 
-# binlog-transaction-dependency-tracking=WRITESET with MTS slave-parellel-type=logical-clock
-perl mysql-test-run.pl --timer --force --big-test --testcase-timeout=60 --debug-server --parallel=auto --comment=rpl_MTS-lc-binlog-txn-dependency-tracking --vardir=var-rpl-MTS-lc-binlog-txn-dependency-tracking --do-suite=rpl  --experimental=collections/default.experimental --mysqld=--binlog-format=row --mysqld=--slave-parallel-workers=4 --mysqld=--slave-parallel-type=logical_clock  --no-skip --mysqld=--binlog-transaction-dependency-tracking=WRITESET
+# binlog-transaction-dependency-tracking=WRITESET with MTS
+perl mysql-test-run.pl --timer --force --big-test --testcase-timeout=60 --debug-server --parallel=auto --comment=rpl-binlog-txn-dependency-tracking --vardir=var-rpl-binlog-txn-dependency-tracking --do-suite=rpl  --experimental=collections/default.experimental --mysqld=--binlog-format=row --no-skip --mysqld=--binlog-transaction-dependency-tracking=WRITESET
 
 # Rpl suite with Transaction-writeset-extraction disabled
 perl mysql-test-run.pl --force --timer  --parallel=auto --experimental=collections/default.experimental --comment=rpl_without_txn_write_set_extraction --vardir=var-rpl_txn_write_set_extraction_disabled --suite=rpl,rpl_gtid,rpl_nogtid  --mysqld=--transaction-write-set-extraction=OFF --no-skip

mysql-test/collections/mysql-trunk-stage.push

@@ -20,8 +20,8 @@ perl mysql-test-run.pl --timer --force --parallel=auto --comment=innodb_undo-2-d
 # Run innodb suites with innodb_undo_table_spaces >0  and different pagesizes
 perl mysql-test-run.pl --timer  --force --parallel=auto --comment=innodb_undo_5_64k --vardir=var-innodb-undo-5-64k --experimental=collections/default.experimental --suite=innodb_undo,innodb_zip,innodb --mysqld=--innodb_undo_tablespaces=5 --mysqld=--innodb-page-size=64k --no-skip --max-test-fail=30
 
-# Additional modes for rpl. Multi-Threaded Slave
-perl mysql-test-run.pl --timer  --force --parallel=auto --comment=rpl_binlog_n_mix_MTS --vardir=var-mts-rpl-binlog-n_mix --mysqld=--binlog-format=mixed --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=4 --suite=rpl,rpl_gtid,rpl_nogtid --skip-test=rpl_incompatible_gtids_in_relay_log --no-skip --max-test-fail=30
+# Additional modes for rpl. Single-Threaded Slave
+perl mysql-test-run.pl --timer  --force --parallel=auto --comment=rpl_binlog_n_mix_STS --vardir=var-sts-rpl-binlog-n_mix --mysqld=--binlog-format=mixed --experimental=collections/default.experimental --mysqld=--slave-parallel-workers=0 --suite=rpl,rpl_gtid,rpl_nogtid --no-skip --max-test-fail=30
 
 # Run the suites that are not part of the default - funcs_2, stress, jp, nist
 perl mysql-test-run.pl --force --timer --testcase-timeout=60   --parallel=auto --experimental=collections/default.experimental --comment=funcs2  --vardir=var-funcs2 --suite=funcs_2 --no-skip --max-test-fail=30

mysql-test/extra/rpl_tests/rpl_row_001.test

@@ -53,8 +53,11 @@ eval CREATE TABLE t1 (n INT) ENGINE=$engine_type;
 sync_slave_with_master;
 connection master;
 RESET MASTER;
+
 connection slave;
-STOP SLAVE;
+--let $wait_condition=SELECT COUNT(*)=0 from t1
+--source include/wait_condition_or_abort.inc
+--source include/stop_slave.inc
 RESET SLAVE;
 
 connection master;
@@ -68,22 +71,29 @@ while ($1)
 }
 enable_query_log;
 SELECT COUNT(*) FROM t1;
-save_master_pos;
+--source include/save_master_pos.inc
 
 # Try to cause a large relay log lag on the slave by locking t1
 connection slave;
 RESET MASTER;
 LOCK TABLES t1 READ;
-START SLAVE;
+
+--source include/start_slave.inc
+--source include/sync_slave_io.inc
+
 UNLOCK TABLES;
-sync_with_master;
+--let $wait_condition= SELECT count(*) = 0 FROM INFORMATION_SCHEMA.PROCESSLIST WHERE State = 'Waiting for table metadata lock'
+--source include/wait_condition.inc
+# In valgrind sync a large workload might take long when MTS is enabled
+--let $slave_timeout= 1200
+--source include/sync_slave_sql_with_io.inc
 SELECT COUNT(*) FROM t1;
 
 connection master;
 DROP TABLE t1;
 CREATE TABLE t1 (n INT);
 INSERT INTO t1 VALUES(3456);
-sync_slave_with_master;
+--source include/sync_slave_sql_with_master.inc
 SELECT n FROM t1;
 
 connection master;
@@ -96,4 +106,4 @@ DROP TABLE t1;
 --enable_query_log
 --echo # mysql.user table restored to original values.
 
-sync_slave_with_master;
+--source include/sync_slave_sql_with_master.inc

mysql-test/include/persist_only_variables.sql

@@ -45,7 +45,7 @@ set @@persist_only.innodb_sort_buffer_size=1048576;
 set @@persist_only.innodb_sync_array_size=1;
 set @@persist_only.innodb_use_native_aio=1;
 set @@persist_only.innodb_write_io_threads=4;
-set @@persist_only.log_slave_updates=0;
+set @@persist_only.log_slave_updates=1;
 set @@persist_only.max_digest_length=1024;
 set @@persist_only.metadata_locks_cache_size=1024;
 set @@persist_only.metadata_locks_hash_instances=8;

mysql-test/include/show_events.inc

@@ -38,7 +38,8 @@ if ($binlog_file)
   {
     if ($is_relay_log)
     {
-      --let $_binlog_file= query_get_value(SHOW SLAVE STATUS, Relay_Log_File, 1)
+      --source include/rpl_get_end_of_relay_log.inc
+      --let $_binlog_file= $relay_log_file
     }
     if (!$is_relay_log)
     {

mysql-test/r/mysqld--help-notwin.result

@@ -1125,7 +1125,7 @@ The following options may be given as the first argument:
  --slave-parallel-type=name 
  Specifies if the slave will use database partitioning or
  information from master to parallelize
- transactions.(Default: DATABASE).
+ transactions.(Default: LOGICAL_CLOCK).
  --slave-parallel-workers=# 
  Number of worker threads for executing events in parallel
  --slave-pending-jobs-size-max=# 
@@ -1134,7 +1134,8 @@ The following options may be given as the first argument:
  master side max_allowed_packet.
  --slave-preserve-commit-order 
  Force slave workers to make commits in the same order as
- on the master. Disabled by default.
+ on the master. Enabled by default.
+ (Defaults to on; use --skip-slave-preserve-commit-order to disable.)
  --slave-rows-search-algorithms=name 
  Set of searching algorithms that the slave will use while
  searching for records from the storage engine to either
@@ -1586,10 +1587,10 @@ slave-compressed-protocol FALSE
 slave-exec-mode STRICT
 slave-max-allowed-packet 1073741824
 slave-net-timeout 60
-slave-parallel-type DATABASE
-slave-parallel-workers 0
+slave-parallel-type LOGICAL_CLOCK
+slave-parallel-workers 4
 slave-pending-jobs-size-max 16777216
-slave-preserve-commit-order FALSE
+slave-preserve-commit-order TRUE
 slave-rows-search-algorithms INDEX_SCAN,HASH_SCAN
 slave-skip-errors (No default value)
 slave-sql-verify-checksum TRUE

mysql-test/r/mysqld--help-win.result

@@ -447,8 +447,8 @@ The following options may be given as the first argument:
  --log-short-format  Don't log extra information to update and slow-query
  logs.
  --log-slave-updates Tells the slave to log the updates from the slave thread
- to the binary log. You will need to turn it on if you
- plan to daisy-chain the slaves
+ to the binary log.
+ (Defaults to on; use --skip-log-slave-updates to disable.)
  --log-slow-admin-statements 
  Log slow OPTIMIZE, ANALYZE, ALTER and other
  administrative statements to the slow log if it is open.
@@ -1118,7 +1118,7 @@ The following options may be given as the first argument:
  --slave-parallel-type=name 
  Specifies if the slave will use database partitioning or
  information from master to parallelize
- transactions.(Default: DATABASE).
+ transactions.(Default: LOGICAL_CLOCK).
  --slave-parallel-workers=# 
  Number of worker threads for executing events in parallel
  --slave-pending-jobs-size-max=# 
@@ -1127,7 +1127,8 @@ The following options may be given as the first argument:
  master side max_allowed_packet.
  --slave-preserve-commit-order 
  Force slave workers to make commits in the same order as
- on the master. Disabled by default.
+ on the master. Enabled by default.
+ (Defaults to on; use --skip-slave-preserve-commit-order to disable.)
  --slave-rows-search-algorithms=name 
  Set of searching algorithms that the slave will use while
  searching for records from the storage engine to either
@@ -1395,7 +1396,7 @@ log-output FILE
 log-queries-not-using-indexes FALSE
 log-raw FALSE
 log-short-format FALSE
-log-slave-updates FALSE
+log-slave-updates TRUE
 log-slow-admin-statements FALSE
 log-slow-slave-statements FALSE
 log-statements-unsafe-for-binlog TRUE
@@ -1583,10 +1584,10 @@ slave-compressed-protocol FALSE
 slave-exec-mode STRICT
 slave-max-allowed-packet 1073741824
 slave-net-timeout 60
-slave-parallel-type DATABASE
-slave-parallel-workers 0
+slave-parallel-type LOGICAL_CLOCK
+slave-parallel-workers 4
 slave-pending-jobs-size-max 16777216
-slave-preserve-commit-order FALSE
+slave-preserve-commit-order TRUE
 slave-rows-search-algorithms INDEX_SCAN,HASH_SCAN
 slave-skip-errors (No default value)
 slave-sql-verify-checksum TRUE