Bug #32433090 RUN CLANG-TIDY MODERNIZE-USE-EQUALS-DEFAULT OVER THE CODE BASE

Use run-clang-tidy.py -fix -checks='-*,modernize-use-equals-default'

This check replaces default bodies of special member functions with = default;

The explicitly defaulted function declarations enable more
opportunities in optimization, because the compiler might treat
explicitly defaulted functions as trivial.

Performance changes, as measured by sysbench with default argumens,
are in the noise area. A small improvement for PGO/LTO builds.

With gcc10, mysqld is about 14 MB smaller with ' = default;'
constructors and destructors.

A few manual fixes were applied to the clang-tidy result:

Fixes for -Werror=unused-parameter
-cs::apply::Commit_order_queue::Iterator::Iterator(const Iterator &rhs)
+cs::apply::Commit_order_queue::Iterator::Iterator(const Iterator &)

-cs::apply::Commit_order_queue::Iterator::operator=(const Iterator &rhs) = default;
+cs::apply::Commit_order_queue::Iterator::operator=(const Iterator &) = default;

Revert some of the changes done by clang-tidy, such as

error: use of deleted function
SortingIterator::IteratorHolder::~IteratorHolder()

router/src/harness/include/mysql/harness/stdx/expected.h:111:3: note:
stdx::base::storage_t<T, E>::storage_t()
[with T = const char*; E = std::error_code]
is implicitly deleted because the default definition would be ill-formed:
  111 |   storage_t() = default;

The reverted changes have been tagged with
// NOLINT(modernize-use-equals-default)
or
// NOLINTNEXTLINE(modernize-use-equals-default)
to prevent clang-tidy to try to fix them later.

The DTOR Item::~Item() was rewritten manually.
The body contained an ifdef, so clang-tidy would not rewrite it.

Other CTORs/DTORs could also be rewritten, e.g. Rsegs() and ~Rsegs() in InnoDB.

Change-Id: I0457e799464119d1f4042589f404dd4b172440e8

Author: Tor Didriksen

client/base/abstract_program.cc

@@ -90,7 +90,7 @@ void Abstract_program::run(int argc, char **argv) {
   exit(result);
 }
 
-Abstract_program::~Abstract_program() {}
+Abstract_program::~Abstract_program() = default;
 
 void Abstract_program::init_name(char *name_from_cmd_line) {
 #ifdef _WIN32

client/base/i_connection_factory.h

@@ -37,7 +37,7 @@ namespace Base {
  */
 class I_connection_factory {
  public:
-  virtual ~I_connection_factory() {}
+  virtual ~I_connection_factory() = default;
 
   /**
     Provides new connection to MySQL database server.

client/base/i_option.cc

@@ -28,4 +28,4 @@ using namespace Mysql::Tools::Base::Options;
 
 uint32 I_option::last_optid = 256;
 
-I_option::~I_option() {}
+I_option::~I_option() = default;

client/base/i_option_changed_listener.h

@@ -39,7 +39,7 @@ namespace Options {
  */
 class I_option_changed_listener {
  public:
-  virtual ~I_option_changed_listener() {}
+  virtual ~I_option_changed_listener() = default;
 
   /**
     Called after specified option has name changed.

client/base/message_data.h

@@ -48,7 +48,7 @@ enum Message_type {
 class Message_data {
  public:
   Message_data(uint64 code, std::string message, Message_type message_type);
-  virtual ~Message_data() {}
+  virtual ~Message_data() = default;
   uint64 get_code() const;
   std::string get_message() const;
   Message_type get_message_type() const;

client/base/number_option.h

@@ -51,7 +51,7 @@ class Number_option
 };
 
 template <typename T_value>
-Number_option<T_value>::Number_option() {}
+Number_option<T_value>::Number_option() = default;
 
 /**
   32-bit signed number option.

client/client_query_attributes.h

@@ -29,7 +29,7 @@
 
 class client_query_attributes {
  public:
-  client_query_attributes() {}
+  client_query_attributes() = default;
   ~client_query_attributes() { clear(); }
   bool push_param(char *name, char *value);
   int set_params(MYSQL *mysql);

client/dump/abstract_data_object.cc

@@ -36,4 +36,4 @@ std::string Abstract_data_object::get_schema() const { return m_schema; }
 
 uint64 Abstract_data_object::get_id() const { return m_id; }
 
-Abstract_data_object::~Abstract_data_object() {}
+Abstract_data_object::~Abstract_data_object() = default;

client/dump/abstract_dump_task.cc

@@ -32,7 +32,7 @@ using namespace Mysql::Tools::Dump;
 Abstract_dump_task::Abstract_dump_task(Abstract_data_object *related_object)
     : m_related_object(related_object) {}
 
-Abstract_dump_task::~Abstract_dump_task() {}
+Abstract_dump_task::~Abstract_dump_task() = default;
 
 I_data_object *Abstract_dump_task::get_related_db_object() const {
   return m_related_object;

client/dump/abstract_simple_dump_task.cc

@@ -30,7 +30,7 @@ void Abstract_simple_dump_task::set_completed() { m_is_completed = true; }
 
 bool Abstract_simple_dump_task::is_completed() const { return m_is_completed; }
 
-Abstract_simple_dump_task::~Abstract_simple_dump_task() {}
+Abstract_simple_dump_task::~Abstract_simple_dump_task() = default;
 
 Abstract_simple_dump_task::Abstract_simple_dump_task()
     : m_is_completed(false) {}

client/dump/i_chain_element.cc

@@ -26,4 +26,4 @@
 
 using namespace Mysql::Tools::Dump;
 
-I_chain_element::~I_chain_element() {}
+I_chain_element::~I_chain_element() = default;

client/dump/i_connection_provider.h

@@ -36,7 +36,7 @@ namespace Dump {
 
 class I_connection_provider {
  public:
-  virtual ~I_connection_provider() {}
+  virtual ~I_connection_provider() = default;
   virtual Mysql::Tools::Base::Mysql_query_runner *get_runner(
       std::function<bool(const Mysql::Tools::Base::Message_data &)>
           *message_handler) = 0;

client/dump/i_data_formatter_wrapper.h

@@ -36,7 +36,7 @@ namespace Dump {
  */
 class I_data_formatter_wrapper {
  public:
-  virtual ~I_data_formatter_wrapper() {}
+  virtual ~I_data_formatter_wrapper() = default;
   /**
   Add new Data Formatter to supply acquired data of objects to.
   */

client/dump/i_data_object.h

@@ -31,7 +31,7 @@ namespace Dump {
 
 class I_data_object {
  public:
-  virtual ~I_data_object() {}
+  virtual ~I_data_object() = default;
 };
 
 }  // namespace Dump

client/dump/i_dump_task.cc

@@ -26,4 +26,4 @@
 
 using namespace Mysql::Tools::Dump;
 
-I_dump_task::~I_dump_task() {}
+I_dump_task::~I_dump_task() = default;

client/dump/i_object_reader_wrapper.h

@@ -36,7 +36,7 @@ namespace Dump {
  */
 class I_object_reader_wrapper {
  public:
-  virtual ~I_object_reader_wrapper() {}
+  virtual ~I_object_reader_wrapper() = default;
   /**
     Add new Object Reader to supply direct execution of dump tasks to.
    */

client/dump/i_output_writer_wrapper.h

@@ -36,7 +36,7 @@ namespace Dump {
  */
 class I_output_writer_wrapper {
  public:
-  virtual ~I_output_writer_wrapper() {}
+  virtual ~I_output_writer_wrapper() = default;
   /**
     Add new Output Writer to supply formatted strings to.
    */

client/dump/i_progress_reporter.cc

@@ -26,4 +26,4 @@
 
 using namespace Mysql::Tools::Dump;
 
-I_progress_reporter::~I_progress_reporter() {}
+I_progress_reporter::~I_progress_reporter() = default;

client/dump/pattern_matcher.cc

@@ -26,7 +26,7 @@
 
 using namespace Mysql::Tools::Dump::Detail;
 
-Pattern_matcher::Pattern_matcher() {}
+Pattern_matcher::Pattern_matcher() = default;
 
 bool Pattern_matcher::is_pattern_matched(const std::string &to_match,
                                          const std::string &pattern,

client/mysql_ssl_rsa_setup.cc

@@ -226,7 +226,7 @@ class RSA_priv {
  public:
   RSA_priv(uint32_t key_size = 2048) : m_key_size(key_size) {}
 
-  ~RSA_priv() {}
+  ~RSA_priv() = default;
 
   Sql_string_t operator()(const Sql_string_t &key_file) {
     stringstream command;
@@ -281,7 +281,7 @@ class X509v3_ext_writer {
 
     m_certv3_ext_options << "basicConstraints=CA:FALSE" << std::endl;
   }
-  ~X509v3_ext_writer() {}
+  ~X509v3_ext_writer() = default;
 
   bool operator()(const Sql_string_t &cav3_ext_file,
                   const Sql_string_t &certv3_ext_file) {
@@ -314,7 +314,7 @@ class X509_cert {
  public:
   X509_cert(uint32_t validity = 10 * 365L) : m_validity(validity) {}
 
-  ~X509_cert() {}
+  ~X509_cert() = default;
 
   Sql_string_t operator()(const Sql_string_t &req_file,
                           const Sql_string_t &cert_file, uint32_t serial,

client/mysqlbinlog.cc

@@ -852,7 +852,7 @@ class Load_log_processor {
 
  public:
   Load_log_processor() : file_names() {}
-  ~Load_log_processor() {}
+  ~Load_log_processor() = default;
 
   void init_by_dir_name(const char *dir) {
     target_dir_name_len =

client/mysqltest/expected_errors.h

@@ -37,8 +37,8 @@ class Expected_errors {
  public:
   typedef std::vector<std::unique_ptr<Error>>::iterator iterator;
 
-  Expected_errors() {}
-  ~Expected_errors() {}
+  Expected_errors() = default;
+  ~Expected_errors() = default;
 
   iterator begin() { return m_errors.begin(); }
   iterator end() { return m_errors.end(); }

client/mysqltest/expected_warnings.h

@@ -35,8 +35,8 @@ class Expected_warnings {
  public:
   typedef std::vector<std::unique_ptr<Warning>>::iterator iterator;
 
-  Expected_warnings() {}
-  ~Expected_warnings() {}
+  Expected_warnings() = default;
+  ~Expected_warnings() = default;
 
   iterator begin() { return m_warnings.begin(); }
   iterator end() { return m_warnings.end(); }

client/mysqltest/secondary_engine.h

@@ -30,8 +30,8 @@
 
 class Secondary_engine {
  public:
-  Secondary_engine() {}
-  ~Secondary_engine() {}
+  Secondary_engine() = default;
+  ~Secondary_engine() = default;
 
   /// Get the secondary engine execution count value.
   ///

client/path.cc

@@ -36,7 +36,7 @@
 #include <pwd.h>
 #endif
 
-Path::Path() {}
+Path::Path() = default;
 
 Path::Path(const std::string &s) { path(s); }
 

components/audit_api_message_emit/audit_api_message_emit.cc

@@ -68,7 +68,7 @@ class IError_handler {
   /**
     Virtual destructor.
   */
-  virtual ~IError_handler() {}
+  virtual ~IError_handler() = default;
   /**
     Error reporting method.
 

components/keyrings/common/data/data.cc

@@ -47,13 +47,7 @@ Data::Data(Data &&src) noexcept {
 }
 
 /* Assignment operator */
-Data &Data::operator=(const Data &src) {
-  data_ = src.data_;
-  type_ = src.type_;
-  valid_ = src.valid_;
-
-  return *this;
-}
+Data &Data::operator=(const Data &src) = default;
 
 Data &Data::operator=(Data &&src) noexcept {
   std::swap(src.data_, data_);

components/keyrings/common/data/meta.cc

@@ -51,14 +51,7 @@ Metadata::Metadata(Metadata &&src) noexcept {
 }
 
 /** Assignment operator */
-Metadata &Metadata::operator=(const Metadata &src) {
-  key_id_ = src.key_id_;
-  owner_id_ = src.owner_id_;
-  hash_key_ = src.hash_key_;
-  valid_ = src.valid_;
-
-  return *this;
-}
+Metadata &Metadata::operator=(const Metadata &src) = default;
 
 Metadata &Metadata::operator=(Metadata &&src) noexcept {
   std::swap(src.key_id_, key_id_);

components/keyrings/common/data_file/writer.h

@@ -34,7 +34,7 @@ class File_writer final {
               bool backup_exists = false);
 
   /* Destructor */
-  ~File_writer() {}
+  ~File_writer() = default;
 
   /* Validity */
   bool valid() const { return valid_; }

components/keyrings/common/encryption/aes.h

@@ -63,7 +63,7 @@ class Aes_operation_context final {
  public:
   Aes_operation_context(const std::string data_id, const std::string auth_id,
                         const std::string mode, size_t block_size);
-  ~Aes_operation_context() {}
+  ~Aes_operation_context() = default;
   const std::string data_id() const { return data_id_; }
   const std::string auth_id() const { return auth_id_; }
   Keyring_aes_opmode opmode() const { return opmode_; }

components/keyrings/common/json_data/json_ds.h

@@ -32,9 +32,9 @@ namespace json_data {
 /* Base class for data extensions */
 class Json_data_extension {
  public:
-  Json_data_extension() {}
+  Json_data_extension() = default;
   virtual std::string version() { return std::string{"1.0"}; }
-  virtual ~Json_data_extension() {}
+  virtual ~Json_data_extension() = default;
 };
 
 }  // namespace json_data

components/keyrings/common/json_data/json_reader.h

@@ -77,7 +77,7 @@ class Json_reader {
   Json_reader();
 
   /** Destructor */
-  virtual ~Json_reader() {}
+  virtual ~Json_reader() = default;
 
   std::string version() const;
 

components/keyrings/common/json_data/json_writer.h

@@ -47,7 +47,7 @@ class Json_writer {
               const std::string array_key = "elements");
 
   /** Destructor */
-  virtual ~Json_writer() {}
+  virtual ~Json_writer() = default;
 
   bool set_data(const std::string data);
 

components/keyrings/common/memstore/cache.h

@@ -49,7 +49,7 @@ class Datacache final {
   Datacache &operator=(Datacache &&src) = delete;
 
   /** Destructor */
-  ~Datacache() {}
+  ~Datacache() = default;
 
   /**
     Retrieve an element from cache

components/keyrings/common/operations/operations.h

@@ -493,7 +493,7 @@ class Keyring_operations {
     load_cache();
   }
 
-  ~Keyring_operations() {}
+  ~Keyring_operations() = default;
 
   /**
     Insert API to populate cache

components/keyrings/keyring_file/backend/backend.h

@@ -36,7 +36,7 @@ class Keyring_file_backend final {
   explicit Keyring_file_backend(const std::string keyring_file_name,
                                 bool read_only);
 
-  ~Keyring_file_backend() {}
+  ~Keyring_file_backend() = default;
 
   /**
     Fetch data

components/libminchassis/my_metadata.cc

@@ -22,9 +22,9 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA */
 
 #include "components/libminchassis/my_metadata.h"
 
-my_metadata::my_metadata() {}
+my_metadata::my_metadata() = default;
 
-my_metadata::my_metadata(my_metadata &other) : data(other.data) {}
+my_metadata::my_metadata(my_metadata &) = default;
 
 my_metadata::const_iterator::const_iterator(
     my_unordered_string_to_string_map::const_iterator iter,

components/libminchassis/my_ref_counted.cc

@@ -30,7 +30,7 @@ my_ref_counted::my_ref_counted(my_ref_counted &other)
     : m_count(other.m_count.load()) {}
 
 /* virtual destructor */
-my_ref_counted::~my_ref_counted() {}
+my_ref_counted::~my_ref_counted() = default;
 
 /**
   Increases a reference count.

components/libminchassis/mysql_service_implementation.cc

@@ -45,12 +45,9 @@ mysql_service_implementation::mysql_service_implementation(
 }
 
 mysql_service_implementation::mysql_service_implementation(
-    mysql_service_implementation &other)
-    : my_ref_counted(other),
-      my_metadata(other),
-      m_interface(other.m_interface),
-      m_service(other.m_service),
-      m_full_name(other.m_full_name) {}
+    mysql_service_implementation &)
+
+    = default;
 
 /**
   Gets service name that is implemented by this service implementation.