Bug #26696147: REMOVE MY_SNPRINTF

Remove my_snprintf, replacing it with C++11 snprintf everywhere. Fix a myriad
of compiler warnings uncovered as a result, several of them real bugs.

The old (non-standard) behavior of %s was to stop at the first invalid UTF-8
codepoint.  While useful in specific situations, it was also confusing in
others (using e.g. a binary string as INTEGER would print out an empty string,
instead of showing that there was data in the string), and thus has been
replaced with showing question marks for invalid UTF-8.

Change-Id: Ica316ff9d32053c6dc018037cd0d1645ab319d45

Author: Steinar H. Gunderson

client/mysql.cc

@@ -37,6 +37,7 @@
 #include <math.h>
 #include <signal.h>
 #include <stdarg.h>
+#include <stdio.h>
 #include <stdlib.h>
 #include <sys/types.h>
 #include <time.h>
@@ -54,7 +55,6 @@
 #include "my_io.h"
 #include "my_loglevel.h"
 #include "my_macros.h"
-#include "mysql/service_my_snprintf.h"
 #include "prealloced_array.h"
 #include "typelib.h"
 #include "violite.h"
@@ -1358,7 +1358,7 @@ int main(int argc,char *argv[])
 
   put_info("Welcome to the MySQL monitor.  Commands end with ; or \\g.",
 	   INFO_INFO);
-  my_snprintf((char*) glob_buffer.ptr(), glob_buffer.alloced_length(),
+  snprintf((char*) glob_buffer.ptr(), glob_buffer.alloced_length(),
 	   "Your MySQL connection id is %lu\nServer version: %s\n",
 	   mysql_thread_id(&mysql), server_version_string(&mysql));
   put_info((char*) glob_buffer.ptr(),INFO_INFO);
@@ -3226,7 +3226,7 @@ void free_hist_patterns()
 
 void add_syslog(const char *line) {
   char buff[MAX_SYSLOG_MESSAGE_SIZE];
-  my_snprintf(buff, sizeof(buff), "SYSTEM_USER:'%s', MYSQL_USER:'%s', "
+  snprintf(buff, sizeof(buff), "SYSTEM_USER:'%s', MYSQL_USER:'%s', "
               "CONNECTION_ID:%lu, DB_SERVER:'%s', DB:'%s', QUERY:'%s'",
               /* use the cached user/sudo_user value. */
               current_os_sudouser ? current_os_sudouser :
@@ -4775,7 +4775,7 @@ com_use(String *buffer MY_ATTRIBUTE((unused)), char *line)
 
   if (0 < (warnings= mysql_warning_count(&mysql)))
   {
-    my_snprintf(buff, sizeof(buff),
+    snprintf(buff, sizeof(buff),
                 "Database changed, %u warning%s", warnings,
                 warnings > 1 ? "s" : "");
     put_info(buff, INFO_INFO);

client/mysql_secure_installation.cc

@@ -15,6 +15,7 @@
    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301  USA
 */
 
+#include <stdio.h>
 #include <stdlib.h>
 #include <sys/types.h>
 
@@ -25,7 +26,6 @@
 #include "my_inttypes.h"
 #include "my_macros.h"
 #include "my_shm_defaults.h"
-#include "mysql/service_my_snprintf.h"
 #include "mysql/service_mysql_alloc.h"
 #include "mysqld_error.h"
 #include "print_version.h"
@@ -624,7 +624,7 @@ static int get_opt_user_password()
       else
       {
         char prompt[128];
-        my_snprintf(prompt, sizeof(prompt) - 1,
+        snprintf(prompt, sizeof(prompt) - 1,
                     "Enter password for user %s: ", opt_user);
         // Request password from user
         password= get_tty_password(prompt);
@@ -977,7 +977,7 @@ int main(int argc,char *argv[])
     if (plugin_set == 1)
       estimate_password_strength(password);
 
-    my_snprintf(prompt, sizeof(prompt) - 1, 
+    snprintf(prompt, sizeof(prompt) - 1, 
                 "Change the password for %s ? ((Press y|Y "
                 "for Yes, any other key for No) : ", opt_user);
     reply= get_response(prompt, 'n');

client/mysqlbinlog.cc

@@ -33,6 +33,7 @@
 #include <fcntl.h>
 #include <signal.h>
 #include <stdarg.h>
+#include <stdio.h>
 #include <stdlib.h>
 #include <time.h>
 #include <algorithm>
@@ -47,7 +48,6 @@
 #include "my_io.h"
 #include "my_macros.h"
 #include "my_time.h"
-#include "mysql/service_my_snprintf.h"
 #include "prealloced_array.h"
 #include "print_version.h"
 #include "sql/log_event.h"
@@ -2383,7 +2383,7 @@ static Exit_status dump_remote_log_entries(PRINT_EVENT_INFO *print_event_info,
         {
           if (output_file != 0)
           {
-            my_snprintf(log_file_name, sizeof(log_file_name), "%s%s",
+            snprintf(log_file_name, sizeof(log_file_name), "%s%s",
                         output_file, rev->new_log_ident);
           }
           else