BUG#16533802: START SLAVE FAILS WITH TABLE REPOSITORY AND AUTOCOMMIT = 0

Fix for BUG 16533802 included changes on clean_info() method from
info tables management, after BUG 17286858 (CHANGE_MASTER() INVOKES
HA_INNOBASE::TRUNCATE() IN A DML TRANSACTION) fix those changes are
not needed anymore, so this patch removes the unneeded changes.

Author: nacarvalho

sql/rpl_info_table.cc

@@ -290,7 +290,7 @@ int Rpl_info_table::do_clean_info()
   /*
     Unlocks and closes the rpl_info table.
   */
-  access->close_table(thd, table, &backup, error, true);
+  access->close_table(thd, table, &backup, error);
   reenable_binlog(thd);
   thd->variables.sql_mode= saved_mode;
   access->drop_thd(thd);

sql/rpl_info_table_access.cc

@@ -130,8 +130,6 @@ bool Rpl_info_table_access::open_table(THD* thd, const LEX_STRING dbstr,
   @param[in] backup Restore the lock info from here
   @param[in] error  If there was an error while updating
                     the table
-  @param[in] force_commit force "real" commit (with ha_commit_trans()
-                          all parameter set to TRUE)
 
   If there is an error, rolls back the current statement. Otherwise,
   commits it. However, if a new thread was created and there is an
@@ -146,7 +144,7 @@ bool Rpl_info_table_access::open_table(THD* thd, const LEX_STRING dbstr,
 */
 bool Rpl_info_table_access::close_table(THD *thd, TABLE* table,
                                         Open_tables_backup *backup,
-                                        bool error, bool force_commit)
+                                        bool error)
 {
   Query_tables_list query_tables_list_backup;
 
@@ -164,7 +162,7 @@ bool Rpl_info_table_access::close_table(THD *thd, TABLE* table,
        */
       ha_commit_trans(thd, FALSE, TRUE);
     }
-    if (saved_current_thd != current_thd || force_commit)
+    if (saved_current_thd != current_thd)
     {
       if (error)
         ha_rollback_trans(thd, TRUE);

sql/rpl_info_table_access.h

@@ -35,7 +35,7 @@ class Rpl_info_table_access
                   uint max_num_field, enum thr_lock_type lock_type,
                   TABLE** table, Open_tables_backup* backup);
   bool close_table(THD* thd, TABLE* table, Open_tables_backup* backup,
-                   bool error, bool force_commit= false);
+                   bool error);
   enum enum_return_id find_info(Rpl_info_values *field_values, TABLE *table);
   enum enum_return_id scan_info(TABLE *table, uint instance);
   bool count_info(TABLE *table, uint* counter);