WL#12899 : Remove slave-rows-search-algorithms

This worklog will remove the system variable `slave-rows-search-algorithms`

Change-Id: Ic8264bce904d1102c90eb83cbb48ea78cdeef264

Author: Arpit Goswami

mysql-test/collections/default.weekly

@@ -152,12 +152,6 @@ perl mysql-test-run.pl --timer  --force  --comment=innodb_sync_debug --testcase-
 #
 ####SECTION 7 RPL/BINLOG EXTENDED-WEEKLY#############
 #
-# Additional run to test rpl TABLE_SCAN & INDEX_SCAN
-#
-perl mysql-test-run.pl --force --debug-server --timer   --comment=rpl_row_table_scan --vardir=var-rpl_row_table_scan --mysqld=--binlog-format=row --do-suite=rpl --mysqld=--slave-rows-search-algorithms=TABLE_SCAN,INDEX_SCAN --big-test --testcase-timeout=60  --no-skip
-
-perl mysql-test-run.pl --debug-server --timer --force  --comment=rpl_row_table_STA --vardir=var-sta-rpl-table-n_mix --mysqld=--binlog-format=row  --mysqld=--replica-parallel-workers=0 --do-suite=rpl --mysqld=--slave-rows-search-algorithms=TABLE_SCAN,INDEX_SCAN --no-skip
-
 # binlog-transaction-dependency-tracking=COMMIT_ORDER with replica-parallel-workers=4 (default) and replica-parallel-type=logical_clock (default)
 perl mysql-test-run.pl --timer --force --no-skip --testcase-timeout=60 --debug-server --comment=rpl-mta-trx-dependency-tracking-commit-order --vardir=var-rpl-mta-trx-dependency-tracking-commit-order --do-suite=rpl --mysqld=--binlog-format=row --mysqld=--binlog-transaction-dependency-tracking=COMMIT_ORDER
 

mysql-test/extra/rpl_tests/rpl_row_jsondiff_exit.inc

@@ -12,13 +12,4 @@ let $rpl_sql=
 --delimiter ;
 --source include/rpl_for_each_server_stmt.inc
 
-if ($replace_combination_from)
-{
-  # To avoid an error 'ER_RUNNING_APPLIER_PREVENTS_SWITCH_GLOBAL_BINLOG_FORMAT',
-  # which will be caused by the following include/end_replace_combination.inc.
-  --source include/rpl_stop_slaves.inc
-  --source include/end_replace_combination.inc
-  --source include/rpl_start_slaves.inc
-}
-
 --source include/rpl_end.inc

mysql-test/extra/rpl_tests/rpl_row_jsondiff_init.inc

@@ -51,18 +51,12 @@
 #   Since NOBLOB is similar to MINIMAL for JSON columns, we consider
 #   NOBLOB tested due to having tested MINIMAL.
 #
-# - All the above should hold when:
-#
-#   - slave_rows_search_algorithms=HASH_SCAN/TABLE_SCAN with and
-#     without a primary key
-#
-#   - slave_rows_search_algorithms=INDEX_SCAN with a primary key.
+#   All the above should hold when the table has a primary key so it
+#   uses INDEX_SCAN and when the table has no primary key so it uses
+#   HASH_SCAN.
 #
 # ==== Usage ====
 #
-# [--let $replace_combination_from= SCOPE.VARIABLE=VALUE[,VALUE[,...]]
-# [--let $replace_combination_to= SCOPE.VARIABLE=VALUE[,VALUE[,...]]
-# --source include/rpl_row_jsondiff_init.inc
 #
 # [set $variables to describe a scenario]
 # --source rpl_row_jsondiff_scenario.inc
@@ -74,13 +68,6 @@
 #
 # --source include/rpl_row_jsondiff_exit.inc
 #
-# Parameters:
-#   $replace_combination_from, $replace_combination_to
-#     If set, this script will source
-#     include/begin_replace_combination.inc just after
-#     include/rpl_init.inc, and rpl_row_jsondiff_exit.inc will source
-#     include/end_replace_combination just before include/rpl_end.inc.
-#     See include/begin_replace_combination.inc for details.
 #
 # ==== Implementation ====
 #
@@ -113,16 +100,6 @@
 --source include/rpl_init.inc
 --source include/rpl_default_connections.inc
 
-if ($replace_combination_from)
-{
-  --let $replace_combination_on_all_servers= 1
-  # To avoid an error 'ER_RUNNING_APPLIER_PREVENTS_SWITCH_GLOBAL_BINLOG_FORMAT',
-  # which will be caused by the following include/begin_replace_combination.inc.
-  --source include/rpl_stop_slaves.inc
-  --source include/begin_replace_combination.inc
-  --source include/rpl_start_slaves.inc
-}
-
 
 --echo ######## INITIALIZE ########
 

mysql-test/include/begin_replace_combination.inc

@@ -215,7 +215,7 @@ not_mts_replica_parallel_workers.inc
 only_replica_preserve_commit_order.inc
 # 14.2 rpl misc files
 have_default_replica_transaction_retries.inc
-have_default_slave_rows_search_algorithms.inc
+
 
 #14.3 Some replication tests cannot run with GTID_ONLY == 1
 not_rpl_gtid_only.inc

mysql-test/include/end_replace_combination.inc

@@ -46,17 +46,17 @@ include/assert.inc [Expect 500+ variables in the table. Due to open Bugs, we are
 
 # Test SET PERSIST
 
-include/assert.inc [Expect 445 persisted variables in the table.]
+include/assert.inc [Expect 444 persisted variables in the table.]
 
 ************************************************************
 * 3. Restart server, it must preserve the persisted variable
 *    settings. Verify persisted configuration.
 ************************************************************
 # restart
 
-include/assert.inc [Expect 445 persisted variables in persisted_variables table.]
-include/assert.inc [Expect 445 persisted variables shown as PERSISTED in variables_info table.]
-include/assert.inc [Expect 445 persisted variables with matching peristed and global values.]
+include/assert.inc [Expect 444 persisted variables in persisted_variables table.]
+include/assert.inc [Expect 444 persisted variables shown as PERSISTED in variables_info table.]
+include/assert.inc [Expect 444 persisted variables with matching peristed and global values.]
 
 ************************************************************
 * 4. Test RESET PERSIST IF EXISTS. Verify persisted variable

mysql-test/include/excludenoskip.list

@@ -1421,13 +1421,6 @@ The following options may be given as the first argument:
  This option is deprecated. Use
  replica_preserve_commit_order instead.
  (Defaults to on; use --skip-slave-preserve-commit-order to disable.)
- --slave-rows-search-algorithms=name 
- The set of algorithms used by the replication applier
- while searching the table for rows to update or delete.
- Possible values are: INDEX_SCAN, TABLE_SCAN and
- HASH_SCAN. Any combination is allowed, and the applier
- picks the most efficient among them for any given
- scenario. (Default: INDEX_SCAN, HASH_SCAN).
  --slave-skip-errors=name 
  This option is deprecated. Use replica_skip_errors
  instead.
@@ -1994,7 +1987,6 @@ slave-parallel-type LOGICAL_CLOCK
 slave-parallel-workers 4
 slave-pending-jobs-size-max 134217728
 slave-preserve-commit-order TRUE
-slave-rows-search-algorithms INDEX_SCAN,HASH_SCAN
 slave-skip-errors (No default value)
 slave-sql-verify-checksum TRUE
 slave-transaction-retries 10

mysql-test/include/have_default_slave_rows_search_algorithms.inc

@@ -1427,13 +1427,6 @@ The following options may be given as the first argument:
  This option is deprecated. Use
  replica_preserve_commit_order instead.
  (Defaults to on; use --skip-slave-preserve-commit-order to disable.)
- --slave-rows-search-algorithms=name 
- The set of algorithms used by the replication applier
- while searching the table for rows to update or delete.
- Possible values are: INDEX_SCAN, TABLE_SCAN and
- HASH_SCAN. Any combination is allowed, and the applier
- picks the most efficient among them for any given
- scenario. (Default: INDEX_SCAN, HASH_SCAN).
  --slave-skip-errors=name 
  This option is deprecated. Use replica_skip_errors
  instead.
@@ -2008,7 +2001,6 @@ slave-parallel-type LOGICAL_CLOCK
 slave-parallel-workers 4
 slave-pending-jobs-size-max 134217728
 slave-preserve-commit-order TRUE
-slave-rows-search-algorithms INDEX_SCAN,HASH_SCAN
 slave-skip-errors (No default value)
 slave-sql-verify-checksum TRUE
 slave-transaction-retries 10

mysql-test/r/all_persisted_variables.result

@@ -47,7 +47,7 @@ INSERT INTO aliases(name) VALUES
 ('slave_parallel_workers'), ('slave_pending_jobs_size_max'),
 ('pseudo_slave_mode'), ('skip_slave_start');
 
-include/assert.inc [Expect 110 variables in the table.]
+include/assert.inc [Expect 109 variables in the table.]
 
 # Test SET PERSIST_ONLY
 SET PERSIST_ONLY binlog_cache_size = @@GLOBAL.binlog_cache_size;
@@ -231,10 +231,6 @@ SET PERSIST_ONLY slave_preserve_commit_order = @@GLOBAL.slave_preserve_commit_or
 Warnings:
 Warning	1287	'@@slave_preserve_commit_order' is deprecated and will be removed in a future release. Please use replica_preserve_commit_order instead.
 Warning	1287	'@@slave_preserve_commit_order' is deprecated and will be removed in a future release. Please use replica_preserve_commit_order instead.
-SET PERSIST_ONLY slave_rows_search_algorithms = @@GLOBAL.slave_rows_search_algorithms;
-Warnings:
-Warning	1287	'@@slave_rows_search_algorithms' is deprecated and will be removed in a future release.
-Warning	1287	'@@slave_rows_search_algorithms' is deprecated and will be removed in a future release.
 SET PERSIST_ONLY slave_skip_errors = @@GLOBAL.slave_skip_errors;
 Warnings:
 Warning	1287	'@@slave_skip_errors' is deprecated and will be removed in a future release. Please use replica_skip_errors instead.
@@ -269,16 +265,16 @@ Warning	1287	'@@sync_relay_log_info' is deprecated and will be removed in a futu
 Warning	1287	'@@sync_relay_log_info' is deprecated and will be removed in a future release.
 SET PERSIST_ONLY sync_source_info = @@GLOBAL.sync_source_info;
 
-include/assert.inc [Expect 99 persisted variables in persisted_variables table.]
+include/assert.inc [Expect 98 persisted variables in persisted_variables table.]
 
 ############################################################
 # 2. Restart server, it must preserve the persisted variable
 #    settings. Verify persisted configuration.
 # restart
 
-include/assert.inc [Expect 99 persisted variables in persisted_variables table.]
-include/assert.inc [Expect 99 persisted variables shown as PERSISTED in variables_info table.]
-include/assert.inc [Expect 99 persisted variables with matching persisted and global values.]
+include/assert.inc [Expect 98 persisted variables in persisted_variables table.]
+include/assert.inc [Expect 98 persisted variables shown as PERSISTED in variables_info table.]
+include/assert.inc [Expect 98 persisted variables with matching persisted and global values.]
 
 ############################################################
 # 3. Test RESET PERSIST. Verify persisted variable settings
@@ -372,7 +368,6 @@ RESET PERSIST rpl_semi_sync_source_wait_point;
 RESET PERSIST rpl_stop_replica_timeout;
 RESET PERSIST session_track_gtids;
 RESET PERSIST skip_replica_start;
-RESET PERSIST slave_rows_search_algorithms;
 RESET PERSIST source_verify_checksum;
 RESET PERSIST sql_replica_skip_counter;
 RESET PERSIST sync_binlog;