Bug#34278103 Compile MySQL with GCC 13 [noclose]

Fix warnings reported by gcc (GCC) 13.0.0 20230108 (experimental)

Add a few missing #includes

-Werror=dangling-reference

-Werror=format-truncation=

Warnings in router code also reported by gcc12.
-Werror=maybe-uninitialized { new (&error_) error_type(e); }

Change-Id: Ib769605ea766c0e5adf1219c57ae918c19f5b494

Author: Tor Didriksen

plugin/test_service_sql_api/test_sql_cmds_1.cc

@@ -40,7 +40,7 @@
 #include "template_utils.h"
 #include "thr_cond.h"
 
-#define STRING_BUFFER 1024
+static constexpr int STRING_BUFFER = 1024 * 4;
 
 static const char *sep =
     "======================================================\n";

plugin/test_service_sql_api/test_sql_reset_connection.cc

@@ -42,7 +42,7 @@
 #include "mysql_com.h"
 #include "template_utils.h"
 
-#define STRING_BUFFER 256
+static constexpr int STRING_BUFFER = 256 * 2;
 
 static File outfile;
 

router/src/connection_pool/include/mysqlrouter/connection_pool_component.h

@@ -27,6 +27,7 @@
 
 #include <memory>  // shared_ptr
 #include <mutex>
+#include <string>
 #include <unordered_map>
 #include <vector>
 

router/src/harness/include/mysql/harness/stdx/expected.h

@@ -208,7 +208,7 @@ union storage_t {
 
  private:
   value_type value_;
-  error_type error_;
+  error_type error_{};
 };
 
 /**
@@ -247,7 +247,7 @@ union storage_t<void, E> {
   constexpr error_type &&error() && { return std::move(error_); }
 
  private:
-  error_type error_;
+  error_type error_{};
 };
 
 // member_policy to disable implicit constructors and assignment operations

router/src/mysql_protocol/include/mysqlrouter/classic_protocol_message.h

@@ -276,6 +276,7 @@ class Eof : public Ok {
  */
 class Error {
  public:
+  Error() = default;
   /**
    * construct an Error message.
    *
@@ -294,7 +295,7 @@ class Error {
   std::string message() const { return message_; }
 
  private:
-  uint16_t error_code_;
+  uint16_t error_code_{0};
   std::string message_;
   std::string sql_state_;
 };

router/src/router/include/mysqlrouter/mysql_session.h

@@ -45,6 +45,7 @@ namespace mysqlrouter {
 
 class MysqlError {
  public:
+  MysqlError() = default;
   MysqlError(unsigned int code, std::string message, std::string sql_state)
       : code_{code},
         message_{std::move(message)},
@@ -57,7 +58,7 @@ class MysqlError {
   unsigned int value() const { return code_; }
 
  private:
-  unsigned int code_;
+  unsigned int code_{0};
   std::string message_;
   std::string sql_state_;
 };

router/src/routing/tests/mysql_client.h

@@ -35,6 +35,7 @@
 
 class MysqlError {
  public:
+  MysqlError() = default;
   MysqlError(unsigned int code, std::string message, std::string sql_state)
       : code_{code},
         message_{std::move(message)},
@@ -47,7 +48,7 @@ class MysqlError {
   unsigned int value() const { return code_; }
 
  private:
-  unsigned int code_;
+  unsigned int code_{0};
   std::string message_;
   std::string sql_state_;
 };

unittest/gunit/CMakeLists.txt

@@ -197,6 +197,14 @@ SET(TESTS
   varlen_sort
   )
 
+# TODO(tdidriks) fix
+# error: static assertion failed:
+# allocator_traits<A>::rebind_alloc<A::value_type> must be A
+# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=72792
+IF(MY_COMPILER_IS_GNU AND CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 13)
+  LIST(REMOVE_ITEM TESTS stl_alloc)
+ENDIF()
+
 SET(ALL_SMALL_TESTS)
 FOREACH(test ${TESTS})
   LIST(APPEND ALL_SMALL_TESTS ${test}-t.cc)