WL#10956 Binlog Storage Access API - Step1 Output Stream

Output stream means a place(object) where bytes data can be written into.
- Basic_ostream
  It is the basic output stream interface, which only defines write()
  operation for writing bytes into somewhere.

  Basic_ostream interface is used in below functions of Log_event class and
  its children classes to replace IO_CACHE.
  - Log_event::write_header(Basic_ostream ostream, ...)
  - Log_event::write_footer(Basic_ostream ostream)
  - Log_event::write_data_header(Basic_ostream ostream)
  - Log_event::write_data_body(Basic_ostream ostream)
  - Log_event::write(Basic_ostream *ostream)
  and a few other write functions as well.

  With this change, binary events could be written anywhere we want.
  Below classes derives from Basic_ostream and implement the interface.
  - class Binlog_cache
  - class Binlog_ofile
  - class StringBuffer_ostream
  - class Transaction_message

  So binary events could be written into binlog cache or binary log directly.
  They also could be written into a memory buffer(StringBuffer_ostream) or
  a group replication Transaction_message.

  Because of StringBuffer_ostream and Transaction_message, Some IO_CACHEs and
  a IO_CACHE list(IO_CACHE_unused_list) is able removed from group replication
  code.

- Binlog_ofile
  It defines a logical binlog file which wraps and hides the real storage
  layer operations. It provides the operations for controlling binlog files,
  like open, close, write, flush etc. When opening Binlog_file, it initializes
  the real storage. When writing an event to Binlog_file, it writes the
  event into the real storage. MYSQL_BIN_LOG code operates on a plain binlogs.
  It doesn't need to know/care the detail of low level storage
  operates(e.g. if it is encrypted or not).

It derives from Basic_ostream, so events can be written into it directly.

- Binlog_cache
  It defines a binlog cache container for store binlog events.
  It provides a few elegant interfaces for writing or reading binlog events
  into or from the container. It hides the detail of level storage details
  which binlog code doesn't need to know.

It is derived from Basic_ostream, So we can pass it as argument to
  Xxx_log_evnet::write() for writing events into binlog cache.

Author: Libing Song

include/mysql/group_replication_priv.h

@@ -1,4 +1,4 @@
-/* Copyright (c) 2015, 2017, Oracle and/or its affiliates. All rights reserved.
+/* Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License, version 2.0,
@@ -29,6 +29,7 @@
 
 #include "my_sys.h"
 #include "my_thread.h"
+#include "sql/binlog_ostream.h"
 #include "sql/debug_sync.h"
 #include "sql/log_event.h"
 #include "sql/replication.h"

libbinlogevents/include/binlog_event.h

@@ -613,12 +613,7 @@ class Log_event_header {
   /*
     The offset in the log where this event originally appeared (it is
     preserved in relay logs, making SHOW SLAVE STATUS able to print
-    coordinates of the event in the master's binlog). Note: when a
-    transaction is written by the master to its binlog (wrapped in
-    BEGIN/COMMIT) the log_pos of all the queries it contains is the
-    one of the BEGIN (this way, when one does SHOW SLAVE STATUS it
-    sees the offset of the BEGIN, which is logical as rollback may
-    occur), except the COMMIT query which has its real offset.
+    coordinates of the event in the master's binlog).
   */
   unsigned long long log_pos;
 

mysql-test/suite/binlog/r/binlog_cache_write_failure.result

@@ -1,65 +1,88 @@
 call mtr.add_suppression("An error occurred during flush stage of the commit");
 call mtr.add_suppression("Attempting backtrace. You can use the following information to find out*");
+call mtr.add_suppression(".*Error writing file.*");
 RESET MASTER;
-CREATE TABLE t1(i INT);
+CREATE TABLE t1(c1 varchar(8192));
+CREATE TABLE t2(c1 varchar(8192));
+CREATE TABLE t3(c1 varchar(8192));
+SET GLOBAL binlog_cache_size = 4096;
 
-# Case 1 (binlog_error_action = ABORT_SERVER)
-
-SET GLOBAL binlog_error_action = ABORT_SERVER;
-
-# Case 1.1  CLIENT DISCONNECTION
+# Case 1 Simulate my_b_flush_io_cache failure when truncating binlog
+#        cache. ROLLBACK TO triggers binlog cache truncation process.
+include/save_binlog_position.inc
 BEGIN;
-INSERT INTO t1 VALUES (1);
-SET SESSION debug= "+d,simulate_tmpdir_partition_full";
-INSERT INTO t1 VALUES (2);
-INSERT INTO t1 VALUES (3);
-ERROR HY000: Error writing file <tmp_file_name> (Errcode: ##)
-SET SESSION debug= "-d,simulate_tmpdir_partition_full";
+INSERT INTO t1 VALUES (repeat('a', 2048));
+SAVEPOINT sp1;
+INSERT INTO t2 VALUES (repeat('a', 4096));
+INSERT INTO t3 VALUES (repeat('b', 4096));
+SET SESSION debug = "+d,simulate_error_during_flush_cache_to_file";
+ROLLBACK TO sp1;
+SET SESSION debug = "-d,simulate_error_during_flush_cache_to_file";
+INSERT INTO t1 VALUES (repeat('c', 8192));
+COMMIT;
+include/show_binlog_events.inc
+Log_name	Pos	Event_type	Server_id	End_log_pos	Info
+binlog.000001	#	Query	#	#	BEGIN
+binlog.000001	#	Table_map	#	#	table_id: # (test.t1)
+binlog.000001	#	Write_rows	#	#	table_id: # flags: STMT_END_F
+binlog.000001	#	Query	#	#	SAVEPOINT `sp1`
+binlog.000001	#	Table_map	#	#	table_id: # (test.t1)
+binlog.000001	#	Write_rows	#	#	table_id: # flags: STMT_END_F
+binlog.000001	#	Xid	#	#	COMMIT /* XID */
 
-# Case 1.2 ROLLBACK
+# Case 2 Simulate my_b_flush_io_cache failure when reseting binlog cache
+#        in ROLLBACK statement
 BEGIN;
-INSERT INTO t1 VALUES (1);
-SET SESSION debug= "+d,simulate_tmpdir_partition_full";
-INSERT INTO t1 VALUES (2);
-INSERT INTO t1 VALUES (3);
-ERROR HY000: Error writing file <tmp_file_name> (Errcode: ##)
+INSERT INTO t1 VALUES (repeat('a', 8192));
+SET SESSION debug = "+d,simulate_error_during_flush_cache_to_file";
 ROLLBACK;
-SET SESSION debug= "-d,simulate_tmpdir_partition_full";
+SET SESSION debug = "-d,simulate_error_during_flush_cache_to_file";
 
-# Case 1.3 COMMIT
+# Case 3 CLIENT DISCONNECT. it is same to ROLLBACK
 BEGIN;
-INSERT INTO t1 VALUES (1);
-SET SESSION debug= "+d,simulate_tmpdir_partition_full";
-INSERT INTO t1 VALUES (2);
-INSERT INTO t1 VALUES (3);
-ERROR HY000: Error writing file <tmp_file_name> (Errcode: ##)
-COMMIT;
-ERROR HY000: Binary logging not possible. Message: An error occurred during flush stage of the commit. 'binlog_error_action' is set to 'ABORT_SERVER'. Hence aborting the server.
-include/assert_grep.inc [An error occurred during flush stage of the commit. 'binlog_error_action' is set to 'ABORT_SERVER'.]
-include/assert.inc [Count of elements in t1 should be 0.]
-include/assert.inc [Query is not binlogged as expected.]
-TRUNCATE TABLE t1;
-
-# Case 2 (binlog_error_action = IGNORE_ERROR)
+INSERT INTO t1 VALUES (repeat('a', 8192));
+SET SESSION debug = "+d,simulate_error_during_flush_cache_to_file";
 
-RESET MASTER;
-SET GLOBAL binlog_error_action= IGNORE_ERROR;
+# Case 4 Simulate write failure when reinitializing binlog cache for
+#        copying to binlog. The error should be ignored and cache
+#        is cleared correctly if binlog_error_action is IGNORE_ERROR
+#
+TRUNCATE t1;
+include/save_binlog_position.inc
+SET GLOBAL binlog_error_action = IGNORE_ERROR;
 BEGIN;
-INSERT INTO t1 VALUES (1);
-SET SESSION debug= "+d,simulate_tmpdir_partition_full";
-INSERT INTO t1 VALUES (2);
-INSERT INTO t1 VALUES (3);
-ERROR HY000: Error writing file <tmp_file_name> (Errcode: ##)
+INSERT INTO t1 VALUES (repeat('a', 8192));
+SET SESSION debug = "+d,simulate_tmpdir_partition_full";
 COMMIT;
 Warnings:
-Error	3	Error writing file MYSQLTEST_VARDIR/tmp/temp_file (Errcode: ##)
-Error	1026	Error writing file MYSQLTEST_VARDIR/tmp/temp_file (Errcode: ##)
-SET SESSION debug= "-d,simulate_tmpdir_partition_full";
-include/assert.inc [Count of elements in t1 should be 2.]
-SHOW BINARY LOGS;
-ERROR HY000: You are not using binary logging
+Error	3	Error writing file <tmp_file_name> (Errcode: ##)
+Error	1026	Error writing file <tmp_file_name> (Errcode: ##)
+SET SESSION debug = "-d,simulate_tmpdir_partition_full";
 include/assert_grep.inc [An error occurred during flush stage of the commit. 'binlog_error_action' is set to 'IGNORE_ERROR'.]
 # restart
-include/assert.inc [Count of elements in t1 should be 2.]
-DROP TABLE t1;
+include/show_binlog_events.inc
+Log_name	Pos	Event_type	Server_id	End_log_pos	Info
+binlog.000001	#	Stop	#	#	
+
+# Case 5 Simulate write failure when reinitializing binlog cache for
+#        copying to binlog with ABORT_SERVER
+#
+SET GLOBAL binlog_cache_size = 4096;
+select @@global.binlog_cache_size;
+@@global.binlog_cache_size
+4096
+TRUNCATE t2;
+include/save_binlog_position.inc
+SET GLOBAL binlog_error_action = ABORT_SERVER;
+BEGIN;
+INSERT INTO t2 VALUES (repeat('b', 8192));
+SET SESSION debug = "+d,simulate_tmpdir_partition_full";
+COMMIT;
+ERROR HY000: Binary logging not possible. Message: An error occurred during flush stage of the commit. 'binlog_error_action' is set to 'ABORT_SERVER'. Hence aborting the server.
+# restart
+select * from t2;
+c1
+include/assert.inc [Count of elements in t2 should be 0.]
+include/show_binlog_events.inc
+DROP TABLE t1, t2, t3;
 RESET MASTER;

mysql-test/suite/binlog/r/binlog_rotate_bgc_sync.result

@@ -1,35 +1,19 @@
 [connection conn1]
-CREATE TABLE t1 (c1 INT) ENGINE=MyISAM;
-SET DEBUG_SYNC= 'before_sync_binlog_file SIGNAL holding_before_bgc_sync_binlog_file WAIT_FOR continue_bgc_sync_binlog_file';
+CREATE TABLE t1 (c1 INT) ENGINE = MyISAM;
+SET DEBUG_SYNC= 'bgc_between_flush_and_sync SIGNAL
+  holding_between_flush_and_sync WAIT_FOR continue_between_flush_and_sync';
 INSERT INTO t1 VALUES (1);
 [connection conn2]
-SET DEBUG_SYNC= 'NOW WAIT_FOR holding_before_bgc_sync_binlog_file';
-SET DEBUG_SYNC= 'before_rotate_binlog_file SIGNAL holding_before_rotate_binlog_file WAIT_FOR continue_rotate_binlog_file';
+SET DEBUG_SYNC= 'now WAIT_FOR holding_between_flush_and_sync';
+SET DEBUG_SYNC= 'binlog_rotate_between_close_and_open SIGNAL
+  holding_between_close_and_open WAIT_FOR continue_rotate_binlog_file';
 FLUSH LOGS;
 [connection default]
-SET DEBUG_SYNC= 'now WAIT_FOR holding_before_rotate_binlog_file';
-SET DEBUG_SYNC= 'now SIGNAL continue_bgc_sync_binlog_file';
-SET DEBUG_SYNC= 'before_rotate_binlog_file CLEAR';
-SET DEBUG_SYNC = 'now SIGNAL continue_rotate_binlog_file';
-[connection conn1]
-[connection conn2]
-[connection default]
-DROP TABLE t1;
-SET DEBUG_SYNC= 'RESET';
+SET DEBUG_SYNC= 'now WAIT_FOR holding_between_close_and_open';
+SET DEBUG_SYNC= 'now SIGNAL continue_between_flush_and_sync';
 [connection conn1]
-CREATE TABLE t1 (c1 INT) ENGINE=InnoDB;
-SET DEBUG_SYNC= 'before_sync_binlog_file SIGNAL holding_before_bgc_sync_binlog_file WAIT_FOR continue_bgc_sync_binlog_file';
-INSERT INTO t1 VALUES (1);
-[connection conn2]
-SET DEBUG_SYNC= 'NOW WAIT_FOR holding_before_bgc_sync_binlog_file';
-SET DEBUG_SYNC= 'before_rotate_binlog_file SIGNAL holding_before_rotate_binlog_file WAIT_FOR continue_rotate_binlog_file';
-FLUSH LOGS;
 [connection default]
-SET DEBUG_SYNC= 'now WAIT_FOR holding_before_rotate_binlog_file';
-SET DEBUG_SYNC= 'now SIGNAL continue_bgc_sync_binlog_file';
-SET DEBUG_SYNC= 'before_rotate_binlog_file CLEAR';
 SET DEBUG_SYNC = 'now SIGNAL continue_rotate_binlog_file';
-[connection conn1]
 [connection conn2]
 [connection default]
 DROP TABLE t1;