WL#13965: Remove binlog_transaction_dependency_tracking

Remove deprecated option `binlog_transaction_dependency_tracking`.
The server will implicitly use the "WRITESET" behavior.

Change-Id: I68226ea5b75890e808e70c83f47eaffe5ae626eb

Author: nacarvalho

mysql-test/collections/default.weekly

@@ -149,14 +149,11 @@ perl mysql-test-run.pl --timer  --force  --comment=innodb_sync_debug --testcase-
 #
 ####SECTION 7 RPL/BINLOG EXTENDED-WEEKLY#############
 #
-# binlog-transaction-dependency-tracking=COMMIT_ORDER with replica-parallel-workers=4 (default) and replica-parallel-type=logical_clock (default)
-perl mysql-test-run.pl --timer --force --no-skip --testcase-timeout=60 --debug-server --comment=rpl-mta-trx-dependency-tracking-commit-order --vardir=var-rpl-mta-trx-dependency-tracking-commit-order --do-suite=rpl --mysqld=--binlog-format=row --mysqld=--binlog-transaction-dependency-tracking=COMMIT_ORDER
-
 # Rpl suite with MTA replica-parallel-type=logical_clock and replica-preserve-commit-order=0
 perl mysql-test-run.pl --debug-server --timer --force --big-test --testcase-timeout=60  --comment=rpl-mta-lc-norpco --vardir=var-rpl-mta-lc-norpco  --mysqld=--replica-parallel-workers=4 --mysqld=--replica-parallel-type=logical_clock --mysqld=--replica-preserve-commit-order=0 --do-suite=rpl --no-skip
 
-# RPL suite + MTS + WRITESET + LOGICAL_CLOCK with binlog compression turned ON.
-perl mysql-test-run.pl --debug-server --timer --force --big-test --testcase-timeout=60 --comment=replication_compression_mts_lc_ws --vardir=var-rpl-comp-mts-lc-ws --mysqld=--replica_parallel_type=LOGICAL_CLOCK --mysqld=--replica_parallel_workers=4 --mysqld=--binlog-format=ROW --mysqld=--binlog-transaction-dependency-tracking=WRITESET --mysqld=--binlog-transaction-compression=ON --do-suite=rpl --no-skip
+# RPL suite + MTS + LOGICAL_CLOCK with binlog compression turned ON.
+perl mysql-test-run.pl --debug-server --timer --force --big-test --testcase-timeout=60 --comment=replication_compression_mts_lc_ws --vardir=var-rpl-comp-mts-lc-ws --mysqld=--replica_parallel_type=LOGICAL_CLOCK --mysqld=--replica_parallel_workers=4 --mysqld=--binlog-format=ROW --mysqld=--binlog-transaction-compression=ON --do-suite=rpl --no-skip
 
 # binlog suite with compression turned on
 perl mysql-test-run.pl --debug-server --timer --force --big-test --testcase-timeout=60 --comment=binlog_compression --vardir=var-binlog-comp --mysqld=--binlog-transaction-compression=ON --suite=binlog,binlog_nogtid,binlog_gtid,i_binlog --mysqld=--binlog-format=ROW --no-skip

mysql-test/extra/rpl_tests/rpl_mts_replica_preserve_commit_order_nobinlog.inc

@@ -143,9 +143,6 @@ if (!$mts_spco_skip_init_statement)
 
   --source include/rpl_connection_master.inc
 
-  SET @save_binlog_transaction_dependency_tracking= @@global.binlog_transaction_dependency_tracking;
-  SET @@global.binlog_transaction_dependency_tracking = COMMIT_ORDER;
-
   --let $mts_spco_skip_init_statement = 1
 }
 
@@ -383,7 +380,6 @@ if ($mts_spco_cleanup_statement)
   --echo
 
   --source include/rpl_connection_master.inc
-  SET GLOBAL binlog_transaction_dependency_tracking=@save_binlog_transaction_dependency_tracking;
   --source include/sync_slave_sql_with_master.inc
 
   --source include/stop_slave.inc

mysql-test/extra/rpl_tests/rpl_mts_spco_acl_commands.test

@@ -57,9 +57,6 @@ SET GLOBAL replica_preserve_commit_order= ON;
 CALL mtr.add_suppression(".*Following users were specified in CREATE USER IF NOT EXISTS but they already exist.*");
 CALL mtr.add_suppression(".*Following users were specified in ALTER USER IF EXISTS but they do not exist.*");
 
-SET @save_binlog_transaction_dependency_tracking= @@global.binlog_transaction_dependency_tracking;
-SET @@global.binlog_transaction_dependency_tracking = COMMIT_ORDER;
-
 # Create tables on source
 CREATE TABLE t1 (c1 INT PRIMARY KEY) ENGINE = InnoDB;
 CREATE TABLE t2 (c1 INT PRIMARY KEY) ENGINE = InnoDB;
@@ -110,7 +107,6 @@ while($j <= $counter)
 --echo
 
 --source include/rpl_connection_master1.inc
-SET GLOBAL binlog_transaction_dependency_tracking=@save_binlog_transaction_dependency_tracking;
 DROP TABLE t1,t2,commands;
 
 --source include/sync_slave_sql_with_master.inc

mysql-test/extra/rpl_tests/rpl_mts_spco_alter_table_commands.test

@@ -57,9 +57,6 @@ SET GLOBAL replica_preserve_commit_order= ON;
 
 --source include/rpl_connection_master1.inc
 
-SET @save_binlog_transaction_dependency_tracking= @@global.binlog_transaction_dependency_tracking;
-SET @@global.binlog_transaction_dependency_tracking = COMMIT_ORDER;
-
 # Create tables on master
 CREATE TABLE t1 (c1 INT PRIMARY KEY) ENGINE = InnoDB;
 CREATE TABLE t2 (c1 INT PRIMARY KEY) ENGINE = InnoDB;
@@ -110,7 +107,6 @@ while($j <= $counter)
 --echo
 
 --source include/rpl_connection_master1.inc
-SET GLOBAL binlog_transaction_dependency_tracking=@save_binlog_transaction_dependency_tracking;
 DROP TABLE t1,t2,commands;
 
 --source include/sync_slave_sql_with_master.inc

mysql-test/extra/rpl_tests/rpl_mts_spco_commands.test

@@ -47,9 +47,6 @@ SET GLOBAL replica_preserve_commit_order= ON;
 
 --source include/rpl_connection_master1.inc
 
-SET @save_binlog_transaction_dependency_tracking= @@global.binlog_transaction_dependency_tracking;
-SET @@global.binlog_transaction_dependency_tracking = COMMIT_ORDER;
-
 --let $tc_count=1
 --echo
 --echo #################################################################
@@ -643,7 +640,6 @@ SET @@global.binlog_transaction_dependency_tracking = COMMIT_ORDER;
 
 --let $tc_count=
 --source include/rpl_connection_master1.inc
-SET GLOBAL binlog_transaction_dependency_tracking=@save_binlog_transaction_dependency_tracking;
 --source include/sync_slave_sql_with_master.inc
 
 --source include/stop_slave.inc

mysql-test/extra/rpl_tests/rpl_mts_spco_partition_commands.test

@@ -45,9 +45,6 @@ SET GLOBAL replica_preserve_commit_order= ON;
 
 --source include/rpl_connection_master1.inc
 
-SET @save_binlog_transaction_dependency_tracking= @@global.binlog_transaction_dependency_tracking;
-SET @@global.binlog_transaction_dependency_tracking = COMMIT_ORDER;
-
 # Create table with subpartitions (HASH and RANGE PARTITION)
 
 CREATE TABLE t_part (i INTEGER) PARTITION BY RANGE(i)
@@ -492,7 +489,6 @@ UNLOCK TABLES;
 --echo
 
 --source include/rpl_connection_master1.inc
-SET GLOBAL binlog_transaction_dependency_tracking=@save_binlog_transaction_dependency_tracking;
 --source include/sync_slave_sql_with_master.inc
 
 --source include/stop_slave.inc

mysql-test/include/excludenoskip.list

@@ -264,13 +264,6 @@ redo_log_archive_05.test
 # 23.0 Tests that do/don't need clone plugin.
 have_clone_plugin.inc
 
-# 24.0 Binlog_transaction_dependency_tracking
-# The below files included because default value of
-# binlog_transaction_dependency_tracking is COMMIT_ORDER and few rpl suite runs
-# with binlog_transaction_dependency_tracking=WRITESET and all the test may not
-# be meant to run on binlog_transaction_dependency_tracking=WRITESET.
-have_binlog_transaction_dependency_tracking_commit_order.inc
-
 # 25.0 Binlog_transaction_compression
 # The below file is included because by default
 # binlog_transaction_compression is disabled and few rpl suite runs

mysql-test/include/have_binlog_transaction_dependency_tracking_commit_order.inc

@@ -32,7 +32,6 @@ if (!$have_windows) {
    WHERE VARIABLE_NAME LIKE 'replica_parallel_workers'
    OR VARIABLE_NAME LIKE 'replica_parallel_type'
    OR VARIABLE_NAME LIKE 'replica_preserve_commit_order'
-   OR VARIABLE_NAME LIKE 'binlog_transaction_dependency_tracking'
    OR VARIABLE_NAME LIKE 'enforce_gtid_consistency'
    OR VARIABLE_NAME LIKE 'gtid_mode'
    ORDER BY VARIABLE_NAME;

mysql-test/include/spawn_monitoring_process.inc

@@ -46,17 +46,17 @@ include/assert.inc [Expect 500+ variables in the table. Due to open Bugs, we are
 
 # Test SET PERSIST
 
-include/assert.inc [Expect 442 persisted variables in the table.]
+include/assert.inc [Expect 441 persisted variables in the table.]
 
 ************************************************************
 * 3. Restart server, it must preserve the persisted variable
 *    settings. Verify persisted configuration.
 ************************************************************
 # restart
 
-include/assert.inc [Expect 442 persisted variables in persisted_variables table.]
-include/assert.inc [Expect 442 persisted variables shown as PERSISTED in variables_info table.]
-include/assert.inc [Expect 442 persisted variables with matching peristed and global values.]
+include/assert.inc [Expect 441 persisted variables in persisted_variables table.]
+include/assert.inc [Expect 441 persisted variables shown as PERSISTED in variables_info table.]
+include/assert.inc [Expect 441 persisted variables with matching peristed and global values.]
 
 ************************************************************
 * 4. Test RESET PERSIST IF EXISTS. Verify persisted variable

mysql-test/r/all_persisted_variables.result

@@ -1,6 +1,3 @@
-SET GLOBAL binlog_transaction_dependency_tracking=COMMIT_ORDER;
-Warnings:
-Warning	1287	'@@binlog_transaction_dependency_tracking' is deprecated and will be removed in a future release.
 # Testing FR2
 Must have SESSION_VARIABLES_ADMIN with grant option
 SHOW GRANTS FOR root@localhost;
@@ -178,9 +175,6 @@ SET SESSION rbr_exec_mode = DEFAULT;
 # Cleanup
 DROP DATABASE wl12217;
 DROP USER wl12217@localhost;
-SET GLOBAL binlog_transaction_dependency_tracking=SAVED_BINLOG_TRANSACTION_DEPENDENCY_TRACKING;
-Warnings:
-Warning	1287	'@@binlog_transaction_dependency_tracking' is deprecated and will be removed in a future release.
 # Testing FR7
 # Must have SESSION_VARIABLES_ADMIN
 SHOW GRANTS for "mysql.session"@localhost;

mysql-test/r/grant_dynamic_session_variables_admin.result

@@ -222,12 +222,6 @@ The following options may be given as the first argument:
  transaction compression in the binary log.
  --binlog-transaction-dependency-history-size=# 
  Maximum number of rows to keep in the writeset history.
- --binlog-transaction-dependency-tracking=name 
- Selects the source of dependency information from which
- to compute logical timestamps, which replicas can use to
- decide which transactions can be executed in parallel
- when using replica_parallel_type=LOGICAL_CLOCK. Possible
- values are COMMIT_ORDER, WRITESET and WRITESET_SESSION.
  --block-encryption-mode=name 
  mode for AES_ENCRYPT/AES_DECRYPT
  --bulk-insert-buffer-size=# 
@@ -1138,8 +1132,7 @@ The following options may be given as the first argument:
  databases. LOGICAL_CLOCK, which is the default, indicates
  that it decides whether two transactions can be applied
  in parallel using the logical timestamps computed by the
- source, according to
- binlog_transaction_dependency_tracking.
+ source.
  --replica-parallel-workers=# 
  Number of worker threads for executing events in parallel
  --replica-pending-jobs-size-max=# 
@@ -1645,7 +1638,6 @@ binlog-stmt-cache-size 32768
 binlog-transaction-compression FALSE
 binlog-transaction-compression-level-zstd 3
 binlog-transaction-dependency-history-size 25000
-binlog-transaction-dependency-tracking WRITESET
 block-encryption-mode aes-128-ecb
 bulk-insert-buffer-size 8388608
 caching-sha2-password-digest-rounds 5000

mysql-test/r/mysqld--help-notwin.result

@@ -222,12 +222,6 @@ The following options may be given as the first argument:
  transaction compression in the binary log.
  --binlog-transaction-dependency-history-size=# 
  Maximum number of rows to keep in the writeset history.
- --binlog-transaction-dependency-tracking=name 
- Selects the source of dependency information from which
- to compute logical timestamps, which replicas can use to
- decide which transactions can be executed in parallel
- when using replica_parallel_type=LOGICAL_CLOCK. Possible
- values are COMMIT_ORDER, WRITESET and WRITESET_SESSION.
  --block-encryption-mode=name 
  mode for AES_ENCRYPT/AES_DECRYPT
  --bulk-insert-buffer-size=# 
@@ -1141,8 +1135,7 @@ The following options may be given as the first argument:
  databases. LOGICAL_CLOCK, which is the default, indicates
  that it decides whether two transactions can be applied
  in parallel using the logical timestamps computed by the
- source, according to
- binlog_transaction_dependency_tracking.
+ source.
  --replica-parallel-workers=# 
  Number of worker threads for executing events in parallel
  --replica-pending-jobs-size-max=# 
@@ -1656,7 +1649,6 @@ binlog-stmt-cache-size 32768
 binlog-transaction-compression FALSE
 binlog-transaction-compression-level-zstd 3
 binlog-transaction-dependency-history-size 25000
-binlog-transaction-dependency-tracking WRITESET
 block-encryption-mode aes-128-ecb
 bulk-insert-buffer-size 8388608
 caching-sha2-password-digest-rounds 5000

mysql-test/r/mysqld--help-win.result

@@ -9,7 +9,7 @@ SET DEBUG_SYNC="purge_logs_after_lock_index_before_thread_count SIGNAL purge_rea
 PURGE BINARY LOGS BEFORE '2038-01-19';
 connect con2,localhost,root,,;
 SET DEBUG_SYNC="materialize_session_variable_array_THD_locked SIGNAL pfs_ready WAIT_FOR finish_pfs";
-SELECT * FROM performance_schema.session_variables WHERE VARIABLE_NAME LIKE 'binlog_transaction_dependency_tracking';;
+SELECT * FROM performance_schema.session_variables WHERE VARIABLE_NAME LIKE 'binlog_transaction_dependency_history_size';
 connect con3,localhost,root,,;
 SET DEBUG_SYNC="show_binlogs_after_lock_log_before_lock_index SIGNAL show_ready WAIT_FOR finish_show";
 SHOW BINARY LOGS;
@@ -26,7 +26,7 @@ Warning	1868	file binlog.000002 was not purged because it is the active log file
 disconnect con1;
 connection con2;
 VARIABLE_NAME	VARIABLE_VALUE
-binlog_transaction_dependency_tracking	WRITESET
+binlog_transaction_dependency_history_size	25000
 disconnect con2;
 connection con3;
 disconnect con3;

mysql-test/suite/binlog/r/binlog_reset_connection_not_reset_writeset.result

@@ -1,19 +1,12 @@
 RESET BINARY LOGS AND GTIDS;
 #
-# 1. Setup
-#    Set dependency tracking to WRITESET
-include/save_sysvars.inc [ "GLOBAL.binlog_transaction_dependency_tracking" ]
-SET GLOBAL binlog_transaction_dependency_tracking = WRITESET;
-Warnings:
-Warning	1287	'@@binlog_transaction_dependency_tracking' is deprecated and will be removed in a future release.
-#
-# 2. Create a table
+# 1. Create a table
 #    Execute transactions that are not conflicting according to their writesets
 CREATE TABLE t1 (a INT PRIMARY KEY AUTO_INCREMENT, b INT);
 INSERT INTO t1 VALUES(1, 1), (2, 2), (3, 3);
 INSERT INTO t1 (b) VALUES(4), (5), (6);
 #
-# 3. Change the binlog format to Mixed
+# 2. Change the binlog format to Mixed
 #    Execute a transaction that has a statement part that conflicts with a previous transaction
 #    and an unsafe part that is logged as row but is non conflicting
 SET binlog_format=MIXED;
@@ -24,11 +17,8 @@ UPDATE t1 SET b=55 WHERE a=5;
 INSERT INTO t1 (b) VALUES(ceil(rand()*100));
 COMMIT;
 #
-# 4. Check the last transaction is marked as conflicting with the previous
+# 3. Check the last transaction is marked as conflicting with the previous
 include/include/assert_logical_timestamps.inc [0 1;1 2;1 3;3 4]
 #
-# 5. Clean up
+# 4. Clean up
 DROP TABLE t1;
-include/restore_sysvars.inc
-Warnings:
-Warning	1287	'@@binlog_transaction_dependency_tracking' is deprecated and will be removed in a future release.

mysql-test/suite/binlog/r/binlog_set_trans_dependency_deadlock.result

@@ -4,9 +4,8 @@
 
 # ==== Requirements ====
 #
-# R1. When using binlog_transaction_dependency_tracking = 'WRITESET', two
-#   transactions that conflict on a unique multi-valued index must be marked as
-#   dependent in the binary log.
+# R1. Two transactions that conflict on a unique multi-valued index must be
+#   marked as dependent in the binary log.
 # R2. When using binlog_row_image=MINIMAL, the before-image shall not be
 #   generated from a multi-valued index.
 #