WL#15517: [2] HeatWave Support for InnoDB Partitions - Extend MySQL API

to support partition (UN)LOAD

This patch modifies the MySQL parser to accept the partition load/unload
commands and also enriches the tables of the RAPID engine with
partitioning information.

a) Partitioning API
====================
The commands we use for loading/unloading partition are the following:
- ALTER TABLE SECONDARY_LOAD PARTITION (p0,p1,..,pn)
- ALTER TABLE SECONDARY_UNLOAD PARTITION (p0,p1,..,pn)

By using these two commands, and following a similar to the familiar
SECONDARY_(UN)LOAD syntax, users can select a set of partitions that
they want to load or unload.

The PARTITION() clause is parsed by MySQL with the updated
SECONDARY_LOAD/SECONDARY_UNLOAD grammar rules in sql_yacc (they are
extended to also carry an optional partition list) and the names are
stored in Table_ref->partition_names.

b) Partitioned secondary tables
===============================
Rapid tables inherit exactly the same partitioning information that
exists in the primary engine.

Change-Id: Idf444787d8b0f9dd0504137a509ec18409e9f567

Author: Evangelos Danias

Diff for: mysql-test/collections/disabled.def

@@ -150,6 +150,9 @@ rpl.rpl_io_thd_wait_for_disk_space_stress : BUG#23581287 Disabled until bug is f
 rpl.rpl_writeset_add_unique_key : Bug#33134835 RPL_WRITESET_ADD_UNIQUE_KEY FAILS SPORADICALLY
 rpl.rpl_replication_observers_example_plugin_ongoing_transaction : Bug#35982448	rpl_replication_observers_example_plugin_ongoing_transaction fails 
 
+# secondary_engine tests
+secondary_engine.query_preparation : BUG#36306426 Disabled until bug is fixed
+
 # sys_vars tests
 sys_vars.max_execution_time_basic @freebsd : BUG#31041720
 sys_vars.innodb_log_writer_threads_basic : Bug#32129814 SYS_VARS.INNODB_LOG_WRITER_THREADS_BASIC TIMES OUT SPORADICALLY ON PB2

Diff for: sql/dd_table_share.cc

@@ -1910,11 +1910,6 @@ static bool fill_partitioning_from_dd(THD *thd, TABLE_SHARE *share,
                                       const dd::Table *tab_obj) {
   if (tab_obj->partition_type() == dd::Table::PT_NONE) return false;
 
-  // The DD only has information about how the table is partitioned in
-  // the primary storage engine, so don't use this information for
-  // tables in a secondary storage engine.
-  if (share->is_secondary_engine()) return false;
-
   partition_info *part_info;
   part_info = new (&share->mem_root) partition_info;
 

Diff for: sql/parse_tree_nodes.h

@@ -4772,11 +4772,18 @@ class PT_alter_table_secondary_load final
     : public PT_alter_table_standalone_action {
   using super = PT_alter_table_standalone_action;
 
+  const List<String> *opt_use_partition = nullptr;
+
  public:
-  explicit PT_alter_table_secondary_load(const POS &pos)
-      : super(pos, Alter_info::ALTER_SECONDARY_LOAD) {}
+  explicit PT_alter_table_secondary_load(
+      const POS &pos, const List<String> *opt_use_partition = nullptr)
+      : super(pos, Alter_info::ALTER_SECONDARY_LOAD),
+        opt_use_partition{opt_use_partition} {}
 
   Sql_cmd *make_cmd(Table_ddl_parse_context *pc) override {
+    if (opt_use_partition != nullptr)
+      pc->alter_info->partition_names = *opt_use_partition;
+
     return new (pc->mem_root) Sql_cmd_secondary_load_unload(pc->alter_info);
   }
 };
@@ -4785,11 +4792,18 @@ class PT_alter_table_secondary_unload final
     : public PT_alter_table_standalone_action {
   using super = PT_alter_table_standalone_action;
 
+  const List<String> *opt_use_partition = nullptr;
+
  public:
-  explicit PT_alter_table_secondary_unload(const POS &pos)
-      : super(pos, Alter_info::ALTER_SECONDARY_UNLOAD) {}
+  explicit PT_alter_table_secondary_unload(
+      const POS &pos, const List<String> *opt_use_partition = nullptr)
+      : super(pos, Alter_info::ALTER_SECONDARY_UNLOAD),
+        opt_use_partition{opt_use_partition} {}
 
   Sql_cmd *make_cmd(Table_ddl_parse_context *pc) override {
+    if (opt_use_partition != nullptr)
+      pc->alter_info->partition_names = *opt_use_partition;
+
     return new (pc->mem_root) Sql_cmd_secondary_load_unload(pc->alter_info);
   }
 };

Diff for: sql/sql_table.cc

@@ -11733,6 +11733,17 @@ bool Sql_cmd_secondary_load_unload::mysql_secondary_load_or_unload(
   /* If set, secondary_load value will not be updated, and also no bin log
    * entries will be recorded. */
   bool skip_metadata_update = false;
+
+  // Partitioned Load/Unload
+  if (table_list->table->part_info != nullptr) {
+    table_list->partition_names = nullptr;
+
+    if (m_alter_info->partition_names.elements > 0 &&
+        !(m_alter_info->flags & Alter_info::ALTER_ALL_PARTITION)) {
+      table_list->partition_names = &m_alter_info->partition_names;
+    }
+  }
+
   // Initiate loading into or unloading from secondary engine.
   if (is_load) {
     DEBUG_SYNC(thd, "before_secondary_engine_load_table");

Diff for: sql/sql_yacc.yy

@@ -8741,13 +8741,13 @@ standalone_alter_commands:
           {
             $$= NEW_PTN PT_alter_table_import_partition_tablespace(@$, $3);
           }
-        | SECONDARY_LOAD_SYM
+        | SECONDARY_LOAD_SYM opt_use_partition
           {
-            $$= NEW_PTN PT_alter_table_secondary_load(@$);
+            $$= NEW_PTN PT_alter_table_secondary_load(@$, $2);
           }
-        | SECONDARY_UNLOAD_SYM
+        | SECONDARY_UNLOAD_SYM opt_use_partition
           {
-            $$= NEW_PTN PT_alter_table_secondary_unload(@$);
+            $$= NEW_PTN PT_alter_table_secondary_unload(@$, $2);
           }
         ;