BUG#20455917: GROUP REPLICATION APPLIER CHANNEL IS NOT LISTED ON ALL REPLICATION P_S TABLES

Group Replication applier channel was not being listed on all
replication performance schema tables, what was causing some status
values not to be accessible.
This was happening because Group Replication applier channel doesn't
have a regular Master_info object, since it doesn't have a IO
thread. Applier data comes from group communication toolkit and not
from a point-to-point connection from a master.

On this patch we ensure that Group Replication applier channel is
listed on all replication performance schema tables by adding the
channel with a fake master hostname "<NULL>".

Author: nacarvalho

include/mysql/plugin_group_replication.h

@@ -27,12 +27,6 @@ enum enum_member_state {
   MEMBER_STATE_RECOVERING
 };
 
-enum enum_applier_status {
-  APPLIER_STATE_RUNNING= 1,
-  APPLIER_STATE_STOP,
-  APPLIER_STATE_ERROR
-};
-
 typedef struct st_group_replication_connection_status_info
 {
   char* channel_name;
@@ -103,7 +97,7 @@ struct st_mysql_group_replication
     @note The caller is responsible to free memory from the info structure and
           from all its fields.
   */
-  bool (*get_group_members_info)(uint index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info);
+  bool (*get_group_members_info)(unsigned int index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info);
 
   /*
     This function is used to fetch information for group replication members statistics.
@@ -118,7 +112,7 @@ struct st_mysql_group_replication
   /*
     Get number of group replication members.
   */
-  uint (*get_members_number_info)();
+  unsigned int (*get_members_number_info)();
 };
 
 #endif

mysql-test/include/rpl_end.inc

@@ -117,7 +117,7 @@ if ($rpl_group_replication)
     --source include/rpl_connection.inc
 
     --let $_group_replication_member_state= `SELECT SERVICE_STATE FROM performance_schema.replication_connection_status connection_status WHERE connection_status.group_name="$group_replication_group_name"`
-    if ($_group_replication_member_state != 'OFF')
+    if ($_group_replication_member_state == 'ON')
     {
       --source include/stop_group_replication.inc
     }

mysql-test/suite/rpl/t/rpl_wait_for_executed_gtid_set.test

@@ -12,12 +12,12 @@
 #
 
 --let $rpl_gtid_utils= 1
---source include/master-slave.inc
 --source include/have_log_bin.inc
 --source include/have_gtid.inc
+--source include/master-slave.inc
 
 --connection slave
---let $master_uuid= query_get_value(select SOURCE_UUID from performance_schema.replication_connection_status, SOURCE_UUID, 1)
+--let $master_uuid= query_get_value(select SOURCE_UUID from performance_schema.replication_connection_status WHERE service_state = 'ON', SOURCE_UUID, 1)
 --connection master
 
 --let $uuid= 8a94f357-aab4-11df-86ab-c80aa9429560

mysql-test/suite/rpl/t/rpl_wait_for_executed_gtid_set_no_timeout.test

@@ -7,12 +7,12 @@
 #
 
 --let $rpl_gtid_utils= 1
---source include/master-slave.inc
 --source include/have_log_bin.inc
 --source include/have_gtid.inc
+--source include/master-slave.inc
 
 connection slave;
---let $master_uuid= query_get_value(select SOURCE_UUID from performance_schema.replication_connection_status, SOURCE_UUID, 1)
+--let $master_uuid= query_get_value(select SOURCE_UUID from performance_schema.replication_connection_status WHERE service_state = 'ON', SOURCE_UUID, 1)
 --connection master
 
 --let $uuid= 8a94f357-aab4-11df-86ab-c80aa9429560

mysql-test/suite/rpl/t/rpl_wait_for_executed_gtid_set_with_sleep.test

@@ -6,12 +6,12 @@
 # verify that the wait function does not return immediately.
 #
 
---source include/master-slave.inc
 --source include/have_log_bin.inc
 --source include/have_gtid.inc
+--source include/master-slave.inc
 
 --connection slave
---let $master_uuid= query_get_value(select SOURCE_UUID from performance_schema.replication_connection_status, SOURCE_UUID, 1)
+--let $master_uuid= query_get_value(select SOURCE_UUID from performance_schema.replication_connection_status WHERE service_state = 'ON', SOURCE_UUID, 1)
 
 --connection master
 

sql/rpl_group_replication.cc

@@ -86,7 +86,7 @@ get_connection_status_info(GROUP_REPLICATION_CONNECTION_STATUS_INFO *info)
 
 bool
 Group_replication_handler::
-get_group_members_info(uint index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info)
+get_group_members_info(unsigned int index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info)
 {
   if (plugin_handle)
     return plugin_handle->get_group_members_info(index, info);
@@ -102,7 +102,7 @@ get_group_member_stats_info(GROUP_REPLICATION_GROUP_MEMBER_STATS_INFO *info)
   return true;
 }
 
-uint Group_replication_handler::get_members_number_info()
+unsigned int Group_replication_handler::get_members_number_info()
 {
   if (plugin_handle)
     return plugin_handle->get_members_number_info();
@@ -198,7 +198,7 @@ bool get_group_replication_connection_status_info(GROUP_REPLICATION_CONNECTION_S
   return true;
 }
 
-bool get_group_replication_group_members_info(uint index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info)
+bool get_group_replication_group_members_info(unsigned int index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info)
 {
   if (group_replication_handler)
     return group_replication_handler->get_group_members_info(index, info);
@@ -212,7 +212,7 @@ bool get_group_replication_group_member_stats_info(GROUP_REPLICATION_GROUP_MEMBE
   return true;
 }
 
-uint get_group_replication_members_number_info()
+unsigned int get_group_replication_members_number_info()
 {
   if (group_replication_handler)
     return group_replication_handler->get_members_number_info();

sql/rpl_group_replication.h

@@ -38,9 +38,9 @@ class Group_replication_handler
   bool is_running();
   int set_retrieved_certification_info(View_change_log_event *view_change_event);
   bool get_connection_status_info(GROUP_REPLICATION_CONNECTION_STATUS_INFO *info);
-  bool get_group_members_info(uint index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info);
+  bool get_group_members_info(unsigned int index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info);
   bool get_group_member_stats_info(GROUP_REPLICATION_GROUP_MEMBER_STATS_INFO* info);
-  uint get_members_number_info();
+  unsigned int get_members_number_info();
 
 private:
   std::string plugin_name;
@@ -62,9 +62,9 @@ bool is_group_replication_running();
 int set_group_replication_retrieved_certification_info(View_change_log_event *view_change_event);
 
 bool get_group_replication_connection_status_info(GROUP_REPLICATION_CONNECTION_STATUS_INFO *info);
-bool get_group_replication_group_members_info(uint index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info);
+bool get_group_replication_group_members_info(unsigned int index, GROUP_REPLICATION_GROUP_MEMBERS_INFO *info);
 bool get_group_replication_group_member_stats_info(GROUP_REPLICATION_GROUP_MEMBER_STATS_INFO* info);
-uint get_group_replication_members_number_info();
+unsigned int get_group_replication_members_number_info();
 
 
 #endif /* RPL_GROUP_REPLICATION_INCLUDED */

sql/rpl_msr.cc

@@ -162,6 +162,17 @@ bool Multisource_info::delete_mi(const char* channel_name)
 }
 
 
+bool Multisource_info::is_group_replication_channel_name(const char* channel,
+                                                         bool is_applier)
+{
+  if (is_applier)
+    return !strcmp(channel, group_replication_channel_names[0]);
+  else
+    return !strcmp(channel, group_replication_channel_names[0]) ||
+           !strcmp(channel, group_replication_channel_names[1]);
+}
+
+
 #ifdef WITH_PERFSCHEMA_STORAGE_ENGINE
 
 bool Multisource_info::add_mi_to_rpl_pfs_mi(Master_info *mi)

sql/rpl_msr.h

@@ -247,17 +247,15 @@ class Multisource_info
   /**
     Returns if a channel name is one of the reserved group replication names
 
-    @param channel the channel name to test
+    @param channel    the channel name to test
+    @param is_applier compare only with applier name
 
     @return
       @retval      true   the name is a reserved name
       @retval      false  non reserved name
   */
-  inline bool is_group_replication_channel_name(const char* channel)
-  {
-    return !strcmp(channel, group_replication_channel_names[0]) ||
-           !strcmp(channel, group_replication_channel_names[1]);
-  }
+  bool is_group_replication_channel_name(const char* channel,
+                                         bool is_applier= false);
 
   /**
      Forward iterators to initiate traversing of a map.