Bug#32637784: MYSQL_MIGRATE_KEYRING DOES NOT ENFORCE DISTINCT SOURCE AND DESTINATION KEYSTORES

Description: Sanity checks for source and destination
             keyring didn't account for same keyring
             specified twice.

Fix: Added checks to make sure that source and
     destination keyring are not the same.

RB: 26138

Author: harinvadodaria

client/migrate_keyring/options.cc

@@ -222,6 +222,11 @@ static bool check_options_for_sanity() {
               << std::endl;
     return false;
   }
+
+  if (strcmp(Options::s_source_keyring, Options::s_destination_keyring) == 0) {
+    log_error << "Source and destination cannot be the same." << std::endl;
+    return false;
+  }
   return true;
 }
 

mysql-test/suite/auth_sec/r/keyring_migration.result

@@ -0,0 +1,5 @@
+#
+# Bug #32637784: MYSQL_MIGRATE_KEYRING DOES NOT ENFORCE
+#                DISTINCT SOURCE AND DESTINATION KEYSTORES
+#
+TIMESTAMP [ERROR]   Source and destination cannot be the same.

mysql-test/suite/auth_sec/t/keyring_migration.test

@@ -0,0 +1,7 @@
+--echo #
+--echo # Bug #32637784: MYSQL_MIGRATE_KEYRING DOES NOT ENFORCE
+--echo #                DISTINCT SOURCE AND DESTINATION KEYSTORES
+--echo #
+
+--replace_regex /[0-9][0-9][0-9][0-9]-[0-9][0-9]-[0-9][0-9] [0-9][0-9]:[0-9][0-9]:[0-9][0-9]/TIMESTAMP/
+--exec $MYSQL_MIGRATE_KEYRING --component-dir=foo --source-keyring=bar --destination-keyring=bar 2>&1