Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump constraint to support PHP 8.4 #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/__shared-ci.yml
Original file line number Diff line number Diff line change
@@ -11,6 +11,7 @@ jobs:
- php-versions: "8.1"
- php-versions: "8.2"
- php-versions: "8.3"
- php-versions: "8.4"
stable: true

runs-on: ubuntu-latest
@@ -54,6 +55,8 @@ jobs:
- name: 👕 Lint
if: matrix.stable
run: composer php-cs-fixer -- --format=checkstyle | tools/vendor/bin/cs2pr
env:
PHP_CS_FIXER_IGNORE_ENV: ${{ matrix.php-versions == '8.4' && '1' || '' }}

- name: 🔬 Rector
id: rector
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
PHP_VERSION=8.3
PHP_VERSION=8.4
PROJECT_NAME=$(shell basename $(CURDIR))
UID=$(shell id -u)
GID=$(shell id -g)
@@ -50,7 +50,7 @@ ci: ## Execute CI scripts for given PHP version

## Run PHP for given version
define run-php
@docker run -it --rm -v ${PWD}:${PWD} -w ${PWD} "${IMAGE}" $(1)
@docker run -it --rm -v ${PWD}:${PWD} -e PHP_CS_FIXER_IGNORE_ENV=$(if $(filter 8.4,$(PHP_VERSION)),1,) -w ${PWD} "${IMAGE}" $(1)
endef

#############################
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@
"issues": "https://github.com/neilime/php-css-lint/issues"
},
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "^8.1",
"ext-json": "*"
},
"require-dev": {