Expose schema enforcement via SimpleKGPipeline #315
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
reviewed
Mar 21, 2025
| @@ -81,6 +85,7 @@ def __init__( | |||
| entities: Optional[Sequence[EntityInputType]] = None, | |||
| relations: Optional[Sequence[RelationInputType]] = None, | |||
| potential_schema: Optional[List[tuple[str, str, str]]] = None, | |||
| enforce_schema: str = "NONE", | |||
There was a problem hiding this comment.
Should this type be Optional[SchemaEnforcementMode] instead and default to None?
There was a problem hiding this comment.
Two things here:
- we wanted
SimpleKGPipelineto accept a string and convert it internally to the enum value (for consistency withon_errorparam) - as for
Optional, I don't mind. I initially made it similar to what we have withon_error, but I also thought having it like this will avoid extra conditions forNonevalues. It is also "semantically" different (SchemaEnforcementMode.NONEmeans that we know the enforcement option chosen by the user -> no enforcement ,Nonemeans the choice of schema enforcement is unset or unknown). But maybe we don't care? wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue from PR#296, where the
enforce_schemaparameter was mistakenly omitted fromSimpleKGPipeline, preventing the optional schema enforcement feature from being enabled. This update adds the missing parameter, allowing users to configure schema enforcement as intended.Type of Change
Complexity
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):