Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #18138: Add advanced object selector for custom field object and multi-object inputs #18830

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

atownson
Copy link
Contributor

@atownson atownson commented Mar 6, 2025

Closes: #18138

The approach here was to hard-code the selector=True argument for the object and multi-object inputs, thus always rendering the advanced object selector button. The advantage to this approach is that it does not require an additional attribute on the CustomField model or any logic to show/hide the input for such an attribute on the create form.

@jnovinger jnovinger requested review from a team and bctiemann and removed request for a team March 6, 2025 17:16
@bctiemann
Copy link
Contributor

@atownson I'm getting this error when I try to set up a custom field with object or multiobject type and then use the selector:

Screenshot 2025-03-24 at 7 38 58 PM

I wouldn't be surprised if it's an issue on my end, but could you please check in case it's a bug?

@arthanson
Copy link
Collaborator

Working for me:
Monosnap Editing circuit 1002840283 | NetBox 2025-03-26 09-53-33
Monosnap Editing circuit 1002840283 | NetBox 2025-03-26 09-53-58

@arthanson arthanson merged commit be26f86 into netbox-community:main Mar 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow filtering of ObjectVar and MultiObjectVar input selections for custom fields
3 participants