Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: don't reset workspace when running E2E tests #7122

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

ndhoule
Copy link
Contributor

@ndhoule ndhoule commented Mar 21, 2025

The E2E test script unexpectedly runs a git checkout . on the CLI repository. If you run it locally and have any uncommitted changes, oops! It just discarded your work.

#7119 removes the package.json#scripts pre-publish mangling that we used to do, which is ostensibly why we needed this in the first place.

@ndhoule ndhoule force-pushed the feat/unrevert-ci-changes branch 3 times, most recently from 20c87a4 to f47afaf Compare March 21, 2025 18:35
@ndhoule ndhoule force-pushed the test/no-more-destroy-all-my-work branch from 9498e38 to 4f662d5 Compare March 21, 2025 19:02
@ndhoule ndhoule changed the base branch from feat/unrevert-ci-changes to main March 21, 2025 19:02
The E2E test script unexpectedly runs a `git checkout .` on the CLI
repository. If you run it locally and have any uncommitted changes,
oops! It just discarded your work.

#7119 removes the
`package.json#scripts` pre-publish mangling that we used to do, which
is ostensibly why we needed this in the first place.
@ndhoule ndhoule force-pushed the test/no-more-destroy-all-my-work branch from 4f662d5 to 81b2afa Compare March 21, 2025 19:09
Copy link

📊 Benchmark results

Comparing with 075819b

  • Dependency count: 1,173 (no change)
  • Package size: 297 MB (no change)
  • Number of ts-expect-error directives: 715 (no change)

@ndhoule ndhoule marked this pull request as ready for review March 21, 2025 20:52
@ndhoule ndhoule requested a review from a team as a code owner March 21, 2025 20:52
@serhalp serhalp merged commit 41bfab8 into main Mar 21, 2025
52 checks passed
@serhalp serhalp deleted the test/no-more-destroy-all-my-work branch March 21, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants