fix: notify activity called for any proxied request #7356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denar90
approved these changes
Jun 22, 2025
VitaliyR
force-pushed
the
vitaliir/notify-activity-fix
branch
from
c39e623 to
2b9c720
Compare
denar90
approved these changes
Jun 23, 2025
eduardoboucas
approved these changes
Jun 23, 2025
src/utils/proxy.ts
Outdated
| @@ -859,15 +859,13 @@ const onRequest = async ( | |||
| } | |||
|
|
|||
| const maybeNotifyActivity = () => { | |||
| if (req.method === 'GET' && api && process.env.NETLIFY_DEV_SERVER_ID) { | |||
| if (api && process.env.NETLIFY_DEV_SERVER_ID && (req.method === 'GET' || req.url?.includes('/.ntlfy-dev/'))) { | |||
There was a problem hiding this comment.
Is /.ntlfy-dev/ at the beginning of the URL path? If so, so we check for that specifically as opposed to allowing it anywhere on the URL?
VitaliyR
force-pushed
the
vitaliir/notify-activity-fix
branch
from
2b9c720 to
51f520f
Compare
denar90
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
If preview server does the proxy e.g. to internal routes or the user site proxy-all
*- we not notifying activity.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)