Skip to content

Update all gpg --recv-keys invocations with explicit "did it download" checks #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

tianon
Copy link
Contributor

@tianon tianon commented Jul 2, 2025

This solves for the case of gpg --recv-keys receiving enough valid data that it doesn't return a non-zero exit code, but that it also doesn't import a key by explicitly checking afterwards that it did import the key we asked for (so that the fallback to keyserver.ubuntu.com actually happens appropriately for keys whose UID are no longer validated on keys.openpgp.org).

See also:

…ad" checks

This solves for the case of `gpg --recv-keys` receiving enough valid data that it doesn't return a non-zero exit code, but that it also doesn't import a key by explicitly checking afterwards that it did import the key we asked for (so that the fallback to keyserver.ubuntu.com actually happens appropriately for keys whose UID are no longer validated on keys.openpgp.org).
@tianon
Copy link
Contributor Author

tianon commented Jul 2, 2025

(all those "linting" annotations are especially annoying to see here, especially given I'm the author of moby/buildkit#5130 😅)

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399
Copy link

@tianon

Thanks for proposing this remedy!

I've duplicated it to PR cypress-io/cypress-docker-images#1380 which builds Docker images for Cypress based on selectable versions of Node.js, browser versions, etc. for website testing.

@PeterDaveHello PeterDaveHello requested a review from Copilot July 6, 2025 18:32
Copilot

This comment was marked as spam.

@PeterDaveHello PeterDaveHello requested a review from a team July 7, 2025 14:58
@PeterDaveHello PeterDaveHello merged commit 3ac814a into nodejs:main Jul 7, 2025
21 checks passed
Copy link

github-actions bot commented Jul 7, 2025

Created PR on the official-images repo (docker-library/official-images#19405). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants