Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move insert_item logic out of meta_return #942

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

thuyen
Copy link
Contributor

@thuyen thuyen commented Mar 21, 2025

Summary

Move insert_item logic out of meta_return into a reusable function. In a follow up, #943 will make meta_return logic even cleaner. This will make it easy for one to customize meta_return's behavior in their config.

Changes

  • As title.

Checklist

I confirm that I have:

  • Followed the
    Conventional Commits
    specification
    (e.g., feat: add new feature, fix: correct bug,
    docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Updated relevant documentation, if necessary.
  • Thoroughly tested my changes.
  • Added tests (if applicable) and verified existing tests pass with
    make test.
  • Checked for breaking changes and documented them, if any.

@thuyen thuyen force-pushed the insert_item_below branch from 879c50f to 7118bcf Compare March 21, 2025 04:32
@thuyen thuyen mentioned this pull request Mar 21, 2025
6 tasks
Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Let's just make it private and slightly change the name of the method.

thuyen and others added 2 commits March 25, 2025 18:02
Co-authored-by: Kristijan Husak <husakkristijan@gmail.com>
@thuyen thuyen requested a review from kristijanhusak March 26, 2025 01:04
@kristijanhusak kristijanhusak merged commit d2b0fe5 into nvim-orgmode:master Mar 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants