Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: meta_return on a link item #943

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

thuyen
Copy link
Contributor

@thuyen thuyen commented Mar 21, 2025

Summary

Meta return doesn't work when the cursor is on a link because currently we don't handle link in the logic to find a headline or listitem node (the added test would be failing on master).

This PR factor out that logic into a reusable find_item_or_headline function and make it a bit more general.

Checklist

I confirm that I have:

  • Followed the
    Conventional Commits
    specification
    (e.g., feat: add new feature, fix: correct bug,
    docs: update documentation).
  • My PR title also follows the conventional commits specification.
  • Updated relevant documentation, if necessary.
  • Thoroughly tested my changes.
  • Added tests (if applicable) and verified existing tests pass with
    make test.
  • Checked for breaking changes and documented them, if any.

@thuyen thuyen changed the title fix: correct meta_return on a link fix: meta_return on a link item Mar 21, 2025
@thuyen thuyen force-pushed the find_item_or_headline branch 4 times, most recently from 585dde9 to 5deae63 Compare March 21, 2025 05:22
@thuyen thuyen force-pushed the find_item_or_headline branch from 5deae63 to 48c0762 Compare March 26, 2025 14:42
@thuyen thuyen force-pushed the find_item_or_headline branch from 48c0762 to f448426 Compare March 26, 2025 14:44
Copy link
Member

@kristijanhusak kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kristijanhusak kristijanhusak merged commit b42236a into nvim-orgmode:master Mar 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants