Skip to content

feat(client): add ResponseAccumulator #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

damo
Copy link
Contributor

@damo damo commented Apr 2, 2025

A draft of the ResponseAccumulator and its documentation for review only—not for release. Changes will be needed before release, even if only to remove the // TODO comments.

@damo damo requested a review from a team as a code owner April 2, 2025 15:46
Copy link
Collaborator

@TomerAberbach TomerAberbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks pretty much right. We just need to wait for Kevin on the rest of the TODOs I guess

@damo damo force-pushed the damo/response-accumulator branch from 3c94950 to c8cb24c Compare July 17, 2025 16:16
@damo damo requested a review from TomerAberbach July 17, 2025 16:17
@TomerAberbach TomerAberbach changed the title Draft ResponseAccumulator feat(client): add ResponseAccumulator Jul 17, 2025
@TomerAberbach TomerAberbach merged commit 77f54fd into openai:next Jul 17, 2025
2 of 3 checks passed
@stainless-app stainless-app bot mentioned this pull request Jul 17, 2025
TomerAberbach added a commit that referenced this pull request Jul 17, 2025
* add draft contributing.md

* remove a few things

* Apply suggestions from code review

Co-authored-by: Tomer Aberbach <tomer@stainlessapi.com>

* address more comments

* Update CONTRIBUTING.md

Co-authored-by: Tomer Aberbach <tomer@stainlessapi.com>

* Apply suggestions from code review

Co-authored-by: Tomer Aberbach <tomer@stainlessapi.com>

* pr comments

* chore(internal): allow running specific example from cli

* fix(client): ensure error handling always occurs

* feat(client): add `ResponseAccumulator` (#391)

* response-accumulator: first draft for review.

* response-accumulator: added accumulator and documented streaming support.

* chore(client): remove non-existent method

* release: 2.15.0

---------

Co-authored-by: David Meadows <dmeadows@stainless.com>
Co-authored-by: Tomer Aberbach <tomer@stainlessapi.com>
Co-authored-by: stainless-app[bot] <142633134+stainless-app[bot]@users.noreply.github.com>
Co-authored-by: D Gardner <damien@gardnerhrm.com>
Co-authored-by: Tomer Aberbach <tomer@stainless.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants