Skip to content

Bump System.Net.Http from 4.3.3 to 4.3.4 in /Source/OxyPlot.Xamarin.Forms.Platform.iOS #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 21, 2021

Bumps System.Net.Http from 4.3.3 to 4.3.4.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 21, 2021
@VisualMelon
Copy link

@oxyplot/admins any reason we shouldn't merge these? (I don't have the power to do and I'm also not familiar with dependabot, though this seems a legitimate change)

@objorke
Copy link
Member

objorke commented Apr 29, 2021

I don't see any reason not to merge since this is just a patch.
More information about the vulnerability
https://snyk.io/vuln/SNYK-DOTNET-SYSTEMNETHTTP-72439

But, is System.Net.Http really needed in this library?

@VisualMelon
Copy link

VisualMelon commented Apr 29, 2021

I'm afraid I can't test any of these packages, so while there doesn't seem to be any use in the code, I can't comment for sure.

There are a number of other packages that don't appear to be direct dependencies (e.g. Crypto).

Bumps System.Net.Http from 4.3.3 to 4.3.4.

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/nuget/Source/OxyPlot.Xamarin.Forms.Platform.iOS/System.Net.Http-4.3.4 branch from 9cc3919 to 36fc143 Compare December 1, 2022 13:28
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 2, 2022

Looks like System.Net.Http is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this Dec 2, 2022
@dependabot dependabot bot deleted the dependabot/nuget/Source/OxyPlot.Xamarin.Forms.Platform.iOS/System.Net.Http-4.3.4 branch December 2, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants