Skip to content

Migrate projects from packages.config to PackageReference #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 5, 2022

Conversation

janusw
Copy link
Member

@janusw janusw commented Dec 4, 2022

This PR migrates the OxyPlot.Xamarin.* projects to the newer PackageReference style and removes the packages.config files, see https://learn.microsoft.com/en-us/nuget/consume-packages/migrate-packages-config-to-package-reference

For OxyPlot.Xamarin.Android, OxyPlot.Xamarin.iOS and OxyPlot.Xamarin.Mac, this migration was done automatically via VS2022. For the others projects this was not possible for some reason, so I simply removed the packages.config files there. It was not necessary to add any PackageReferences manually to make the solution build.

…instead add a corresponding PackageReference

* in order to fix build errors
* for iOS and Mac, this was done by the automatic migration
  (not sure why it was missed for Android)
* automatic migration was not possible here
* most of the packages are already pulled in as an indirect dependency from OxyPlot.Xamarin.Android
* the sln still builds well, so we simply remove it
* automatic migration was not possible here
* most of the packages are already pulled in as an indirect dependency from OxyPlot.Xamarin.iOS
* the sln still builds well, so we simply remove it
* automatic migration was not possible here
* most of the packages are already pulled in as an indirect dependency from OxyPlot.Xamarin.Mac
* the sln still builds well, so we simply remove it
@janusw
Copy link
Member Author

janusw commented Dec 4, 2022

Just to make sure, I verified that the packages generated in this PR still work well in a Xamarin.Forms app on Android and iOS.

@janusw janusw merged commit 2106d57 into oxyplot:develop Dec 5, 2022
@janusw janusw deleted the migrate_to_pkgref branch December 5, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant