Migrate projects from packages.config to PackageReference #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead add a corresponding PackageReference * in order to fix build errors * for iOS and Mac, this was done by the automatic migration (not sure why it was missed for Android)
* automatic migration was not possible here * most of the packages are already pulled in as an indirect dependency from OxyPlot.Xamarin.Android * the sln still builds well, so we simply remove it
* automatic migration was not possible here * most of the packages are already pulled in as an indirect dependency from OxyPlot.Xamarin.iOS * the sln still builds well, so we simply remove it
* automatic migration was not possible here * most of the packages are already pulled in as an indirect dependency from OxyPlot.Xamarin.Mac * the sln still builds well, so we simply remove it
|
Just to make sure, I verified that the packages generated in this PR still work well in a Xamarin.Forms app on Android and iOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the OxyPlot.Xamarin.* projects to the newer PackageReference style and removes the packages.config files, see https://learn.microsoft.com/en-us/nuget/consume-packages/migrate-packages-config-to-package-reference
For OxyPlot.Xamarin.Android, OxyPlot.Xamarin.iOS and OxyPlot.Xamarin.Mac, this migration was done automatically via VS2022. For the others projects this was not possible for some reason, so I simply removed the packages.config files there. It was not necessary to add any PackageReferences manually to make the solution build.