-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root elements order in component structure #15
Comments
Hello @ErickPetru !!! Thank you for this issue. What component organization are you proposing?
About having the Having the Please @ErickPetru , invite people over to discuss about it. Let's build something great for an awesome framework. Thank you once again for this issue :D |
Hello, first let's clarify it: I'm proposing
Of course I agree with you that we need much more than two opinions about it. |
Hello @ErickPetru :D Let me add some awesome dudes in this issue: @Elfayer @DannyFeliz @kartsims @aristidesfl Guys, what do you think about it? |
@ErickPetru I agree with the I also agree on seen the API first is a good way to understand what it does. But that's why we recommend creating documentation for component's API. I still prefer the |
In this case I would trust @yyx990803. The docs use Also be careful not to overload the guide. Being exhaustive with stuff which doesn't mater, will dilute the good parts, and make the guide harder to read. The attribute selector used by |
Hey guys ! =) For I don't have a fixed opinion on this. I'd follow what is proposed from Vue-Loader ( Thinking about it, I think I prefer this order anyway. The two opinions here are see the structure first or see the props first. I believe it makes me less scroll down to the props if that's what I'm looking for if the Maybe the guide is too directive on this though and should only state that people should stick to one structure over the whole project? |
Vue scoped styles don't use that, but this: http://caniuse.com/#search=CSS%202.1%20selectors |
Vue scoped styles aren't related to the official CSS scoped spec. Take a look here: https://github.com/vuejs/vue-loader/blob/master/docs/en/features/scoped-css.md
I believe all of us can agree with it, lol. |
@ErickPetru That's the idea ;) Although if that was just me, I agree with @aristidesfl :
|
I agree with you guys, no need to overload the guide, let's stick with the docs as much as possible, they are the source of truth, this guide should be complimentary. The fact that lots of stuff are removed from the guide is a good thing, the information becomes clearer and easier to grasp. Just look at the Vue.js docs, simple and straight to the point. |
I think I can close this issue then. Let's stick with the documentation that @yyx990803, which is the same we have on this style guide :D Thank you for your help on this issue guys. |
I really appreciate the time put for creating this guide. But I do not agree too much with the order proposed for
<template>
before<script>
.<template>
and<style>
next each other simplifies to think about structure and style together, without having to scroll up and down all the time while writing the styles.Anyway, I know it's just my personal opinion, but I'd like to see more people contributing with the discussion about advantages and disadvantages of each approach.
The text was updated successfully, but these errors were encountered: