Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component naming section is confusing to me #53

Closed
thedamon opened this issue Jul 13, 2017 · 2 comments
Closed

Component naming section is confusing to me #53

thedamon opened this issue Jul 13, 2017 · 2 comments

Comments

@thedamon
Copy link

thedamon commented Jul 13, 2017

Particularly this sentence: "app- namespaced: if very generic and otherwise 1 word, so that it can easily be reused in other projects."

Very generic components should have "app" as a namespace? Or should they have your app's name as a namespace ("myapp-")? Or is it using app as a namespace because in the example it is descriptive ( app-header for the header of the app)

Couldn't very generic components be easily used elsewhere? It sounds like it's saying to app-namespace things if they're very generic and otherwise make them one word, but this sentence could be read in 2 different ways.

Am I supposed to literally add app- in front of all components that are 1 word AND generic and not to any other ones?

I'm happy to try and clarify this if I can make it make sense to myself :)

@pablohpsilva
Copy link
Owner

Hello @thedamon :D
First things first: Thank you for opening this issue :D

What it meant was add myapp-, like the name of your application.

If you can create a PR with the changes, that would be awesome!

@mikeerickson
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants