Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Keep component props primitive' - typos in sample code #70

Closed
apdevelop opened this issue Feb 24, 2018 · 3 comments
Closed

'Keep component props primitive' - typos in sample code #70

apdevelop opened this issue Feb 24, 2018 · 3 comments

Comments

@apdevelop
Copy link
Contributor

Sample code in the Keep component props primitive section contains several typos:

<range-slider
  :values="[10, 20]"
  min="0" <!-- Should be :min="..." for evaluating as JS expression to Number -->
  max="100" <!-- Should be :max="..." for evaluating as JS expression to Number -->
  step="5"  <!-- Should be :step="..." for evaluating as JS expression to Number -->
  :on-slide="updateInputs"   <!-- Should be @on-slide="..." -->
  :on-end="updateResults"> <!-- Should be @on-end="..." -->
</range-slider>

See also Literal vs. Dynamic

@pablohpsilva
Copy link
Owner

Thank you @apdevelop ! Can you create a PR with the corrections?

@apdevelop
Copy link
Contributor Author

Done it! #75

@pablohpsilva
Copy link
Owner

Thank you once again! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants