-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Merge and clean up datetime docs #7372
Conversation
1a935be
to
f3bb3e6
Compare
Update datetime examples in demo-appBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
f3bb3e6
to
4e51df9
Compare
Update datetime examples in demo-appBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Update datetime docsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
b0c8744
to
17f4433
Compare
Update datetime docsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
It is built on top of the [react-day-picker v8](https://daypicker.dev/v8) library. | ||
Time selection is enabled by the [TimePicker](#datetime/timepicker) component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still care about sharing this information? This feels like is only relevant when comparing datetime and datetime2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fair question. I kept the references around since we explicitly mentioned it on the original DatePicker docs:
blueprint/packages/datetime/src/components/date-picker/datepicker.md
Lines 21 to 22 in d356c8e
**DatePicker** renders a UI to choose a single date and (optionally) a time of day. It is built on top of the | |
[**react-day-picker** library](https://github.com/gpbl/react-day-picker). Time selection is enabled by the |
Perhaps we can keep that reference in the updated docs and remove it for the other components.
Edit: 487fa1d
Invalidated by push of 487fa1d
docs: Remove react-day-picker reference from DateInput/DateRangeInputBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Part of #7293
Proposed changes
Updates
datetime
docs to reflect new components ported fromdatetime2
. Also deletes docs indatetime2
.Checklist
Reviewers should focus on:
Datetime docs should be logically consistent and current. There should be no broken links or references to old/outdated patterns from the legacy datetime components.