Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Merge and clean up datetime docs #7372

Merged
merged 8 commits into from
Mar 17, 2025
Merged

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Mar 17, 2025

Part of #7293

Proposed changes

Updates datetime docs to reflect new components ported from datetime2. Also deletes docs in datetime2.

Checklist

  • Includes tests
  • Update documentation

Reviewers should focus on:

Datetime docs should be logically consistent and current. There should be no broken links or references to old/outdated patterns from the legacy datetime components.

@svc-palantir-github
Copy link

Update datetime examples in demo-app

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Base automatically changed from gdouglas/rm-legacy-datetime-examples to bp6 March 17, 2025 15:52
@ggdouglas ggdouglas force-pushed the gdouglas/merge-datetime-docs branch from f3bb3e6 to 4e51df9 Compare March 17, 2025 15:55
@svc-palantir-github
Copy link

Update datetime examples in demo-app

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@svc-palantir-github
Copy link

Update datetime docs

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas force-pushed the gdouglas/merge-datetime-docs branch from b0c8744 to 17f4433 Compare March 17, 2025 17:50
@ggdouglas ggdouglas marked this pull request as ready for review March 17, 2025 17:54
@svc-palantir-github
Copy link

Update datetime docs

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

jscheiny
jscheiny previously approved these changes Mar 17, 2025
Copy link
Contributor

@jscheiny jscheiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment

Comment on lines +4 to +5
It is built on top of the [react-day-picker v8](https://daypicker.dev/v8) library.
Time selection is enabled by the [TimePicker](#datetime/timepicker) component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still care about sharing this information? This feels like is only relevant when comparing datetime and datetime2.

Copy link
Contributor Author

@ggdouglas ggdouglas Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fair question. I kept the references around since we explicitly mentioned it on the original DatePicker docs:

**DatePicker** renders a UI to choose a single date and (optionally) a time of day. It is built on top of the
[**react-day-picker** library](https://github.com/gpbl/react-day-picker). Time selection is enabled by the

Perhaps we can keep that reference in the updated docs and remove it for the other components.

Edit: 487fa1d

@policy-bot policy-bot bot dismissed jscheiny’s stale review March 17, 2025 18:44

Invalidated by push of 487fa1d

@svc-palantir-github
Copy link

docs: Remove react-day-picker reference from DateInput/DateRangeInput

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas merged commit bba87d6 into bp6 Mar 17, 2025
14 checks passed
@ggdouglas ggdouglas deleted the gdouglas/merge-datetime-docs branch March 17, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants